Re: [meta-mingw] [PATCH] grpc: use the new PACKAGECONFIG to disable shared

From: "Sinan Kaya" <okaya@kernel.org>
To: Joshua Watt <jpewhacker@gmail.com>, yocto@lists.yoctoproject.org
Subject: Re: [meta-mingw] [PATCH] grpc: use the new PACKAGECONFIG to disable shared
Date: Fri, 27 Aug 2021 16:47:40 -0400	[thread overview]
Message-ID: <c50780d8-e14d-1fa5-b2ab-7222c023e7ad@kernel.org> (raw)
In-Reply-To: <6ae884e8-4ec4-9595-d8ee-942fad9b0945@gmail.com>

On 8/27/2021 8:41 AM, Joshua Watt wrote:

>> @@ -1,5 +1,4 @@
>>   # doesn't build and not required
>>   DEPENDS:remove:mingw32 = "libnsl2"

> 
> This is good, thanks. Is the libnsl2 also tied to some feature? Perhaps
> you can explain why it needs to be removed from MinGW
> 

My research says libnsl is a soft requirement for c-ares.
GRPC assumes libnsl to be present and used by default.
However, it will build without it too.

https://www.linuxfromscratch.org/blfs/view/svn/basicnet/libnsl.html

We should be turning libnsl off if you want to enable GRPC's backward
compatibility mode. Maybe, because previous versions didn't support
libnsl.

c-ares
-------------
CMakeLists.txt:CARES_FUNCTION_IN_LIBRARY (gethostbyname nsl HAVE_LIBNSL)
CMakeLists.txt: LIST (APPEND CARES_DEPENDENT_LIBS nsl)

grpc
-------------
  if(gRPC_BACKWARDS_COMPATIBILITY_MODE)
    # See https://github.com/grpc/grpc/issues/17255
    set(HAVE_LIBNSL OFF CACHE BOOL "avoid cares dependency on libnsl")
  endif()

CMakeLists.txt:option(gRPC_BACKWARDS_COMPATIBILITY_MODE "Build libraries
that are binary compatible across a larger number of OS and libc
versions" OFF)
CMakeLists.txt:if(gRPC_BACKWARDS_COMPATIBILITY_MODE)