From: linmiaohe <linmiaohe@huawei.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Haiwei Li <lihaiwei.kernel@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"wanpengli@tencent.com" <wanpengli@tencent.com>,
"jmattson@google.com" <jmattson@google.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [PATCH] KVM: SVM: Fix "error" isn't initialized
Date: Wed, 27 Nov 2019 06:28:46 +0000 [thread overview]
Message-ID: <c526ce98659242a2a9f22ec898d7647d@huawei.com> (raw)
On 2019/11/27 11:44, Sean Christopherson wrote:
> On Wed, Nov 27, 2019 at 03:30:06AM +0000, linmiaohe wrote:
>>
>>> From: Haiwei Li <lihaiwei@tencent.com>
>>> Subject: [PATCH] initialize 'error'
>>>
>>> There are a bunch of error paths were "error" isn't initialized.
>> Hi,
>> In case error case, sev_guest_df_flush() do not set the error.
>> Can you set the value of error to reflect what error happened in
>> sev_guest_df_flush()?
>> The current fix may looks confused when print "DF_FLUSH failed" with
>> error = 0.
>> Thanks.
>>
>> PS: This is just my personal point.
>
> Disclaimer: not my world at all...
>
> Based on the prototype for __sev_do_cmd_locked(), @error is intended
> to be filled only if there's an actual response from the PSP, which is
> a 16-bit value. So maybe init @psp_ret at the beginning of
> __sev_do_cmd_locked() to
> -1 to indicate the command was never sent to the PSP? And update the
> pr_err() in sev_asid_flush() to explicitly state it's the PSP return?
>
I think it's a good alternative. Many Thanks.
next reply other threads:[~2019-11-27 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 6:28 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-27 3:30 [PATCH] KVM: SVM: Fix "error" isn't initialized linmiaohe
2019-11-27 3:44 ` Sean Christopherson
2019-11-27 5:38 ` Haiwei Li
2019-11-27 3:05 Haiwei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c526ce98659242a2a9f22ec898d7647d@huawei.com \
--to=linmiaohe@huawei.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=lihaiwei.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.