From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <paul@xen.org>
Cc: Paul Durrant <pdurrant@amazon.com>,
Kevin Tian <kevin.tian@intel.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v10 5/7] vtd: use a bit field for root_entry
Date: Fri, 27 Nov 2020 16:11:42 +0100 [thread overview]
Message-ID: <c53f148f-0d3d-764d-7a50-f85ec5e30737@suse.com> (raw)
In-Reply-To: <20201120132440.1141-6-paul@xen.org>
On 20.11.2020 14:24, Paul Durrant wrote:
> @@ -85,25 +85,28 @@ static bool device_in_domain(const struct vtd_iommu *iommu,
> return false;
> }
>
> - root_entry = map_vtd_domain_page(iommu->root_maddr);
> - if ( !root_present(root_entry[pdev->bus]) )
> + root_entries = (struct root_entry *)map_vtd_domain_page(iommu->root_maddr);
Why the cast, the more that ...
> + root_entry = &root_entries[pdev->bus];
> + if ( !root_entry->p )
> goto out;
>
> - ctxt_entry = map_vtd_domain_page(root_entry[pdev->bus].val);
> - if ( context_domain_id(ctxt_entry[pdev->devfn]) != did )
> + context_entries = map_vtd_domain_page(root_entry->ctp);
... you have none here? With this dropped
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
next prev parent reply other threads:[~2020-11-27 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 13:24 [PATCH v10 0/7] IOMMU cleanup Paul Durrant
2020-11-20 13:24 ` [PATCH v10 1/7] remove remaining uses of iommu_legacy_map/unmap Paul Durrant
2020-11-27 14:39 ` Jan Beulich
2020-11-20 13:24 ` [PATCH v10 2/7] common/grant_table: batch flush I/O TLB Paul Durrant
2020-11-20 13:24 ` [PATCH v10 3/7] iommu: remove the share_p2m operation Paul Durrant
2020-11-20 13:24 ` [PATCH v10 4/7] iommu: stop calling IOMMU page tables 'p2m tables' Paul Durrant
2020-11-20 13:24 ` [PATCH v10 5/7] vtd: use a bit field for root_entry Paul Durrant
2020-11-27 15:11 ` Jan Beulich [this message]
2020-11-30 3:06 ` Tian, Kevin
2020-11-30 9:45 ` Jan Beulich
2020-12-01 5:14 ` Tian, Kevin
2020-11-20 13:24 ` [PATCH v10 6/7] vtd: use a bit field for context_entry Paul Durrant
2020-11-27 15:32 ` Jan Beulich
2020-11-30 3:10 ` Tian, Kevin
2020-11-20 13:24 ` [PATCH v10 7/7] vtd: use a bit field for dma_pte Paul Durrant
2020-11-27 16:02 ` Jan Beulich
2020-11-30 5:29 ` Tian, Kevin
2020-11-27 16:21 ` [PATCH v10 0/7] IOMMU cleanup Jan Beulich
2020-11-27 16:32 ` Durrant, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c53f148f-0d3d-764d-7a50-f85ec5e30737@suse.com \
--to=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.