All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	buildroot@buildroot.org
Cc: Michael Nosthoff <buildroot@heine.tech>,
	Maxim Kochetkov <fido_max@inbox.ru>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Romain Naour <romain.naour@gmail.com>,
	Matt Weber <matthew.weber@collins.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large
Date: Tue, 17 Aug 2021 23:04:43 +0200	[thread overview]
Message-ID: <c5580997-9132-2baf-09e6-7c116f0b44f8@mind.be> (raw)
In-Reply-To: <20210726223435.2906458-2-giulio.benetti@benettiengineering.com>



On 27/07/2021 00:34, Giulio Benetti wrote:
> When building libgeos for or1k -mcmodel=large is needed to link, so let's
> add that gcc option in case we're building for or1k.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 Applied to master, thanks.

 I've added a comment to the commit message to explain that this option is from
a Buildroot patch.

 I've also applied the second patch with the same comment.

 Regards,
 Arnout

> ---
>  package/libgeos/libgeos.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
> index a355732af8..43211d0434 100644
> --- a/package/libgeos/libgeos.mk
> +++ b/package/libgeos/libgeos.mk
> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>  LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>  endif
>  
> +ifeq ($(BR2_or1k),y)
> +LIBGEOS_CXXFLAGS += -mcmodel=large
> +endif
> +
>  LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>  
>  $(eval $(cmake-package))
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  parent reply	other threads:[~2021-08-17 21:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 14:09 [Buildroot] [PATCH v2] toolchain: remove binutils bug 21464 Giulio Benetti
2021-05-24  4:11 ` Maxim Kochetkov
2021-07-26 21:53 ` Thomas Petazzoni
2021-07-26 21:56 ` Thomas Petazzoni
2021-07-26 22:03   ` Giulio Benetti
2021-07-26 22:34   ` [Buildroot] [PATCH v2 0/3] Fix binutils bug 21464 and remove it Giulio Benetti
2021-07-26 22:34     ` [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large Giulio Benetti
2021-07-27  4:26       ` Maxim Kochetkov via buildroot
2021-08-17 20:34       ` Arnout Vandecappelle
2021-08-17 20:56         ` Giulio Benetti
2021-08-17 20:59         ` Arnout Vandecappelle
2021-08-18 20:01         ` Romain Naour
2021-08-18 20:54           ` Giulio Benetti
2021-08-17 21:04       ` Arnout Vandecappelle [this message]
2021-07-26 22:34     ` [Buildroot] [PATCH v2 2/3] package/protobuf: " Giulio Benetti
2021-07-27  4:26       ` Maxim Kochetkov
2021-07-26 22:34     ` [Buildroot] [PATCH v2 3/3] toolchain: remove binutils bug 21464 Giulio Benetti
2021-08-17 21:11       ` Arnout Vandecappelle
2021-08-17 21:27         ` Giulio Benetti
2021-12-30 20:05           ` Giulio Benetti
2021-12-30 20:12             ` [Buildroot] [PATCH] package/protobuf: drop dependency on " Giulio Benetti
2021-12-30 20:19               ` Thomas Petazzoni
2021-12-30 20:36             ` [Buildroot] [PATCH v2 3/3] toolchain: remove " Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5580997-9132-2baf-09e6-7c116f0b44f8@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=buildroot@heine.tech \
    --cc=fido_max@inbox.ru \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=matthew.weber@collins.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.de_schampheleire@nokia.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.