From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS Date: Fri, 28 Sep 2018 12:29:21 -0500 Message-ID: References: <20180427140358.30839-1-elder@linaro.org> <20180928122616.GA5249@centauri.lan> <4025f206-631a-55e9-9b7a-89dcf3370284@linaro.org> <20180928172145.GA5008@tuxbook-pro> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180928172145.GA5008@tuxbook-pro> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: Niklas Cassel , andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 09/28/2018 12:21 PM, Bjorn Andersson wrote: >> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS. I could >> change that to select it instead but I still think this entry >> should be changed. I was thinking one of two changes: - Add the prompt string (which I suggested) - Don't add the prompt, but remove the help and/or add a comment to indicate that the lack of prompt is intentional (because it really looked like an oversight to me) I don't really care though; I'll change my code to select it rather than depend on it. > Why do you say it needs to change? I tested this by just adding a > "select QCOM_QMI_HELPERS" in my client drivers. > >> I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig >> also depends on--rather than selects--QCOM_QMI_HELPERS. >> > That's wrong. Maybe someone else should fix this, but I can do it if you like (and if that's the case, say so). -Alex