From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965C37B for ; Wed, 15 Feb 2023 08:29:26 +0000 (UTC) Received: by mail-wr1-f46.google.com with SMTP id bu23so18181480wrb.8 for ; Wed, 15 Feb 2023 00:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D+uRuWA2my0PkLfTRJkVAZ05w6wbQaFzpjSQTlA3Y10=; b=EAjtSefiFMcRJUjTT1vKa++/98Yo1SN60xpEBkPSeru5QVrOombFl7ZHZ9y0eBb+k8 1ZpycnMJayGmVT6T6UnuPRjCB3nPxmBujGFtXaNp8cbOZSlWgdaIEhXU+GGjztzV/czy 1WDq6VfomA00oo7hLpCf0eBYSqerRkvKuSrVmRTM4XbxzJrQVoIbRj0AGC+iAePl6sTf Z2xptiD/VOo1nfoRA4XWNffLKM3ZE08q46EkUvIRst5VglioETpQYFtr/iY0tCSkcOlD bJtursUf7vQFXV0RL9Rz9XvQSF18NBopDoEorHB9a2ffDlY3yM0iSt8r0hW9VmbKY8B/ Tfog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D+uRuWA2my0PkLfTRJkVAZ05w6wbQaFzpjSQTlA3Y10=; b=qt/ZHsuQJCGa7FFGCfJ3h2e7vTzbQPKN7Uxj2lMCULbq8e8TW3s1igEHk4C602gYaX 0RjHe+6Pcn3uu7VPEn4ZrC7/08R3MzvTiRzfE4rLNXEUKm5W6EOral+pgloraC1nkMyS 9u3cwe4d7vDVIOvMBuivzR58lTv6Zxk/0aEOx6B4GV1c2O3u5aN52zqKJvaQ2EFQSpnX eDy6j9hcAZQTJ86xCUXGazkIMiV9qMsIQaaq2w5q1DwocaVI7elGoUQmbNJIcN/IcHTs zRzj/VmWDkWlEedTghmptIuBqsaNTsUPgr1dpgxnLz0wm4XdTV4VrotSoQKgiNm1rtBh Ib5A== X-Gm-Message-State: AO0yUKVlXQVOjjDjN5KgYNgYmyRfp1clrgOqIQRSBL+vNaX+nbQ6hRL8 dNO72TAdlf6V6A6JvZHIGdmJvw== X-Google-Smtp-Source: AK7set8G2iiFdHjvUAVVY5llFOflusvwqwWTyX5fVt/Awzv2HxyXMg5++kq1nd94kDMQiFL/tQeRqw== X-Received: by 2002:a5d:67cc:0:b0:2c5:58fc:e1bb with SMTP id n12-20020a5d67cc000000b002c558fce1bbmr826926wrw.10.1676449764713; Wed, 15 Feb 2023 00:29:24 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id i2-20020adfefc2000000b002c553e061fdsm8524783wrp.112.2023.02.15.00.29.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 00:29:24 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 09:29:20 +0100 Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition Content-Language: en-US To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org References: <39835bc75af2e812fce56400533cb2ab41bcf0e2.1676358308.git.jpoimboe@kernel.org> <080a5ccb-7fa0-1a75-538f-a09dc146fc4e@linaro.org> <20230214181101.3a2tscbmwdnwbqpu@treble> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230214181101.3a2tscbmwdnwbqpu@treble> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/2/23 19:11, Josh Poimboeuf wrote: > On Tue, Feb 14, 2023 at 08:46:41AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Josh, >> >> On 14/2/23 08:05, Josh Poimboeuf wrote: >>> Include to make sure play_dead() matches its prototype going >>> forward. >>> >>> Acked-by: Florian Fainelli >>> Signed-off-by: Josh Poimboeuf >>> --- >>> arch/mips/kernel/smp-bmips.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c >>> index f5d7bfa3472a..df9158e8329d 100644 >>> --- a/arch/mips/kernel/smp-bmips.c >>> +++ b/arch/mips/kernel/smp-bmips.c >>> @@ -38,6 +38,7 @@ >>> #include >>> #include >>> #include >>> +#include >> >> What about the other implementations? >> >> $ git grep -L asm/smp.h $(git grep -wlF 'play_dead(void)' arch/mips) >> arch/mips/cavium-octeon/smp.c >> arch/mips/kernel/smp-bmips.c >> arch/mips/kernel/smp-cps.c >> arch/mips/loongson64/smp.c > > Indeed. I really wish we had -Wmissing-prototypes. > > I'll squash this in: > > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 89954f5f87fb..4212584e6efa 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > > diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c > index bcd6a944b839..6d69a9ba8167 100644 > --- a/arch/mips/kernel/smp-cps.c > +++ b/arch/mips/kernel/smp-cps.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c > index c81c2bd07c62..df8d789ede3c 100644 > --- a/arch/mips/loongson64/smp.c > +++ b/arch/mips/loongson64/smp.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include Reviewed-by: Philippe Mathieu-Daudé Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87A42C636D4 for ; Wed, 15 Feb 2023 08:30:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PGrqj07Kwz3chQ for ; Wed, 15 Feb 2023 19:30:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=EAjtSefi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::432; helo=mail-wr1-x432.google.com; envelope-from=philmd@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=EAjtSefi; dkim-atps=neutral Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PGrpg4VMPz2x9d for ; Wed, 15 Feb 2023 19:29:28 +1100 (AEDT) Received: by mail-wr1-x432.google.com with SMTP id o15so14885859wrc.9 for ; Wed, 15 Feb 2023 00:29:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D+uRuWA2my0PkLfTRJkVAZ05w6wbQaFzpjSQTlA3Y10=; b=EAjtSefiFMcRJUjTT1vKa++/98Yo1SN60xpEBkPSeru5QVrOombFl7ZHZ9y0eBb+k8 1ZpycnMJayGmVT6T6UnuPRjCB3nPxmBujGFtXaNp8cbOZSlWgdaIEhXU+GGjztzV/czy 1WDq6VfomA00oo7hLpCf0eBYSqerRkvKuSrVmRTM4XbxzJrQVoIbRj0AGC+iAePl6sTf Z2xptiD/VOo1nfoRA4XWNffLKM3ZE08q46EkUvIRst5VglioETpQYFtr/iY0tCSkcOlD bJtursUf7vQFXV0RL9Rz9XvQSF18NBopDoEorHB9a2ffDlY3yM0iSt8r0hW9VmbKY8B/ Tfog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D+uRuWA2my0PkLfTRJkVAZ05w6wbQaFzpjSQTlA3Y10=; b=WPW1o7iYv7vVM9tZ9YIMzD2dbpjzX9hW/VuBMGzq80igbgFQLoPsW+zkjdnwmSAzTN jeeaais9GkcyAuEOhVaxFsDsfb63uNQrOIb85I3YrRynHnf/IeoWftwPFHU6Pd3BB1we QZQsQHAVdoKiRZnz4RRkkAVtvUSuFBK3xiOr16jwDTx/4Wyis3vxBIOUzpxmS8Z8+tFd 3h44Z1rSqD0Ht4yO7AyxZtKXVqk5SMviawJBYUQhvUwn0QFKfvTxsP6YEkA4Iw6y8Ddp cNKxx7WIejODQ9g1WjN/pLMF+kxU/6Tz9dE4zwzJ2+P+BWgXm5ld4YsboFbijcl9qpDa gjyA== X-Gm-Message-State: AO0yUKWFgGpLXNdp1iLNwaGns0kRNhZRnYyfVmnzZhDEAUmuUh9jWnw/ LGbBUcbl3foycNk2QB+2hF+vDg== X-Google-Smtp-Source: AK7set8G2iiFdHjvUAVVY5llFOflusvwqwWTyX5fVt/Awzv2HxyXMg5++kq1nd94kDMQiFL/tQeRqw== X-Received: by 2002:a5d:67cc:0:b0:2c5:58fc:e1bb with SMTP id n12-20020a5d67cc000000b002c558fce1bbmr826926wrw.10.1676449764713; Wed, 15 Feb 2023 00:29:24 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id i2-20020adfefc2000000b002c553e061fdsm8524783wrp.112.2023.02.15.00.29.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 00:29:24 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 09:29:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition Content-Language: en-US To: Josh Poimboeuf References: <39835bc75af2e812fce56400533cb2ab41bcf0e2.1676358308.git.jpoimboe@kernel.org> <080a5ccb-7fa0-1a75-538f-a09dc146fc4e@linaro.org> <20230214181101.3a2tscbmwdnwbqpu@treble> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230214181101.3a2tscbmwdnwbqpu@treble> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: juri.lelli@redhat.com, dalias@libc.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, x86@kernel.org, jiaxun.yang@flygoat.com, linux-mips@vger.kernel.org, bsegall@google.com, jcmvbkbc@gmail.com, guoren@kernel.org, hpa@zytor.com, sparclinux@vger.kernel.org, kernel@xen0n.name, will@kernel.org, vschneid@redhat.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, ysato@users.sourceforge.jp, chenhuacai@kernel.org, linux@armlinux.org.uk, linux-csky@vger.kernel.org, mingo@redhat.com, bcm-kernel-feedback-list@broadcom.com, mgorman@suse.de, mattst88@gmail.com, linux-xtensa@linux-xtensa.org, paulmck@kernel.org, richard.henderson@linaro.org, npiggin@gmail.com, ink@jurassic.park.msu.ru, rostedt@goodmis.org, loongarch@lists.linux.dev, tglx@linutronix.de, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, jgross@suse.com, chris@zankel.net, tsbogend@alpha.franken.de, bristot@redhat.com, linux-kern el@vger.kernel.org, linux-alpha@vger.kernel.org, bp@alien8.de, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 14/2/23 19:11, Josh Poimboeuf wrote: > On Tue, Feb 14, 2023 at 08:46:41AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Josh, >> >> On 14/2/23 08:05, Josh Poimboeuf wrote: >>> Include to make sure play_dead() matches its prototype going >>> forward. >>> >>> Acked-by: Florian Fainelli >>> Signed-off-by: Josh Poimboeuf >>> --- >>> arch/mips/kernel/smp-bmips.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c >>> index f5d7bfa3472a..df9158e8329d 100644 >>> --- a/arch/mips/kernel/smp-bmips.c >>> +++ b/arch/mips/kernel/smp-bmips.c >>> @@ -38,6 +38,7 @@ >>> #include >>> #include >>> #include >>> +#include >> >> What about the other implementations? >> >> $ git grep -L asm/smp.h $(git grep -wlF 'play_dead(void)' arch/mips) >> arch/mips/cavium-octeon/smp.c >> arch/mips/kernel/smp-bmips.c >> arch/mips/kernel/smp-cps.c >> arch/mips/loongson64/smp.c > > Indeed. I really wish we had -Wmissing-prototypes. > > I'll squash this in: > > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 89954f5f87fb..4212584e6efa 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > > diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c > index bcd6a944b839..6d69a9ba8167 100644 > --- a/arch/mips/kernel/smp-cps.c > +++ b/arch/mips/kernel/smp-cps.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c > index c81c2bd07c62..df8d789ede3c 100644 > --- a/arch/mips/loongson64/smp.c > +++ b/arch/mips/loongson64/smp.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include Reviewed-by: Philippe Mathieu-Daudé Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Date: Wed, 15 Feb 2023 08:29:20 +0000 Subject: Re: [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition Message-Id: List-Id: References: <39835bc75af2e812fce56400533cb2ab41bcf0e2.1676358308.git.jpoimboe@kernel.org> <080a5ccb-7fa0-1a75-538f-a09dc146fc4e@linaro.org> <20230214181101.3a2tscbmwdnwbqpu@treble> In-Reply-To: <20230214181101.3a2tscbmwdnwbqpu@treble> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org On 14/2/23 19:11, Josh Poimboeuf wrote: > On Tue, Feb 14, 2023 at 08:46:41AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Josh, >> >> On 14/2/23 08:05, Josh Poimboeuf wrote: >>> Include to make sure play_dead() matches its prototype going >>> forward. >>> >>> Acked-by: Florian Fainelli >>> Signed-off-by: Josh Poimboeuf >>> --- >>> arch/mips/kernel/smp-bmips.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c >>> index f5d7bfa3472a..df9158e8329d 100644 >>> --- a/arch/mips/kernel/smp-bmips.c >>> +++ b/arch/mips/kernel/smp-bmips.c >>> @@ -38,6 +38,7 @@ >>> #include >>> #include >>> #include >>> +#include >> >> What about the other implementations? >> >> $ git grep -L asm/smp.h $(git grep -wlF 'play_dead(void)' arch/mips) >> arch/mips/cavium-octeon/smp.c >> arch/mips/kernel/smp-bmips.c >> arch/mips/kernel/smp-cps.c >> arch/mips/loongson64/smp.c > > Indeed. I really wish we had -Wmissing-prototypes. > > I'll squash this in: > > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 89954f5f87fb..4212584e6efa 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > > diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c > index bcd6a944b839..6d69a9ba8167 100644 > --- a/arch/mips/kernel/smp-cps.c > +++ b/arch/mips/kernel/smp-cps.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c > index c81c2bd07c62..df8d789ede3c 100644 > --- a/arch/mips/loongson64/smp.c > +++ b/arch/mips/loongson64/smp.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include Reviewed-by: Philippe Mathieu-Daudé Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Subject: Re: [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition Date: Wed, 15 Feb 2023 09:29:20 +0100 Message-ID: References: <39835bc75af2e812fce56400533cb2ab41bcf0e2.1676358308.git.jpoimboe@kernel.org> <080a5ccb-7fa0-1a75-538f-a09dc146fc4e@linaro.org> <20230214181101.3a2tscbmwdnwbqpu@treble> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D+uRuWA2my0PkLfTRJkVAZ05w6wbQaFzpjSQTlA3Y10=; b=EAjtSefiFMcRJUjTT1vKa++/98Yo1SN60xpEBkPSeru5QVrOombFl7ZHZ9y0eBb+k8 1ZpycnMJayGmVT6T6UnuPRjCB3nPxmBujGFtXaNp8cbOZSlWgdaIEhXU+GGjztzV/czy 1WDq6VfomA00oo7hLpCf0eBYSqerRkvKuSrVmRTM4XbxzJrQVoIbRj0AGC+iAePl6sTf Z2xptiD/VOo1nfoRA4XWNffLKM3ZE08q46EkUvIRst5VglioETpQYFtr/iY0tCSkcOlD bJtursUf7vQFXV0RL9Rz9XvQSF18NBopDoEorHB9a2ffDlY3yM0iSt8r0hW9VmbKY8B/ Tfog== Content-Language: en-US In-Reply-To: <20230214181101.3a2tscbmwdnwbqpu@treble> List-ID: Content-Type: text/plain; charset="utf-8"; format="flowed" To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat. On 14/2/23 19:11, Josh Poimboeuf wrote: > On Tue, Feb 14, 2023 at 08:46:41AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Josh, >> >> On 14/2/23 08:05, Josh Poimboeuf wrote: >>> Include to make sure play_dead() matches its prototype going >>> forward. >>> >>> Acked-by: Florian Fainelli >>> Signed-off-by: Josh Poimboeuf >>> --- >>> arch/mips/kernel/smp-bmips.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c >>> index f5d7bfa3472a..df9158e8329d 100644 >>> --- a/arch/mips/kernel/smp-bmips.c >>> +++ b/arch/mips/kernel/smp-bmips.c >>> @@ -38,6 +38,7 @@ >>> #include >>> #include >>> #include >>> +#include >> >> What about the other implementations? >> >> $ git grep -L asm/smp.h $(git grep -wlF 'play_dead(void)' arch/mips) >> arch/mips/cavium-octeon/smp.c >> arch/mips/kernel/smp-bmips.c >> arch/mips/kernel/smp-cps.c >> arch/mips/loongson64/smp.c > > Indeed. I really wish we had -Wmissing-prototypes. > > I'll squash this in: > > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 89954f5f87fb..4212584e6efa 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > > diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c > index bcd6a944b839..6d69a9ba8167 100644 > --- a/arch/mips/kernel/smp-cps.c > +++ b/arch/mips/kernel/smp-cps.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c > index c81c2bd07c62..df8d789ede3c 100644 > --- a/arch/mips/loongson64/smp.c > +++ b/arch/mips/loongson64/smp.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include Reviewed-by: Philippe Mathieu-Daudé Thanks.