From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAF8CC54EE9 for ; Thu, 22 Sep 2022 12:19:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21B3D10E31E; Thu, 22 Sep 2022 12:19:28 +0000 (UTC) Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7337B10E31E for ; Thu, 22 Sep 2022 12:19:25 +0000 (UTC) Received: by mail-lj1-x236.google.com with SMTP id b6so10728202ljr.10 for ; Thu, 22 Sep 2022 05:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=i/CqszIZh8P8j8dT9+oh4Z05nb+Y/d9c5WZtIgCuPK4=; b=eWNWfK3AFvDG834Zr5HLamysLgoxgnhiVcHys2gwwAw3rDhz/igUHQje6QxB0TFrTB sVfARPMH7lzuZONx2KjOz0uo1uxfiT8zRHkQU3c4V1+eF7vS94ip90V8hdtm3pJtBz9H lwikVgkBVSNf+u4kTMEh/t8zpFUk8fSHyOFzIDJVIqBi07ZleWJnFiwk+huYJzu9DsVf b++ZPMq57UblLG1WXxO3r64OhshLCHIKslLAdjHxM7dOdU0zkZoyz7IqDzg719homNhv lKnAQJvQKjJFiXyoLfGFBPvmn7SRYLLq9S0QQTV6qkcpNJlHqHZtc99OpsLGbUeGRJ3C 1Wsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=i/CqszIZh8P8j8dT9+oh4Z05nb+Y/d9c5WZtIgCuPK4=; b=a3BTWXJZTqj+U+cFcH0upt8J4Lsois2JQinGHMzGZq8l2GC6ZmbwhnvDMVhISRvqRg pR78XK0T9rC9hVUyqkHmwDxbazVoFblDHw6rdL8w1NQGs0soN9IZk+LZHSVtqh75TaCZ KfCvVvKlYT9UxoKubCsB4LEJeHB6Y73Ibb8HPM/hcBAJCyKVogI8WE0hyVntxpDapwl6 5xtd/cVZoqnwL0GOfyUC4KmuRfz2dYASQoge4aDffDfz5Ir/t2TI0fgathGZeKYV6Pk1 WFBISUBkVc0E0D1eI8AfCRhOr8HsiLNjzr3uhXO0pJDC+CwWv/HjsTpbiogt19R5Fvxf LHig== X-Gm-Message-State: ACrzQf0tAPGcdTOuyQjFMWvueh9manpV8UW7QI8lnt8SZW8q+YQA0sW1 bQPgs2VYq1qlPA5KX7kHs704CQ== X-Google-Smtp-Source: AMsMyM41dt9zEaCoTFYzG8+Ztkoxoj8ww69k27iIEzfmtLlQGjVlrZWR99FqsS2XlQV9tAm5X4ZXTQ== X-Received: by 2002:a05:651c:201e:b0:26b:e78e:c2e8 with SMTP id s30-20020a05651c201e00b0026be78ec2e8mr1021216ljo.431.1663849163830; Thu, 22 Sep 2022 05:19:23 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id x3-20020a19e003000000b004979dc8038esm911628lfg.201.2022.09.22.05.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:19:23 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 14:19:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts Content-Language: en-US To: Dmitry Baryshkov References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-7-dmitry.baryshkov@linaro.org> <94bc039f-065e-ebfa-e09b-7fdb5f4be89b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Abhinav Kumar , Rob Herring , Stephen Boyd , Andy Gross , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , freedreno@lists.freedesktop.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 22/09/2022 12:30, Dmitry Baryshkov wrote: >>> + display-subsystem@ae00000 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + compatible = "qcom,sc7180-mdss"; >>> + reg = <0xae00000 0x1000>; >>> + reg-names = "mdss"; >>> + power-domains = <&dispcc MDSS_GDSC>; >>> + clocks = <&gcc GCC_DISP_AHB_CLK>, >>> + <&dispcc DISP_CC_MDSS_AHB_CLK>, >>> + <&dispcc DISP_CC_MDSS_MDP_CLK>; >>> + clock-names = "iface", "ahb", "core"; >>> + >>> + interrupts = ; >>> + interrupt-controller; >>> + #interrupt-cells = <1>; >>> + >>> + interconnects = <&mmss_noc MASTER_MDP0 &mc_virt SLAVE_EBI1>; >>> + interconnect-names = "mdp0-mem"; >>> + >>> + iommus = <&apps_smmu 0x800 0x2>; >>> + ranges; >> >> This should come with full example, so with display-controller child >> (unless Rob asked not to?) > > I'm not sure here. We have an example of a display-controller in a > separate schema file. Why would you like to duplicate it? To validate the child node (display-controller) in the context of this schema. The child node is essential, so I would also say that example is incomplete. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B42E0C54EE9 for ; Thu, 22 Sep 2022 12:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbiIVMTb (ORCPT ); Thu, 22 Sep 2022 08:19:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231269AbiIVMTa (ORCPT ); Thu, 22 Sep 2022 08:19:30 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF7F4E5123 for ; Thu, 22 Sep 2022 05:19:25 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id j24so10248978lja.4 for ; Thu, 22 Sep 2022 05:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=i/CqszIZh8P8j8dT9+oh4Z05nb+Y/d9c5WZtIgCuPK4=; b=eWNWfK3AFvDG834Zr5HLamysLgoxgnhiVcHys2gwwAw3rDhz/igUHQje6QxB0TFrTB sVfARPMH7lzuZONx2KjOz0uo1uxfiT8zRHkQU3c4V1+eF7vS94ip90V8hdtm3pJtBz9H lwikVgkBVSNf+u4kTMEh/t8zpFUk8fSHyOFzIDJVIqBi07ZleWJnFiwk+huYJzu9DsVf b++ZPMq57UblLG1WXxO3r64OhshLCHIKslLAdjHxM7dOdU0zkZoyz7IqDzg719homNhv lKnAQJvQKjJFiXyoLfGFBPvmn7SRYLLq9S0QQTV6qkcpNJlHqHZtc99OpsLGbUeGRJ3C 1Wsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=i/CqszIZh8P8j8dT9+oh4Z05nb+Y/d9c5WZtIgCuPK4=; b=i+n0HPTzVetnGtv1VpgZlsCY2sPve4PeXeD/dZ2sYo5MUKkMq5tuPsMzg9rq/ufsNa CQPFJcDh1kjOJPqHl2aJt5enind4etXnIXu+MqAaJWcOhAENHuzMsA9T27Ike/E7icZ4 Icsutp/mFv6zjm6bLTW+Zs8oeliRpjhZzKv5auMXMnqCs2eMrarSNjEFOWJxc5G3q8JY w5dVgqOsGjRv0m3LAA8WHChYT7i5F+2jg0rVwmJD4S5pe3uoSvRQgb+WLs6MhSuStW3D sFk30AXK9A9BCulv/vYh8lJWwHme2FZLdoczO7esSt6YU5xqpGmAUvXz/M32OF6msBOr fAoQ== X-Gm-Message-State: ACrzQf2WS1fiUtUXrqAFZ5PSh7xoOgeIlqhVveA+JcERZaoQl8EnRIhU 3v+xhEnB4ry8GX1EwVM7l4myqA== X-Google-Smtp-Source: AMsMyM41dt9zEaCoTFYzG8+Ztkoxoj8ww69k27iIEzfmtLlQGjVlrZWR99FqsS2XlQV9tAm5X4ZXTQ== X-Received: by 2002:a05:651c:201e:b0:26b:e78e:c2e8 with SMTP id s30-20020a05651c201e00b0026be78ec2e8mr1021216ljo.431.1663849163830; Thu, 22 Sep 2022 05:19:23 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id x3-20020a19e003000000b004979dc8038esm911628lfg.201.2022.09.22.05.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:19:23 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 14:19:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts Content-Language: en-US To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-7-dmitry.baryshkov@linaro.org> <94bc039f-065e-ebfa-e09b-7fdb5f4be89b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/09/2022 12:30, Dmitry Baryshkov wrote: >>> + display-subsystem@ae00000 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + compatible = "qcom,sc7180-mdss"; >>> + reg = <0xae00000 0x1000>; >>> + reg-names = "mdss"; >>> + power-domains = <&dispcc MDSS_GDSC>; >>> + clocks = <&gcc GCC_DISP_AHB_CLK>, >>> + <&dispcc DISP_CC_MDSS_AHB_CLK>, >>> + <&dispcc DISP_CC_MDSS_MDP_CLK>; >>> + clock-names = "iface", "ahb", "core"; >>> + >>> + interrupts = ; >>> + interrupt-controller; >>> + #interrupt-cells = <1>; >>> + >>> + interconnects = <&mmss_noc MASTER_MDP0 &mc_virt SLAVE_EBI1>; >>> + interconnect-names = "mdp0-mem"; >>> + >>> + iommus = <&apps_smmu 0x800 0x2>; >>> + ranges; >> >> This should come with full example, so with display-controller child >> (unless Rob asked not to?) > > I'm not sure here. We have an example of a display-controller in a > separate schema file. Why would you like to duplicate it? To validate the child node (display-controller) in the context of this schema. The child node is essential, so I would also say that example is incomplete. Best regards, Krzysztof