From: Johannes Thumshirn <jthumshirn@suse.de>
To: James Bottomley <jejb@linux.vnet.ibm.com>,
John Garry <john.garry@huawei.com>,
Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
satishkh@cisco.com, sebaddel@cisco.com, kartilak@cisco.com,
martin.petersen@oracle.com
Cc: jrdr.linux@gmail.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, brajeswar.linux@gmail.com
Subject: Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
Date: Tue, 13 Nov 2018 17:16:26 +0100 [thread overview]
Message-ID: <c58db296-87ec-5aaf-f6ce-1115d5d2a2c1@suse.de> (raw)
In-Reply-To: <1542125473.3042.6.camel@linux.vnet.ibm.com>
On 13/11/2018 17:11, James Bottomley wrote:
> This is incorrect advice: there's no need to cast it to other *pointer*
> types, but if you cast it to a non-pointer type (which this is doing)
> the compiler will complain if there is no explicit cast.
Right, sorry for that and thanks for spotting it James.
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2018-11-13 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 15:08 [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc Sabyasachi Gupta
2018-11-13 15:44 ` John Garry
2018-11-13 15:44 ` John Garry
2018-11-13 15:53 ` Johannes Thumshirn
2018-11-13 16:04 ` Sabyasachi Gupta
2018-11-13 16:11 ` James Bottomley
2018-11-13 16:16 ` Johannes Thumshirn [this message]
2018-11-13 16:22 ` Sabyasachi Gupta
2018-11-13 16:25 ` Johannes Thumshirn
2018-11-14 10:44 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c58db296-87ec-5aaf-f6ce-1115d5d2a2c1@suse.de \
--to=jthumshirn@suse.de \
--cc=brajeswar.linux@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=jrdr.linux@gmail.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sabyasachi.linux@gmail.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.