From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF2BEC433EF for ; Tue, 8 Feb 2022 23:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239042AbiBHX7a (ORCPT ); Tue, 8 Feb 2022 18:59:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239016AbiBHX72 (ORCPT ); Tue, 8 Feb 2022 18:59:28 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D7A68C061577 for ; Tue, 8 Feb 2022 15:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644364767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1B+HhoEdav6Cob3bPb/BF6nu8D/2OQMn0TX9fIjaHGQ=; b=ic2wNtBUam2bz3I4ll/IUk94uFAfcHQdZaWPQd7Hg+vh4iRcpSU//sYaSmkxWOpXWX8Dqf jJ7dLcG3zHG9eU3zRy9SURbxI+vMn7Ud03/0m+klpZoeBEFWgFVh6Px2etZcYHvuf8dK01 lp69zuxLHkDb/xBdiBYGlXxCzxoJS08= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-106-CuqG3tJ7M4qhx5ukxKXnTQ-1; Tue, 08 Feb 2022 18:59:25 -0500 X-MC-Unique: CuqG3tJ7M4qhx5ukxKXnTQ-1 Received: by mail-wr1-f71.google.com with SMTP id g17-20020adfa591000000b001da86c91c22so308821wrc.5 for ; Tue, 08 Feb 2022 15:59:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1B+HhoEdav6Cob3bPb/BF6nu8D/2OQMn0TX9fIjaHGQ=; b=dU1KnwZTTu4rG4DEP4c1gd2HopDu/VsGAysKJf8YIkPI8qaj70EEodxCnehG6NoozY 4jWQiA8h8X1S9iohvE0oZR0VdJmVsJkwg+h7OVAoaQvXmZ0PeykNqd18m5A/IFnr36jl klIdQOO+zKGtbr+behyW7Ih3HeCOabMmiiC5bACOag+QeXsHqboh+ANj52U+Ybe7TwmL pZuYQ2zEzoyl1AhMAiRSC7O8EmapmWPTul3nx+hICXG1PthRFdBNw4INjwoYO1WeKdC/ Tv5pp3dtppxXe6Oqxzv/fO1a7hcvyEPL/seAvOFFq6gK6j5/EFLhqaHLv59D0ULodBwT nLWw== X-Gm-Message-State: AOAM533CKtUW8FUGskg0ZrE32KjhcKTZeCrQjw97hIIMnksKlVtPeRCm SUut5mmtCjCC7AfTA5bfhQaU4xY0F9w2u9dSWDTc9mZfxGfAte89+AtPuUcxt4JeUuW53u+veOf BgXHOAhysw+gM2kQf8G8D73Jg X-Received: by 2002:a1c:4c19:: with SMTP id z25mr302718wmf.105.1644364764702; Tue, 08 Feb 2022 15:59:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyxrdx5PAN39E9zDPgBt3t7VCZ+YkAG7VKuS1GxY71C3wn6MOzwm1KHjgao+aMLB+p3UZbTg== X-Received: by 2002:a1c:4c19:: with SMTP id z25mr302707wmf.105.1644364764502; Tue, 08 Feb 2022 15:59:24 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id l24sm3859205wms.24.2022.02.08.15.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Feb 2022 15:59:24 -0800 (PST) Message-ID: Date: Wed, 9 Feb 2022 00:59:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 06/19] fbcon: Use delayed work for cursor Content-Language: en-US To: Daniel Vetter , DRI Development Cc: linux-fbdev@vger.kernel.org, Thomas Zimmermann , Du Cheng , Tetsuo Handa , Intel Graphics Development , LKML , Claudio Suarez , Greg Kroah-Hartman , Daniel Vetter References: <20220208210824.2238981-1-daniel.vetter@ffwll.ch> <20220208210824.2238981-7-daniel.vetter@ffwll.ch> From: Javier Martinez Canillas In-Reply-To: <20220208210824.2238981-7-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Daniel, On 2/8/22 22:08, Daniel Vetter wrote: > Allows us to delete a bunch of hand-rolled stuff. Also to simplify the > code we initialize the cursor_work completely when we allocate the > fbcon_ops structure, instead of trying to cope with console > re-initialization. > Maybe also make it more explicit in the commit message that the delayed work is replacing a timer that was used before for the cursor ? > The motiviation here is that fbcon code stops using the fb_info.queue, motivation [snip] > /* > * This is the interface between the low-level console driver and the > @@ -68,7 +68,7 @@ struct fbcon_ops { > int (*update_start)(struct fb_info *info); > int (*rotate_font)(struct fb_info *info, struct vc_data *vc); > struct fb_var_screeninfo var; /* copy of the current fb_var_screeninfo */ > - struct timer_list cursor_timer; /* Cursor timer */ > + struct delayed_work cursor_work; /* Cursor timer */ A delayed_work uses a timer underneath but I wonder if the comment also needs to be updated since technically isn't a timer anymore but deferred work that gets re-scheduled each time on fb_flashcursor(). The patch looks good to me and makes the logic much simpler than before. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DBD9C433F5 for ; Tue, 8 Feb 2022 23:59:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C655310E405; Tue, 8 Feb 2022 23:59:29 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AE9D10E405 for ; Tue, 8 Feb 2022 23:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644364767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1B+HhoEdav6Cob3bPb/BF6nu8D/2OQMn0TX9fIjaHGQ=; b=ic2wNtBUam2bz3I4ll/IUk94uFAfcHQdZaWPQd7Hg+vh4iRcpSU//sYaSmkxWOpXWX8Dqf jJ7dLcG3zHG9eU3zRy9SURbxI+vMn7Ud03/0m+klpZoeBEFWgFVh6Px2etZcYHvuf8dK01 lp69zuxLHkDb/xBdiBYGlXxCzxoJS08= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-9kru8jL3MpeA-EILUKn1iA-1; Tue, 08 Feb 2022 18:59:25 -0500 X-MC-Unique: 9kru8jL3MpeA-EILUKn1iA-1 Received: by mail-wr1-f69.google.com with SMTP id y10-20020adfc7ca000000b001e30ed3a496so293050wrg.15 for ; Tue, 08 Feb 2022 15:59:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1B+HhoEdav6Cob3bPb/BF6nu8D/2OQMn0TX9fIjaHGQ=; b=14SyUeMInY5e8Db1Ll9EO7bDtcrFpL2ER+oJ4bzc7XpDyhAxdClJfMnELQusWUZsRv TFtU6smVuwF0/F2BzLgbV1XNjLBVxD/LzZzOJUr1ohcdgio9+dnN9S6Y9zOUxK1RAChO t8Wn8KvIYesMNhhC0XZdemA6FfY9DCWj2POifKMywyg8ubIf+Y6AicGjJ4vz9wsFQa3s dfrrpJv9v/QAY7XEFLFG/FIjgQZ8Xi6laocUjLADVE33DKdEnqGITAwF7+Lt1F0e96qc BlbKPbB6gFKf10Cecm+ee6GlyZN9UkVDstgsSWvnK08Q1S34v0NkDJB0KF2eIWTaP1hP tp8Q== X-Gm-Message-State: AOAM531TzrVeNqigZjJGOyxsE/unjBT1sKGZaGd+gg569WEin344ShVn VEFgYvRDhauakr18fqAxlJzsa5HPA+38z4H/P68rV80+MEV3aQIUpx3J9b4jniqxsNiSyIRHIOG 0FPIw1DtlPZ+woCgofp6sAFI7M+oN X-Received: by 2002:a1c:4c19:: with SMTP id z25mr302715wmf.105.1644364764702; Tue, 08 Feb 2022 15:59:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyxrdx5PAN39E9zDPgBt3t7VCZ+YkAG7VKuS1GxY71C3wn6MOzwm1KHjgao+aMLB+p3UZbTg== X-Received: by 2002:a1c:4c19:: with SMTP id z25mr302707wmf.105.1644364764502; Tue, 08 Feb 2022 15:59:24 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id l24sm3859205wms.24.2022.02.08.15.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Feb 2022 15:59:24 -0800 (PST) Message-ID: Date: Wed, 9 Feb 2022 00:59:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 06/19] fbcon: Use delayed work for cursor To: Daniel Vetter , DRI Development References: <20220208210824.2238981-1-daniel.vetter@ffwll.ch> <20220208210824.2238981-7-daniel.vetter@ffwll.ch> From: Javier Martinez Canillas In-Reply-To: <20220208210824.2238981-7-daniel.vetter@ffwll.ch> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Du Cheng , Tetsuo Handa , Greg Kroah-Hartman , Intel Graphics Development , LKML , Claudio Suarez , Thomas Zimmermann , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Daniel, On 2/8/22 22:08, Daniel Vetter wrote: > Allows us to delete a bunch of hand-rolled stuff. Also to simplify the > code we initialize the cursor_work completely when we allocate the > fbcon_ops structure, instead of trying to cope with console > re-initialization. > Maybe also make it more explicit in the commit message that the delayed work is replacing a timer that was used before for the cursor ? > The motiviation here is that fbcon code stops using the fb_info.queue, motivation [snip] > /* > * This is the interface between the low-level console driver and the > @@ -68,7 +68,7 @@ struct fbcon_ops { > int (*update_start)(struct fb_info *info); > int (*rotate_font)(struct fb_info *info, struct vc_data *vc); > struct fb_var_screeninfo var; /* copy of the current fb_var_screeninfo */ > - struct timer_list cursor_timer; /* Cursor timer */ > + struct delayed_work cursor_work; /* Cursor timer */ A delayed_work uses a timer underneath but I wonder if the comment also needs to be updated since technically isn't a timer anymore but deferred work that gets re-scheduled each time on fb_flashcursor(). The patch looks good to me and makes the logic much simpler than before. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CA49C433F5 for ; Tue, 8 Feb 2022 23:59:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3583D10E190; Tue, 8 Feb 2022 23:59:31 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBC9710E42B for ; Tue, 8 Feb 2022 23:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644364769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1B+HhoEdav6Cob3bPb/BF6nu8D/2OQMn0TX9fIjaHGQ=; b=MpG1YVdKKkPEFDUJvs6mn4lY75+PRwhYzgNTZg9E+F+dkOPh0BuOiVc6IsyuRd2/rPFEjP hKzxJ50W0LNFgXPhURghc/394aKVeXcAZ/1iCZUFZEJ5OLkrC1/s8EG4+siRmOh9quq12M IaVWte4WoxtVI3kyTZ93epggKtRCMpQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-106-SvxUUnCgPYqOa1LFlDbEww-1; Tue, 08 Feb 2022 18:59:25 -0500 X-MC-Unique: SvxUUnCgPYqOa1LFlDbEww-1 Received: by mail-wr1-f70.google.com with SMTP id k20-20020adfc714000000b001e305cd1597so284545wrg.19 for ; Tue, 08 Feb 2022 15:59:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1B+HhoEdav6Cob3bPb/BF6nu8D/2OQMn0TX9fIjaHGQ=; b=5IuB5tQIezFlB+gZaJ5wXW1VnyDMVvoEv3dGXxbUgBtb0mGsnlLOw4ePVpeHC+dHHu cwEwPhcwg02RU/bM7RCRtI+G7LS2/UlC8IGEqo7Tz2VFRbJumHha5TC1obt2iW1VRgsJ rwwT7XNs1+U6gKwUcrD3w5H+4POA9w/z0yUja93c+Q3dLNY1B53oO5IBN9qHLbQAivCA /lnZ7pvVfkENVp9XF4w1+9eGPOL3Z7w9X4ibDtxFtP2LckxJkc4mRQjwIC+qzD50R2Cm PcwUL2PZKIK0k/dOGYQ9p/HzODiZtKQJ6irXKrBHcU9bUNih1z53YoRHa9uVHhPkzfwf MUlw== X-Gm-Message-State: AOAM532SsBQsrNzDAauIvH/iG8AwzQMbMp9L0qYlXWFDvPnPnoxlwJXb Q/bGRgqU66LPZQZlx95df9CtcBA3H0D0GHUkK3FydRt5ki4Ew3xEs/kGjGbRcH07VA8acEzTkC2 NN9ERvPgl2CbDNWvaheHjUIt5V3Av X-Received: by 2002:a1c:4c19:: with SMTP id z25mr302722wmf.105.1644364764703; Tue, 08 Feb 2022 15:59:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyxrdx5PAN39E9zDPgBt3t7VCZ+YkAG7VKuS1GxY71C3wn6MOzwm1KHjgao+aMLB+p3UZbTg== X-Received: by 2002:a1c:4c19:: with SMTP id z25mr302707wmf.105.1644364764502; Tue, 08 Feb 2022 15:59:24 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id l24sm3859205wms.24.2022.02.08.15.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Feb 2022 15:59:24 -0800 (PST) Message-ID: Date: Wed, 9 Feb 2022 00:59:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Daniel Vetter , DRI Development References: <20220208210824.2238981-1-daniel.vetter@ffwll.ch> <20220208210824.2238981-7-daniel.vetter@ffwll.ch> From: Javier Martinez Canillas In-Reply-To: <20220208210824.2238981-7-daniel.vetter@ffwll.ch> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2 06/19] fbcon: Use delayed work for cursor X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Du Cheng , Tetsuo Handa , Greg Kroah-Hartman , Intel Graphics Development , LKML , Thomas Zimmermann , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hello Daniel, On 2/8/22 22:08, Daniel Vetter wrote: > Allows us to delete a bunch of hand-rolled stuff. Also to simplify the > code we initialize the cursor_work completely when we allocate the > fbcon_ops structure, instead of trying to cope with console > re-initialization. > Maybe also make it more explicit in the commit message that the delayed work is replacing a timer that was used before for the cursor ? > The motiviation here is that fbcon code stops using the fb_info.queue, motivation [snip] > /* > * This is the interface between the low-level console driver and the > @@ -68,7 +68,7 @@ struct fbcon_ops { > int (*update_start)(struct fb_info *info); > int (*rotate_font)(struct fb_info *info, struct vc_data *vc); > struct fb_var_screeninfo var; /* copy of the current fb_var_screeninfo */ > - struct timer_list cursor_timer; /* Cursor timer */ > + struct delayed_work cursor_work; /* Cursor timer */ A delayed_work uses a timer underneath but I wonder if the comment also needs to be updated since technically isn't a timer anymore but deferred work that gets re-scheduled each time on fb_flashcursor(). The patch looks good to me and makes the logic much simpler than before. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat