All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@codeaurora.org>,
	Matt Redfearn <matt.redfearn@mips.com>
Cc: zajec5@gmail.com, linux-wireless@vger.kernel.org,
	linux-mips@linux-mips.org, jhogan@kernel.org
Subject: Re: [PATCH v2] bcma: Prevent build of PCI host features in module
Date: Fri, 2 Mar 2018 11:56:23 -0600	[thread overview]
Message-ID: <c5929bb5-c50f-e73e-3117-fb0a862bb0fc@lwfinger.net> (raw)
In-Reply-To: <87lgfcnkey.fsf@kamboji.qca.qualcomm.com>

On 03/01/2018 04:45 AM, Kalle Valo wrote:
> Matt Redfearn <matt.redfearn@mips.com> writes:
> 
>> Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in
>> a build error due to use of symbols not exported from vmlinux:
>>
>> ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined!
>> ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>>
>> To prevent this, don't allow the host mode feature to be built if
>> CONFIG_BCMA=m
>>
>> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
>>
>> ---
>>
>> Changes in v2:
>> Rebase on v4.16-rc1
>>
>>   drivers/bcma/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
>> index ba8acca036df..cb0f1aad20b7 100644
>> --- a/drivers/bcma/Kconfig
>> +++ b/drivers/bcma/Kconfig
>> @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI
>>   
>>   config BCMA_DRIVER_PCI_HOSTMODE
>>   	bool "Driver for PCI core working in hostmode"
>> -	depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
>> +	depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y
> 
> Due to the recent regression in bcma I would prefer extra careful review
> before I apply this. So does this look ok to everyone?

I have a preference for wireless device drivers to be modules. For that reason, 
I would have submitted a patch exporting those two missing globals rather than 
forcing bcma to be built in. That said, it seems that the patch will do no 
further harm.

Larry

  reply	other threads:[~2018-03-02 17:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01  9:58 [PATCH v2] bcma: Prevent build of PCI host features in module Matt Redfearn
2018-03-01  9:58 ` Matt Redfearn
2018-03-01 10:45 ` Kalle Valo
2018-03-01 10:45   ` Kalle Valo
2018-03-02 17:56   ` Larry Finger [this message]
2018-03-08 12:00     ` Matt Redfearn
2018-03-08 12:00       ` Matt Redfearn
2018-03-10 11:35       ` Jonas Gorski
2018-03-13 16:48 ` [v2] " Kalle Valo
2018-03-13 16:48   ` Kalle Valo
2018-03-13 16:48 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5929bb5-c50f-e73e-3117-fb0a862bb0fc@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=jhogan@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=matt.redfearn@mips.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.