From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D4E2C4332F for ; Mon, 12 Dec 2022 08:57:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbiLLI5C (ORCPT ); Mon, 12 Dec 2022 03:57:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231419AbiLLI4w (ORCPT ); Mon, 12 Dec 2022 03:56:52 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB636C09 for ; Mon, 12 Dec 2022 00:56:49 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id y25so17400255lfa.9 for ; Mon, 12 Dec 2022 00:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3QdvuUyS+6CWEm93IiNhP+hlhAXaHYJrxB4vuciAs1s=; b=GR01tUm7ffyceoIwnCnYkv1qFr/OOJetI0ZTc8QVmvp+qLB8Dhm2cfnO0Uv63Bm+J2 KI9SBFqezS4Uo9/JLqoBtHLiadnZIiutz0S+0zQNqsqLxUJqOjlLUSETkN//C0FtnMVJ lF+P8himJ6dWzQLHIHXizTqEfcGF4lQH4LW0TkdN/splysgemCJPrlWpzWwUwGsj4GTq /SoGiBkOu5SStPXI73/vi9/eUbPTFdN7em0/BiVZbqbQmrYPpMQ5iwHD4Ot5odEYzxcP ldz1a0W64oh9cioYJ/X1BxbOe8zqyiOvUEw5jWrNKuvYdjxsetl1I5RE3PSheZCK9diI YV1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3QdvuUyS+6CWEm93IiNhP+hlhAXaHYJrxB4vuciAs1s=; b=02LhD9Q5cBabP8wQavo6H/WCvGLdLVCYzam/SaKelZoGfqKIwp5FO0EGwLjGYYiu4B GU4HWfdQNA8ucZ3R45FUJIpFRMejkM9wwxRYDK1iFyag9FlFVDuLbAEWzQ8nItgbdZFH Uh2BR4hZIgDtyKmRDMcAA5+zTE7g0bj+8xWpYoJnfVJbkZwg8g8XzyAiofDvWlC/Ry3Q fBrAH1UibLlCcR/vCewRZbVWE08hGzplpvCi5wrJOd7CULDowb6TQiiSf0dNVGcak61g AXknjCpQ/vswBRDPvNhsVg9XjT/e2kYQYV3rz21MdGvY0Dx4SYUFNHIPsCk56n9dGQEb Hbjg== X-Gm-Message-State: ANoB5pmUx5xWd/UVdwCbI4kSzbs39DsnataJFvdA7Y+19eG3w2C4s+9D 6riO7lD2re0/aV8eNCdMNwvTyA== X-Google-Smtp-Source: AA0mqf4KMzDBXw3GpK3cmEv0n839Lx+uhrj/I437niP4N28oe3+cSmv2GHnbgFFIprLLCYmPQ4IRyQ== X-Received: by 2002:a05:6512:15a6:b0:4b4:b5bf:3ce6 with SMTP id bp38-20020a05651215a600b004b4b5bf3ce6mr7288585lfb.38.1670835408063; Mon, 12 Dec 2022 00:56:48 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id cf31-20020a056512281f00b0049465afdd38sm1563922lfb.108.2022.12.12.00.56.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 00:56:47 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 09:56:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v4 2/3] dt-bindings: leds: add worldsemi,ws2812b Content-Language: en-US To: Chuanhong Guo , linux-leds@vger.kernel.org, Pavel Machek , Lee Jones Cc: Rob Herring , Krzysztof Kozlowski , Stanislav Jakubek , Linus Walleij , Shawn Guo , Johan Hovold , Bjorn Andersson , Marijn Suijten , Sven Schwermer , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20221212045558.69602-1-gch981213@gmail.com> <20221212045558.69602-3-gch981213@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221212045558.69602-3-gch981213@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 12/12/2022 05:55, Chuanhong Guo wrote: > Add dt binding schema for WorldSemi WS2812B driven using SPI > bus. > > Signed-off-by: Chuanhong Guo > --- > Changes since v1: > remove linux driver reference from description > remove some obvious descriptions > fix unit address regex in multi-led property > drop various minItems > add maxItems = 1 to reg > fix node names and property orders in binding example > drop -spi from compatible string > add default-brightness > > Change since v2: > drop "this patch" from commit message > rename leds to led-controller > drop default-brightness and default-intensity > > Change since v3: > reword commit title > > .../bindings/leds/worldsemi,ws2812b.yaml | 116 ++++++++++++++++++ > 1 file changed, 116 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > > diff --git a/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml b/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > new file mode 100644 > index 000000000000..548c05ac3d31 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/worldsemi,ws2812b.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: WS2812B LEDs driven using SPI > + > +maintainers: > + - Chuanhong Guo > + > +description: | > + WorldSemi WS2812B is a individually addressable LED chip that can be chained > + together and controlled individually using a single wire. > + This binding describes a chain of WS2812B LEDs connected to the SPI MOSI pin. > + Typical setups includes connecting the data pin of the LED chain to MOSI as > + the only device or using CS and MOSI with a tri-state voltage-level shifter > + for the data pin. > + The SPI frequency needs to be 2.105MHz~2.85MHz for the timing to be correct > + and the controller needs to send all the bytes continuously. > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + const: worldsemi,ws2812b > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + minimum: 2105000 > + maximum: 2850000 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-9a-f]+$": > + type: object > + $ref: leds-class-multicolor.yaml# > + unevaluatedProperties: false > + > + properties: > + color-index: > + description: | > + A 3-item array specifying color of each components in this LED. It > + should be one of the LED_COLOR_ID_* prefixed definitions from the > + header include/dt-bindings/leds/common.h. Defaults to > + > + if unspecified. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 3 In general I am fine with it, although there is still question for adding more multi-color defines in binding headers to replace this property - GRB/RBG/GBR and even more for RGBW. Pavel, Lee, any thoughts from your side? Best regards, Krzysztof