From: Darren Hart <dvhart@linux.intel.com>
To: poky@yoctoproject.org
Cc: Darren Hart <dvhart@linux.intel.com>
Subject: [PATCH 3/3] fetch2/git: use logging.debug() and clarify messages
Date: Fri, 20 May 2011 16:06:14 -0700 [thread overview]
Message-ID: <c5a21058376ecc4039a67de6a8ffe2a06b9844dd.1305932581.git.dvhart@linux.intel.com> (raw)
In-Reply-To: <cover.1305932581.git.dvhart@linux.intel.com>
From: Darren Hart <dvhart@linux.intel.com>
Replace a call to print() with logging.debug() and flesh out the
message to clarify the state being reported.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: Yu Ke <ke.yu@intel.com>
---
bitbake/lib/bb/fetch2/git.py | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index 7ffaa5e..c14346b 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -241,10 +241,13 @@ class Git(FetchMethod):
# Check if we have the rev already
if not os.path.exists(ud.clonedir):
- print("no repo")
+ logging.debug("GIT repository for %s does not exist in %s. \
+ Downloading.", url, ud.clonedir)
self.download(None, ud, d)
if not os.path.exists(ud.clonedir):
- logger.error("GIT repository for %s doesn't exist in %s, cannot get sortable buildnumber, using old value", url, ud.clonedir)
+ logger.error("GIT repository for %s does not exist in %s after \
+ download. Cannot get sortable buildnumber, using \
+ old value", url, ud.clonedir)
return None
--
1.7.1
next prev parent reply other threads:[~2011-05-20 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 23:06 [PATCH 0/3] fetch2/git: debug updates and minor cleanup Darren Hart
2011-05-20 23:06 ` [PATCH 1/3] fetch2/git: ensure network check log matches actual command Darren Hart
2011-05-20 23:06 ` [PATCH 2/3] fetch2/git: use urldata basecmd when available Darren Hart
2011-05-20 23:06 ` Darren Hart [this message]
2011-05-27 17:18 ` [PATCH 0/3] fetch2/git: debug updates and minor cleanup Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a21058376ecc4039a67de6a8ffe2a06b9844dd.1305932581.git.dvhart@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.