From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B108AC433F5 for ; Fri, 17 Sep 2021 17:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9405C611C4 for ; Fri, 17 Sep 2021 17:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233746AbhIQRJg (ORCPT ); Fri, 17 Sep 2021 13:09:36 -0400 Received: from mga17.intel.com ([192.55.52.151]:11747 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231138AbhIQRJg (ORCPT ); Fri, 17 Sep 2021 13:09:36 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10110"; a="202995585" X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="202995585" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 10:08:13 -0700 X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="530917609" Received: from labooth-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.212.119.226]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 10:08:13 -0700 Subject: Re: [PATCH v7 1/1] x86/acpi, x86/boot: Add multiprocessor wake-up support From: "Kuppuswamy, Sathyanarayanan" To: Thomas Gleixner , Ingo Molnar , Rafael J Wysocki , H Peter Anvin , Peter Zijlstra Cc: Len Brown , Kuppuswamy Sathyanarayanan , Sean Christopherson , Andi Kleen , x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Sean Christopherson , "Rafael J . Wysocki" References: <20210720042506.2123009-1-sathyanarayanan.kuppuswamy@linux.intel.com> Message-ID: Date: Fri, 17 Sep 2021 10:08:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi x86 Maintainers, On 8/17/21 6:55 AM, Kuppuswamy, Sathyanarayanan wrote: > Hi, > > On 7/19/21 9:25 PM, Kuppuswamy Sathyanarayanan wrote: >> As per ACPI specification r6.4, sec 5.2.12.19, a new sub >> structure – multiprocessor wake-up structure - is added to the >> ACPI Multiple APIC Description Table (MADT) to describe the >> information of the mailbox. If a platform firmware produces the >> multiprocessor wake-up structure, then OS may use this new >> mailbox-based mechanism to wake up the APs. >> >> Add ACPI MADT wake table parsing support for x86 platform and if >> MADT wake table is present, update apic->wakeup_secondary_cpu with >> new API which uses MADT wake mailbox to wake-up CPU. >> >> Co-developed-by: Sean Christopherson >> Signed-off-by: Sean Christopherson >> Reviewed-by: Andi Kleen >> Reviewed-by: Rafael J. Wysocki >> Signed-off-by: Kuppuswamy Sathyanarayanan >> --- >> >> Changes since v6: >>   * Rebased on top of v5.14-rc1. >> >> Changes since v5: >>   * None ( CCed ACPI list) >> >> Changes since v4: >>   * Used smp_store_release() in place of WRITE_ONCE(). >>   * Addressed some checkpatch warnings. >> >> Changes since v3: >>   * Removed acpi_mp_wake_mailbox_init() and moved init code to >>     acpi_wakeup_cpu(). >>   * Removed redundant NULL pointer check for acpi_mp_wake_mailbox. >>   * Added comments/debug prints as per Rafael's suggestion. >>   * Removed MADT/SVKL ACPI patches from this patchset. It will be >>     merged via ACPICA submission. > > > Gentle ping! Any comments on this patch? I think I have addressed all the comments raised by the reviewers. So, Can you please consider queuing this patch for next merge window ? > -- Sathyanarayanan Kuppuswamy Linux Kernel Developer