From: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Dragos.Bogdan@analog.com, Darius.Berghe@analog.com,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Guenter Roeck <linux@roeck-us.net>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: potentiometer: Add driver support for AD5110
Date: Sat, 7 Aug 2021 22:58:44 +0530 [thread overview]
Message-ID: <c5b787e6-8022-ff53-bd78-4e57b80485f2@gmail.com> (raw)
In-Reply-To: <9de74da9-14b6-1533-e394-c7c8b056bce2@metafoo.de>
On 07/08/21 5:47 pm, Lars-Peter Clausen wrote:
> On 8/7/21 7:08 AM, Mugilraj Dhavachelvan wrote:
>> +static const struct iio_chan_spec ad5110_channels[] = {
>> + {
>> + .type = IIO_RESISTANCE,
>> + .output = 1,
>> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_OFFSET),
>> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
>> + BIT(IIO_CHAN_INFO_ENABLE),
> There is only on channel in this device. Why are some `separate` and others `shared_by_type`?
>
No special reason, I'll put everything into 'separate'. Fixed in v2.
>
prev parent reply other threads:[~2021-08-07 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 5:08 [PATCH 0/2] iio: potentiometer: Add driver support for AD5110 Mugilraj Dhavachelvan
2021-08-07 5:08 ` [PATCH 1/2] dt-bindings: iio: potentiometer: Add AD5110 in trivial-devices Mugilraj Dhavachelvan
2021-08-07 5:08 ` [PATCH 2/2] iio: potentiometer: Add driver support for AD5110 Mugilraj Dhavachelvan
2021-08-07 12:11 ` Lars-Peter Clausen
2021-08-07 17:26 ` Mugilraj Dhavachelvan
2021-08-07 17:34 ` Mugilraj Dhavachelvan
2021-08-08 16:22 ` Jonathan Cameron
2021-08-07 12:17 ` Lars-Peter Clausen
2021-08-07 17:28 ` Mugilraj Dhavachelvan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5b787e6-8022-ff53-bd78-4e57b80485f2@gmail.com \
--to=dmugil2000@gmail.com \
--cc=Darius.Berghe@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.