From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 985F3C433EF for ; Sun, 2 Jan 2022 13:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231562AbiABNIg (ORCPT ); Sun, 2 Jan 2022 08:08:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbiABNIf (ORCPT ); Sun, 2 Jan 2022 08:08:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3F6BC061761; Sun, 2 Jan 2022 05:08:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 42F95B80D65; Sun, 2 Jan 2022 13:08:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F28C36AEE; Sun, 2 Jan 2022 13:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641128911; bh=d8wVlK4N5UUP87/zUGPNwB99lAdpUwHDMgwI0siLGPE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KJCPAILY6bad6cOf2efNIjBQR3Rc2NI6zZhhEPRzw3fuVHslukGuXRWw2s7YuGa4x ZnfmV+LTm7XBziASBRSljiIVSwLRUhADT0W3rgVs8Tyu2jZpMdh4ywYI29I+yf9c53 8iB4YsEJHMcxDQhB5kGBJZFs9QLb2GDIZ3U12dPEV7pnPfm0l8LZeFXo6XscQU83eN l8ik2/1+DpIp9vuPXp83aB+0OSFGcHCI74W774vlxbdUhN1TwZYIQAWt7/DiLhqKbu 6wBuUHovd2bAE0SXioHn+gmfQ00ELYlJGs9t4YXOZYGBVV75OIt+Td05ci+W0/6r96 nieE1JmM80MCA== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n40b7-00FUYE-AT; Sun, 02 Jan 2022 13:08:29 +0000 MIME-Version: 1.0 Date: Sun, 02 Jan 2022 13:08:28 +0000 From: Marc Zyngier To: Vladimir Oltean , Rob Herring , Shawn Guo Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Leo Li , Biwen Li , "Z.Q. Hou" , Kurt Kanzenbach , Rasmus Villemoes Subject: Re: [PATCH v2 devicetree] Revert "arm64: dts: freescale: Fix 'interrupt-map' parent address cells" In-Reply-To: <20211231181350.qwfnrwvdfnfssdjt@skbuf> References: <20211214135852.2934670-1-vladimir.oltean@nxp.com> <20211231181350.qwfnrwvdfnfssdjt@skbuf> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: vladimir.oltean@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, leoyang.li@nxp.com, biwen.li@nxp.com, zhiqiang.hou@nxp.com, kurt@linutronix.de, linux@rasmusvillemoes.dk X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-12-31 18:13, Vladimir Oltean wrote: > Hello, > > On Tue, Dec 14, 2021 at 03:58:52PM +0200, Vladimir Oltean wrote: >> This reverts commit 869f0ec048dc8fd88c0b2003373bd985795179fb. That >> updated the expected device tree binding format for the ls-extirq >> driver, without also updating the parsing code (ls_extirq_parse_map) >> to the new format. >> >> The context is that the ls-extirq driver uses the standard >> "interrupt-map" OF property in a non-standard way, as suggested by >> Rob Herring during review: >> https://lore.kernel.org/lkml/20190927161118.GA19333@bogus/ >> >> This has turned out to be problematic, as Marc Zyngier discovered >> through commit 041284181226 ("of/irq: Allow matching of an >> interrupt-map >> local to an interrupt controller"), later fixed through commit >> de4adddcbcc2 ("of/irq: Add a quirk for controllers with their own >> definition of interrupt-map"). Marc's position, expressed on multiple >> opportunities, is that: >> >> (a) [ making private use of the reserved "interrupt-map" name in a >> driver ] "is wrong, by the very letter of what an interrupt-map >> means. If the interrupt map points to an interrupt controller, >> that's the target for the interrupt." >> https://lore.kernel.org/lkml/87k0g8jlmg.wl-maz@kernel.org/ >> >> (b) [ updating the driver's bindings to accept a non-reserved name for >> this property, as an alternative, is ] "is totally pointless. >> These >> machines have been in the wild for years, and existing DTs will be >> there *forever*." >> https://lore.kernel.org/lkml/87ilvrk1r0.wl-maz@kernel.org/ >> >> Considering the above, the Linux kernel has quirks in place to deal >> with >> the ls-extirq's non-standard use of the "interrupt-map". These quirks >> may be needed in other operating systems that consume this device >> tree, >> yet this is seen as the only viable solution. >> >> Therefore, the premise of the patch being reverted here is invalid. >> It doesn't matter whether the driver, in its non-standard use of the >> property, complies to the standard format or not, since this property >> isn't expected to be used for interrupt translation by the core. >> >> This change restores LS1088A, LS2088A/LS2085A and LX2160A to their >> previous bindings, which allows these systems to continue to use >> external interrupt lines with the correct polarity. >> >> Fixes: 869f0ec048dc ("arm64: dts: freescale: Fix 'interrupt-map' >> parent address cells") >> Signed-off-by: Vladimir Oltean >> --- >> v1->v2: remove the other 9 patches that rename "interrupt-map" to >> "fsl,extirq-map", at Marc's suggestion. > > Could this patch be considered for merging in v5.16? The problem is > going to be quite a bit more severe and tricky to fix otherwise. > Thanks. FWIW: Acked-by: Marc Zyngier Rob, Shawn, can you please queue this as an urgent fix for 5.16? Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA35DC433F5 for ; Sun, 2 Jan 2022 13:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/x1LER9aoBcxKWb0lBfsjcEsNt0Qf6UX2e+iMLeXZ4w=; b=DQ/V3Az0131WFBMdkPNbeaHSNW 7rCXWM7TFSjEhcnahEzqpKEkhiH5rIa9S1UljCwNnf+lk+tvQiNT1mvWM3svj0B2XwrHkLABgSFi9 EjA7+cfGFlyju+rVCKjkC08OL//ojxf4D2sW06BxsVjndCWjzUIqaDizWHsyNab1FaNMIpDN+Lsvb CMfi9pBsD843VomNQSBZ/ZZrvmPHTREQDP/zDKTvzPkgB9dAEdFi1R/dqVrGJNSwWqgWdzumaaZKs edCz/O1uJLsih3ky5qwNVPpfdJiqIYDciVT4GACDwuNQEJWbExqZvWml8lye1hWYQNIBaSaS9QbJI 7uQq19OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n40bH-007oZ6-6L; Sun, 02 Jan 2022 13:08:39 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n40bD-007oYL-UU for linux-arm-kernel@lists.infradead.org; Sun, 02 Jan 2022 13:08:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C0F6B80D67; Sun, 2 Jan 2022 13:08:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F28C36AEE; Sun, 2 Jan 2022 13:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641128911; bh=d8wVlK4N5UUP87/zUGPNwB99lAdpUwHDMgwI0siLGPE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KJCPAILY6bad6cOf2efNIjBQR3Rc2NI6zZhhEPRzw3fuVHslukGuXRWw2s7YuGa4x ZnfmV+LTm7XBziASBRSljiIVSwLRUhADT0W3rgVs8Tyu2jZpMdh4ywYI29I+yf9c53 8iB4YsEJHMcxDQhB5kGBJZFs9QLb2GDIZ3U12dPEV7pnPfm0l8LZeFXo6XscQU83eN l8ik2/1+DpIp9vuPXp83aB+0OSFGcHCI74W774vlxbdUhN1TwZYIQAWt7/DiLhqKbu 6wBuUHovd2bAE0SXioHn+gmfQ00ELYlJGs9t4YXOZYGBVV75OIt+Td05ci+W0/6r96 nieE1JmM80MCA== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n40b7-00FUYE-AT; Sun, 02 Jan 2022 13:08:29 +0000 MIME-Version: 1.0 Date: Sun, 02 Jan 2022 13:08:28 +0000 From: Marc Zyngier To: Vladimir Oltean , Rob Herring , Shawn Guo Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Leo Li , Biwen Li , "Z.Q. Hou" , Kurt Kanzenbach , Rasmus Villemoes Subject: Re: [PATCH v2 devicetree] Revert "arm64: dts: freescale: Fix 'interrupt-map' parent address cells" In-Reply-To: <20211231181350.qwfnrwvdfnfssdjt@skbuf> References: <20211214135852.2934670-1-vladimir.oltean@nxp.com> <20211231181350.qwfnrwvdfnfssdjt@skbuf> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: vladimir.oltean@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, leoyang.li@nxp.com, biwen.li@nxp.com, zhiqiang.hou@nxp.com, kurt@linutronix.de, linux@rasmusvillemoes.dk X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220102_050836_321700_B787A908 X-CRM114-Status: GOOD ( 23.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-12-31 18:13, Vladimir Oltean wrote: > Hello, > > On Tue, Dec 14, 2021 at 03:58:52PM +0200, Vladimir Oltean wrote: >> This reverts commit 869f0ec048dc8fd88c0b2003373bd985795179fb. That >> updated the expected device tree binding format for the ls-extirq >> driver, without also updating the parsing code (ls_extirq_parse_map) >> to the new format. >> >> The context is that the ls-extirq driver uses the standard >> "interrupt-map" OF property in a non-standard way, as suggested by >> Rob Herring during review: >> https://lore.kernel.org/lkml/20190927161118.GA19333@bogus/ >> >> This has turned out to be problematic, as Marc Zyngier discovered >> through commit 041284181226 ("of/irq: Allow matching of an >> interrupt-map >> local to an interrupt controller"), later fixed through commit >> de4adddcbcc2 ("of/irq: Add a quirk for controllers with their own >> definition of interrupt-map"). Marc's position, expressed on multiple >> opportunities, is that: >> >> (a) [ making private use of the reserved "interrupt-map" name in a >> driver ] "is wrong, by the very letter of what an interrupt-map >> means. If the interrupt map points to an interrupt controller, >> that's the target for the interrupt." >> https://lore.kernel.org/lkml/87k0g8jlmg.wl-maz@kernel.org/ >> >> (b) [ updating the driver's bindings to accept a non-reserved name for >> this property, as an alternative, is ] "is totally pointless. >> These >> machines have been in the wild for years, and existing DTs will be >> there *forever*." >> https://lore.kernel.org/lkml/87ilvrk1r0.wl-maz@kernel.org/ >> >> Considering the above, the Linux kernel has quirks in place to deal >> with >> the ls-extirq's non-standard use of the "interrupt-map". These quirks >> may be needed in other operating systems that consume this device >> tree, >> yet this is seen as the only viable solution. >> >> Therefore, the premise of the patch being reverted here is invalid. >> It doesn't matter whether the driver, in its non-standard use of the >> property, complies to the standard format or not, since this property >> isn't expected to be used for interrupt translation by the core. >> >> This change restores LS1088A, LS2088A/LS2085A and LX2160A to their >> previous bindings, which allows these systems to continue to use >> external interrupt lines with the correct polarity. >> >> Fixes: 869f0ec048dc ("arm64: dts: freescale: Fix 'interrupt-map' >> parent address cells") >> Signed-off-by: Vladimir Oltean >> --- >> v1->v2: remove the other 9 patches that rename "interrupt-map" to >> "fsl,extirq-map", at Marc's suggestion. > > Could this patch be considered for merging in v5.16? The problem is > going to be quite a bit more severe and tricky to fix otherwise. > Thanks. FWIW: Acked-by: Marc Zyngier Rob, Shawn, can you please queue this as an urgent fix for 5.16? Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel