From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTYvl-0008UE-Op for qemu-devel@nongnu.org; Thu, 14 Jun 2018 16:33:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTYvl-0008DU-1n for qemu-devel@nongnu.org; Thu, 14 Jun 2018 16:33:17 -0400 Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= References: <20180614164431.29305-1-stefanha@redhat.com> <5768e8f3-eae5-30ef-888a-5e62692c238d@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 14 Jun 2018 17:33:04 -0300 MIME-Version: 1.0 In-Reply-To: <5768e8f3-eae5-30ef-888a-5e62692c238d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] compiler: add a sizeof_field() macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org On 06/14/2018 04:17 PM, John Snow wrote: > On 06/14/2018 12:44 PM, Stefan Hajnoczi wrote: >> Determining the size of a field is useful when you don't have a struct >> variable handy. Open-coding this is ugly. >> >> This patch adds the sizeof_field() macro, which is similar to >> typeof_field(). Existing instances are updated to use the macro. >> >> Signed-off-by: Stefan Hajnoczi > > How'd you find all the existing instances? This works: $ git grep -E 'sizeof.*)0)->' > > Reviewed-by: John Snow > >> --- >> include/hw/xen/io/ring.h | 2 +- >> include/qemu/compiler.h | 2 ++ >> accel/tcg/translate-all.c | 2 +- >> hw/display/xenfb.c | 4 ++-- >> hw/net/rocker/rocker_of_dpa.c | 2 +- >> hw/net/virtio-net.c | 2 +- >> target/i386/kvm.c | 2 +- >> target/ppc/arch_dump.c | 10 +++++----- >> target/s390x/arch_dump.c | 20 ++++++++++---------- >> 9 files changed, 24 insertions(+), 22 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Subject: Re: [Qemu-devel] [PATCH] compiler: add a sizeof_field() macro Date: Thu, 14 Jun 2018 17:33:04 -0300 Message-ID: References: <20180614164431.29305-1-stefanha@redhat.com> <5768e8f3-eae5-30ef-888a-5e62692c238d@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fTYvf-0006jB-LL for xen-devel@lists.xenproject.org; Thu, 14 Jun 2018 20:33:11 +0000 Received: by mail-qt0-x243.google.com with SMTP id h5-v6so7098197qtm.13 for ; Thu, 14 Jun 2018 13:33:10 -0700 (PDT) In-Reply-To: <5768e8f3-eae5-30ef-888a-5e62692c238d@redhat.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: John Snow Cc: xen-devel@lists.xenproject.org, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi List-Id: xen-devel@lists.xenproject.org T24gMDYvMTQvMjAxOCAwNDoxNyBQTSwgSm9obiBTbm93IHdyb3RlOgo+IE9uIDA2LzE0LzIwMTgg MTI6NDQgUE0sIFN0ZWZhbiBIYWpub2N6aSB3cm90ZToKPj4gRGV0ZXJtaW5pbmcgdGhlIHNpemUg b2YgYSBmaWVsZCBpcyB1c2VmdWwgd2hlbiB5b3UgZG9uJ3QgaGF2ZSBhIHN0cnVjdAo+PiB2YXJp YWJsZSBoYW5keS4gIE9wZW4tY29kaW5nIHRoaXMgaXMgdWdseS4KPj4KPj4gVGhpcyBwYXRjaCBh ZGRzIHRoZSBzaXplb2ZfZmllbGQoKSBtYWNybywgd2hpY2ggaXMgc2ltaWxhciB0bwo+PiB0eXBl b2ZfZmllbGQoKS4gIEV4aXN0aW5nIGluc3RhbmNlcyBhcmUgdXBkYXRlZCB0byB1c2UgdGhlIG1h Y3JvLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBTdGVmYW4gSGFqbm9jemkgPHN0ZWZhbmhhQHJlZGhh dC5jb20+Cj4gCj4gSG93J2QgeW91IGZpbmQgYWxsIHRoZSBleGlzdGluZyBpbnN0YW5jZXM/CgpU aGlzIHdvcmtzOgoKJCBnaXQgZ3JlcCAtRSAnc2l6ZW9mLiopMCktPicKCj4gCj4gUmV2aWV3ZWQt Ynk6IEpvaG4gU25vdyA8anNub3dAcmVkaGF0LmNvbT4KPiAKPj4gLS0tCj4+ICBpbmNsdWRlL2h3 L3hlbi9pby9yaW5nLmggICAgICB8ICAyICstCj4+ICBpbmNsdWRlL3FlbXUvY29tcGlsZXIuaCAg ICAgICB8ICAyICsrCj4+ICBhY2NlbC90Y2cvdHJhbnNsYXRlLWFsbC5jICAgICB8ICAyICstCj4+ ICBody9kaXNwbGF5L3hlbmZiLmMgICAgICAgICAgICB8ICA0ICsrLS0KPj4gIGh3L25ldC9yb2Nr ZXIvcm9ja2VyX29mX2RwYS5jIHwgIDIgKy0KPj4gIGh3L25ldC92aXJ0aW8tbmV0LmMgICAgICAg ICAgIHwgIDIgKy0KPj4gIHRhcmdldC9pMzg2L2t2bS5jICAgICAgICAgICAgIHwgIDIgKy0KPj4g IHRhcmdldC9wcGMvYXJjaF9kdW1wLmMgICAgICAgIHwgMTAgKysrKystLS0tLQo+PiAgdGFyZ2V0 L3MzOTB4L2FyY2hfZHVtcC5jICAgICAgfCAyMCArKysrKysrKysrLS0tLS0tLS0tLQo+PiAgOSBm aWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=