* [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool
@ 2017-06-13 4:23 ` Keerthy
2017-06-13 4:23 ` [U-Boot] [PATCH 01/12] " Keerthy
` (13 more replies)
0 siblings, 14 replies; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
Change get_enable return type to int so errors can be returned.
The series converts the return type of get_enable hook in the
dm_regulator_ops to integer from bool. This enables it to
return any error values if any.
Compile tested.
Keerthy (12):
regulator: Change get_enable return type to integer from bool
power: regulator: fixed: get_enable should return integer
power: regulator: act8846: get_enable should return integer
power: regulator: max77686: get_enable should return integer
power: regulator: palmas: get_enable should return integer
power: regulator: pfuze100: get_enable should return integer
power: regulator: tps65090: get_enable should return integer
power: regulator: rk8xx: get_enable should return integer
power: sandbox: fixed: get_enable should return integer
power: regulator: s5m8767: get_enable should return integer
power: regulator: lp873x: get_enable should return integer
power: regulator: lp87565: get_enable should return integer
drivers/power/regulator/act8846.c | 2 +-
drivers/power/regulator/fixed.c | 2 +-
drivers/power/regulator/lp873x_regulator.c | 4 ++--
drivers/power/regulator/lp87565_regulator.c | 2 +-
drivers/power/regulator/max77686.c | 4 ++--
drivers/power/regulator/palmas_regulator.c | 4 ++--
drivers/power/regulator/pfuze100.c | 2 +-
drivers/power/regulator/regulator-uclass.c | 2 +-
drivers/power/regulator/rk8xx.c | 6 +++---
drivers/power/regulator/s5m8767.c | 4 ++--
drivers/power/regulator/sandbox.c | 4 ++--
drivers/power/regulator/tps65090_regulator.c | 2 +-
include/power/regulator.h | 8 ++++----
13 files changed, 23 insertions(+), 23 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 01/12] regulator: Change get_enable return type to integer from bool
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer Keerthy
` (12 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
Change get_enable return type to int so errors can be returned.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/regulator-uclass.c | 2 +-
include/power/regulator.h | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c
index 0a1d1b3..426a933 100644
--- a/drivers/power/regulator/regulator-uclass.c
+++ b/drivers/power/regulator/regulator-uclass.c
@@ -96,7 +96,7 @@ int regulator_set_current(struct udevice *dev, int uA)
return ops->set_current(dev, uA);
}
-bool regulator_get_enable(struct udevice *dev)
+int regulator_get_enable(struct udevice *dev)
{
const struct dm_regulator_ops *ops = dev_get_driver_ops(dev);
diff --git a/include/power/regulator.h b/include/power/regulator.h
index 1a8e575..2bbc1e5 100644
--- a/include/power/regulator.h
+++ b/include/power/regulator.h
@@ -211,9 +211,9 @@ struct dm_regulator_ops {
* @dev - regulator device
* Sets:
* @enable - set true - enable or false - disable
- * @return true/false for get; or 0 / -errno for set.
+ * @return true/false for get or -errno if fail; 0 / -errno for set.
*/
- bool (*get_enable)(struct udevice *dev);
+ int (*get_enable)(struct udevice *dev);
int (*set_enable)(struct udevice *dev, bool enable);
/**
@@ -291,9 +291,9 @@ int regulator_set_current(struct udevice *dev, int uA);
* regulator_get_enable: get regulator device enable state.
*
* @dev - pointer to the regulator device
- * @return - true/false of enable state
+ * @return - true/false of enable state or -errno val if fails
*/
-bool regulator_get_enable(struct udevice *dev);
+int regulator_get_enable(struct udevice *dev);
/**
* regulator_set_enable: set regulator enable state
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
2017-06-13 4:23 ` [U-Boot] [PATCH 01/12] " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 03/12] power: regulator: act8846: " Keerthy
` (11 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/fixed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/fixed.c b/drivers/power/regulator/fixed.c
index 656371b..35c2922 100644
--- a/drivers/power/regulator/fixed.c
+++ b/drivers/power/regulator/fixed.c
@@ -89,7 +89,7 @@ static int fixed_regulator_get_current(struct udevice *dev)
return uc_pdata->min_uA;
}
-static bool fixed_regulator_get_enable(struct udevice *dev)
+static int fixed_regulator_get_enable(struct udevice *dev)
{
struct fixed_regulator_platdata *dev_pdata = dev_get_platdata(dev);
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 03/12] power: regulator: act8846: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
2017-06-13 4:23 ` [U-Boot] [PATCH 01/12] " Keerthy
2017-06-13 4:23 ` [U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 04/12] power: regulator: max77686: " Keerthy
` (10 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/act8846.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/act8846.c b/drivers/power/regulator/act8846.c
index d506165..7d86aae 100644
--- a/drivers/power/regulator/act8846.c
+++ b/drivers/power/regulator/act8846.c
@@ -115,7 +115,7 @@ static int reg_set_enable(struct udevice *dev, bool enable)
enable ? LDO_EN_MASK : 0);
}
-static bool reg_get_enable(struct udevice *dev)
+static int reg_get_enable(struct udevice *dev)
{
int reg = dev->driver_data;
int ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 04/12] power: regulator: max77686: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (2 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 03/12] power: regulator: act8846: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 05/12] power: regulator: palmas: " Keerthy
` (9 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/max77686.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.c
index 5e5815f..8780806 100644
--- a/drivers/power/regulator/max77686.c
+++ b/drivers/power/regulator/max77686.c
@@ -688,7 +688,7 @@ static int ldo_set_value(struct udevice *dev, int uV)
return max77686_ldo_val(dev, PMIC_OP_SET, &uV);
}
-static bool ldo_get_enable(struct udevice *dev)
+static int ldo_get_enable(struct udevice *dev)
{
bool enable = false;
int ret;
@@ -752,7 +752,7 @@ static int buck_set_value(struct udevice *dev, int uV)
return max77686_buck_val(dev, PMIC_OP_SET, &uV);
}
-static bool buck_get_enable(struct udevice *dev)
+static int buck_get_enable(struct udevice *dev)
{
bool enable = false;
int ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 05/12] power: regulator: palmas: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (3 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 04/12] power: regulator: max77686: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 06/12] power: regulator: pfuze100: " Keerthy
` (8 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/palmas_regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/regulator/palmas_regulator.c b/drivers/power/regulator/palmas_regulator.c
index 841c03a..99614b0 100644
--- a/drivers/power/regulator/palmas_regulator.c
+++ b/drivers/power/regulator/palmas_regulator.c
@@ -304,7 +304,7 @@ static int ldo_set_value(struct udevice *dev, int uV)
return palmas_ldo_val(dev, PMIC_OP_SET, &uV);
}
-static bool ldo_get_enable(struct udevice *dev)
+static int ldo_get_enable(struct udevice *dev)
{
bool enable = false;
int ret;
@@ -411,7 +411,7 @@ static int smps_set_value(struct udevice *dev, int uV)
return palmas_smps_val(dev, PMIC_OP_SET, &uV);
}
-static bool smps_get_enable(struct udevice *dev)
+static int smps_get_enable(struct udevice *dev)
{
bool enable = false;
int ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 06/12] power: regulator: pfuze100: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (4 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 05/12] power: regulator: palmas: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 07/12] power: regulator: tps65090: " Keerthy
` (7 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/pfuze100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/pfuze100.c b/drivers/power/regulator/pfuze100.c
index 4702161..3edc2aa 100644
--- a/drivers/power/regulator/pfuze100.c
+++ b/drivers/power/regulator/pfuze100.c
@@ -516,7 +516,7 @@ static int pfuze100_regulator_set_value(struct udevice *dev, int uV)
return pfuze100_regulator_val(dev, PMIC_OP_SET, &uV);
}
-static bool pfuze100_regulator_get_enable(struct udevice *dev)
+static int pfuze100_regulator_get_enable(struct udevice *dev)
{
int ret;
bool enable = false;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 07/12] power: regulator: tps65090: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (5 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 06/12] power: regulator: pfuze100: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 08/12] power: regulator: rk8xx: " Keerthy
` (6 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/tps65090_regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/tps65090_regulator.c b/drivers/power/regulator/tps65090_regulator.c
index affc504..32aeab9 100644
--- a/drivers/power/regulator/tps65090_regulator.c
+++ b/drivers/power/regulator/tps65090_regulator.c
@@ -23,7 +23,7 @@ static int tps65090_fet_probe(struct udevice *dev)
return 0;
}
-static bool tps65090_fet_get_enable(struct udevice *dev)
+static int tps65090_fet_get_enable(struct udevice *dev)
{
struct udevice *pmic = dev_get_parent(dev);
int ret, fet_id;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 08/12] power: regulator: rk8xx: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (6 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 07/12] power: regulator: tps65090: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 09/12] power: sandbox: fixed: " Keerthy
` (5 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/rk8xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c
index c1ece96..3dc15e4 100644
--- a/drivers/power/regulator/rk8xx.c
+++ b/drivers/power/regulator/rk8xx.c
@@ -164,7 +164,7 @@ static int buck_set_enable(struct udevice *dev, bool enable)
return _buck_set_enable(dev->parent, buck, enable);
}
-static bool buck_get_enable(struct udevice *dev)
+static int buck_get_enable(struct udevice *dev)
{
int buck = dev->driver_data - 1;
int ret;
@@ -223,7 +223,7 @@ static int ldo_set_enable(struct udevice *dev, bool enable)
enable ? mask : 0);
}
-static bool ldo_get_enable(struct udevice *dev)
+static int ldo_get_enable(struct udevice *dev)
{
int ldo = dev->driver_data - 1;
int ret;
@@ -249,7 +249,7 @@ static int switch_set_enable(struct udevice *dev, bool enable)
enable ? mask : 0);
}
-static bool switch_get_enable(struct udevice *dev)
+static int switch_get_enable(struct udevice *dev)
{
int sw = dev->driver_data - 1;
int ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 09/12] power: sandbox: fixed: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (7 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 08/12] power: regulator: rk8xx: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 10/12] power: regulator: s5m8767: " Keerthy
` (4 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/sandbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/regulator/sandbox.c b/drivers/power/regulator/sandbox.c
index 2cca579..06c09fd 100644
--- a/drivers/power/regulator/sandbox.c
+++ b/drivers/power/regulator/sandbox.c
@@ -234,7 +234,7 @@ static int buck_set_current(struct udevice *dev, int uA)
buck_current_range, uA);
}
-static bool buck_get_enable(struct udevice *dev)
+static int buck_get_enable(struct udevice *dev)
{
if (out_get_mode(dev) == BUCK_OM_OFF)
return false;
@@ -310,7 +310,7 @@ static int ldo_set_current(struct udevice *dev, int uA)
ldo_current_range, uA);
}
-static bool ldo_get_enable(struct udevice *dev)
+static int ldo_get_enable(struct udevice *dev)
{
if (out_get_mode(dev) == LDO_OM_OFF)
return false;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 10/12] power: regulator: s5m8767: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (8 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 09/12] power: sandbox: fixed: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 11/12] power: regulator: lp873x: " Keerthy
` (3 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/s5m8767.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/regulator/s5m8767.c b/drivers/power/regulator/s5m8767.c
index 93a3c94..871da12 100644
--- a/drivers/power/regulator/s5m8767.c
+++ b/drivers/power/regulator/s5m8767.c
@@ -186,7 +186,7 @@ static int reg_set_enable(struct udevice *dev, const struct s5m8767_para *param,
return ret;
}
-static bool ldo_get_enable(struct udevice *dev)
+static int ldo_get_enable(struct udevice *dev)
{
int ldo = dev->driver_data;
@@ -226,7 +226,7 @@ static int buck_set_value(struct udevice *dev, int uv)
return reg_set_value(dev, &buck_param[buck], uv);
}
-static bool buck_get_enable(struct udevice *dev)
+static int buck_get_enable(struct udevice *dev)
{
int buck = dev->driver_data;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 11/12] power: regulator: lp873x: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (9 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 10/12] power: regulator: s5m8767: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 12/12] power: regulator: lp87565: " Keerthy
` (2 subsequent siblings)
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/lp873x_regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/regulator/lp873x_regulator.c b/drivers/power/regulator/lp873x_regulator.c
index dcb19ff..11371a7 100644
--- a/drivers/power/regulator/lp873x_regulator.c
+++ b/drivers/power/regulator/lp873x_regulator.c
@@ -256,7 +256,7 @@ static int ldo_set_value(struct udevice *dev, int uV)
return lp873x_ldo_val(dev, PMIC_OP_SET, &uV);
}
-static bool ldo_get_enable(struct udevice *dev)
+static int ldo_get_enable(struct udevice *dev)
{
bool enable = false;
int ret;
@@ -310,7 +310,7 @@ static int buck_set_value(struct udevice *dev, int uV)
return lp873x_buck_val(dev, PMIC_OP_SET, &uV);
}
-static bool buck_get_enable(struct udevice *dev)
+static int buck_get_enable(struct udevice *dev)
{
bool enable = false;
int ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 12/12] power: regulator: lp87565: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (10 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 11/12] power: regulator: lp873x: " Keerthy
@ 2017-06-13 4:23 ` Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-25 2:18 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
2017-06-29 9:40 ` Jaehoon Chung
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-13 4:23 UTC (permalink / raw)
To: u-boot
get_enable should be able to return error values. Hence change
the return type to integer.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/lp87565_regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
index 2a0b8ca..d908f6d 100644
--- a/drivers/power/regulator/lp87565_regulator.c
+++ b/drivers/power/regulator/lp87565_regulator.c
@@ -166,7 +166,7 @@ static int buck_set_value(struct udevice *dev, int uV)
return lp87565_buck_val(dev, PMIC_OP_SET, &uV);
}
-static bool buck_get_enable(struct udevice *dev)
+static int buck_get_enable(struct udevice *dev)
{
bool enable = false;
int ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 01/12] regulator: Change get_enable return type to integer from bool
2017-06-13 4:23 ` [U-Boot] [PATCH 01/12] " Keerthy
@ 2017-06-17 3:40 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:40 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> Change get_enable return type to int so errors can be returned.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/regulator-uclass.c | 2 +-
> include/power/regulator.h | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
Thanks!
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer Keerthy
@ 2017-06-17 3:40 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:40 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/fixed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 03/12] power: regulator: act8846: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 03/12] power: regulator: act8846: " Keerthy
@ 2017-06-17 3:40 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:40 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/act8846.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 04/12] power: regulator: max77686: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 04/12] power: regulator: max77686: " Keerthy
@ 2017-06-17 3:40 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:40 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/max77686.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 05/12] power: regulator: palmas: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 05/12] power: regulator: palmas: " Keerthy
@ 2017-06-17 3:40 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:40 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/palmas_regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 06/12] power: regulator: pfuze100: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 06/12] power: regulator: pfuze100: " Keerthy
@ 2017-06-17 3:40 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:40 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/pfuze100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 07/12] power: regulator: tps65090: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 07/12] power: regulator: tps65090: " Keerthy
@ 2017-06-17 3:41 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:41 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/tps65090_regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 08/12] power: regulator: rk8xx: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 08/12] power: regulator: rk8xx: " Keerthy
@ 2017-06-17 3:41 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:41 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/rk8xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 09/12] power: sandbox: fixed: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 09/12] power: sandbox: fixed: " Keerthy
@ 2017-06-17 3:41 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:41 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/sandbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 10/12] power: regulator: s5m8767: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 10/12] power: regulator: s5m8767: " Keerthy
@ 2017-06-17 3:41 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:41 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/s5m8767.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 11/12] power: regulator: lp873x: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 11/12] power: regulator: lp873x: " Keerthy
@ 2017-06-17 3:41 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:41 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/lp873x_regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 12/12] power: regulator: lp87565: get_enable should return integer
2017-06-13 4:23 ` [U-Boot] [PATCH 12/12] power: regulator: lp87565: " Keerthy
@ 2017-06-17 3:41 ` Simon Glass
0 siblings, 0 replies; 28+ messages in thread
From: Simon Glass @ 2017-06-17 3:41 UTC (permalink / raw)
To: u-boot
On 12 June 2017 at 22:23, Keerthy <j-keerthy@ti.com> wrote:
> get_enable should be able to return error values. Hence change
> the return type to integer.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/lp87565_regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (11 preceding siblings ...)
2017-06-13 4:23 ` [U-Boot] [PATCH 12/12] power: regulator: lp87565: " Keerthy
@ 2017-06-25 2:18 ` Keerthy
2017-06-26 7:35 ` Jaehoon Chung
2017-06-29 9:40 ` Jaehoon Chung
13 siblings, 1 reply; 28+ messages in thread
From: Keerthy @ 2017-06-25 2:18 UTC (permalink / raw)
To: u-boot
On Tuesday 13 June 2017 09:53 AM, Keerthy wrote:
> Change get_enable return type to int so errors can be returned.
> The series converts the return type of get_enable hook in the
> dm_regulator_ops to integer from bool. This enables it to
> return any error values if any.
Jaehoon,
Are you planning to pull this series?
Regards,
Keerthy
>
> Compile tested.
>
> Keerthy (12):
> regulator: Change get_enable return type to integer from bool
> power: regulator: fixed: get_enable should return integer
> power: regulator: act8846: get_enable should return integer
> power: regulator: max77686: get_enable should return integer
> power: regulator: palmas: get_enable should return integer
> power: regulator: pfuze100: get_enable should return integer
> power: regulator: tps65090: get_enable should return integer
> power: regulator: rk8xx: get_enable should return integer
> power: sandbox: fixed: get_enable should return integer
> power: regulator: s5m8767: get_enable should return integer
> power: regulator: lp873x: get_enable should return integer
> power: regulator: lp87565: get_enable should return integer
>
> drivers/power/regulator/act8846.c | 2 +-
> drivers/power/regulator/fixed.c | 2 +-
> drivers/power/regulator/lp873x_regulator.c | 4 ++--
> drivers/power/regulator/lp87565_regulator.c | 2 +-
> drivers/power/regulator/max77686.c | 4 ++--
> drivers/power/regulator/palmas_regulator.c | 4 ++--
> drivers/power/regulator/pfuze100.c | 2 +-
> drivers/power/regulator/regulator-uclass.c | 2 +-
> drivers/power/regulator/rk8xx.c | 6 +++---
> drivers/power/regulator/s5m8767.c | 4 ++--
> drivers/power/regulator/sandbox.c | 4 ++--
> drivers/power/regulator/tps65090_regulator.c | 2 +-
> include/power/regulator.h | 8 ++++----
> 13 files changed, 23 insertions(+), 23 deletions(-)
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool
2017-06-25 2:18 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
@ 2017-06-26 7:35 ` Jaehoon Chung
0 siblings, 0 replies; 28+ messages in thread
From: Jaehoon Chung @ 2017-06-26 7:35 UTC (permalink / raw)
To: u-boot
Hi Keerthy,
On 06/25/2017 11:18 AM, Keerthy wrote:
>
>
> On Tuesday 13 June 2017 09:53 AM, Keerthy wrote:
>> Change get_enable return type to int so errors can be returned.
>> The series converts the return type of get_enable hook in the
>> dm_regulator_ops to integer from bool. This enables it to
>> return any error values if any.
>
> Jaehoon,
>
> Are you planning to pull this series?
Sorry for late..I will review the pending patches on Tomorrow. After it, I will pull these.
Sorry again.
Best Regards,
Jaehoon Chung
>
> Regards,
> Keerthy
>
>>
>> Compile tested.
>>
>> Keerthy (12):
>> regulator: Change get_enable return type to integer from bool
>> power: regulator: fixed: get_enable should return integer
>> power: regulator: act8846: get_enable should return integer
>> power: regulator: max77686: get_enable should return integer
>> power: regulator: palmas: get_enable should return integer
>> power: regulator: pfuze100: get_enable should return integer
>> power: regulator: tps65090: get_enable should return integer
>> power: regulator: rk8xx: get_enable should return integer
>> power: sandbox: fixed: get_enable should return integer
>> power: regulator: s5m8767: get_enable should return integer
>> power: regulator: lp873x: get_enable should return integer
>> power: regulator: lp87565: get_enable should return integer
>>
>> drivers/power/regulator/act8846.c | 2 +-
>> drivers/power/regulator/fixed.c | 2 +-
>> drivers/power/regulator/lp873x_regulator.c | 4 ++--
>> drivers/power/regulator/lp87565_regulator.c | 2 +-
>> drivers/power/regulator/max77686.c | 4 ++--
>> drivers/power/regulator/palmas_regulator.c | 4 ++--
>> drivers/power/regulator/pfuze100.c | 2 +-
>> drivers/power/regulator/regulator-uclass.c | 2 +-
>> drivers/power/regulator/rk8xx.c | 6 +++---
>> drivers/power/regulator/s5m8767.c | 4 ++--
>> drivers/power/regulator/sandbox.c | 4 ++--
>> drivers/power/regulator/tps65090_regulator.c | 2 +-
>> include/power/regulator.h | 8 ++++----
>> 13 files changed, 23 insertions(+), 23 deletions(-)
>>
>
>
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
` (12 preceding siblings ...)
2017-06-25 2:18 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
@ 2017-06-29 9:40 ` Jaehoon Chung
13 siblings, 0 replies; 28+ messages in thread
From: Jaehoon Chung @ 2017-06-29 9:40 UTC (permalink / raw)
To: u-boot
On 06/13/2017 01:23 PM, Keerthy wrote:
> Change get_enable return type to int so errors can be returned.
> The series converts the return type of get_enable hook in the
> dm_regulator_ops to integer from bool. This enables it to
> return any error values if any.
>
> Compile tested.
Applied to u-boot-mmc for pmic. Thanks!
Best Regards,
Jaehoon Chung
>
> Keerthy (12):
> regulator: Change get_enable return type to integer from bool
> power: regulator: fixed: get_enable should return integer
> power: regulator: act8846: get_enable should return integer
> power: regulator: max77686: get_enable should return integer
> power: regulator: palmas: get_enable should return integer
> power: regulator: pfuze100: get_enable should return integer
> power: regulator: tps65090: get_enable should return integer
> power: regulator: rk8xx: get_enable should return integer
> power: sandbox: fixed: get_enable should return integer
> power: regulator: s5m8767: get_enable should return integer
> power: regulator: lp873x: get_enable should return integer
> power: regulator: lp87565: get_enable should return integer
>
> drivers/power/regulator/act8846.c | 2 +-
> drivers/power/regulator/fixed.c | 2 +-
> drivers/power/regulator/lp873x_regulator.c | 4 ++--
> drivers/power/regulator/lp87565_regulator.c | 2 +-
> drivers/power/regulator/max77686.c | 4 ++--
> drivers/power/regulator/palmas_regulator.c | 4 ++--
> drivers/power/regulator/pfuze100.c | 2 +-
> drivers/power/regulator/regulator-uclass.c | 2 +-
> drivers/power/regulator/rk8xx.c | 6 +++---
> drivers/power/regulator/s5m8767.c | 4 ++--
> drivers/power/regulator/sandbox.c | 4 ++--
> drivers/power/regulator/tps65090_regulator.c | 2 +-
> include/power/regulator.h | 8 ++++----
> 13 files changed, 23 insertions(+), 23 deletions(-)
>
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2017-06-29 9:40 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170613042446epcas1p379f35d0a6dcd856536bf75d02095c918@epcas1p3.samsung.com>
2017-06-13 4:23 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
2017-06-13 4:23 ` [U-Boot] [PATCH 01/12] " Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 03/12] power: regulator: act8846: " Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 04/12] power: regulator: max77686: " Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 05/12] power: regulator: palmas: " Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 06/12] power: regulator: pfuze100: " Keerthy
2017-06-17 3:40 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 07/12] power: regulator: tps65090: " Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 08/12] power: regulator: rk8xx: " Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 09/12] power: sandbox: fixed: " Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 10/12] power: regulator: s5m8767: " Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 11/12] power: regulator: lp873x: " Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-13 4:23 ` [U-Boot] [PATCH 12/12] power: regulator: lp87565: " Keerthy
2017-06-17 3:41 ` Simon Glass
2017-06-25 2:18 ` [U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool Keerthy
2017-06-26 7:35 ` Jaehoon Chung
2017-06-29 9:40 ` Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.