From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FECC10F1B for ; Wed, 14 Dec 2022 00:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236975AbiLNACW (ORCPT ); Tue, 13 Dec 2022 19:02:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236598AbiLNACV (ORCPT ); Tue, 13 Dec 2022 19:02:21 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE18222B15 for ; Tue, 13 Dec 2022 16:02:19 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id x28so7722904lfn.6 for ; Tue, 13 Dec 2022 16:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F4wzLNz6dwbsx5heN6y8ApOHwBgCymyPsBRS4COOYFM=; b=cz6w9iekOtz1phgLx4mKtqjxhJ5PKY8yopabUl8Vl8TR8IfUTFb1WeZ/L9L6vt30wV bbDs6rV5b9mkcsN3I6ndGH+zrjdGdYMSBxtI0XeuO1yOBOIuKodL2cA3wihjs1eUCADn 9XNmnQlcqiKmpcJ3dmLNz8axo2Qiz8zgFSLKCKSGfpnVE7gK9iz9emddeREw1pX1G5zr f0Wu2tsrSLrn9Mx2f9qmlO0KgakSX1ZY35ZIApdiFLC2YRYj2tlzfMaSUj0xqxEQ4wu7 4Cltns0mpYlYlXejav8yiWL/maxSPolVjgPeJWK0LTI7sytbYE8EzjdKIPoWHgks1XSJ I+dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F4wzLNz6dwbsx5heN6y8ApOHwBgCymyPsBRS4COOYFM=; b=m5mW6SKn+LM1HGuj2myyz2TS4hqZZ5CobBD4nNqCdzWQ2i1Dnas0lsiwZMsfKMeTjV dilZfAdbkr1eVyjBdOCrYdeE88bsr3U1fd6TsoZuAfG+WVOIS9vF5eTIEgDWhgVagaUC VYLBo+0Vqp9MHDnetHdOZKbjGEgF0iGIAWrOft3AICCjuJljDjREYhXN5Av1BYsY1viR G37pp3VsaFkaBAbkG4ug0tZwGhf2Dg6b2cWeeYdlFEQhnggUzEam6PSS3Ok+p4RsrEDQ hL1EXUkXULzO7UpfZ62+K7BkMKARtplTOqgfmocpMbbdyfSF2fF4JwsauNc3s3OFKMw9 szpQ== X-Gm-Message-State: ANoB5pkarW5wGrHc41vEiREjyNpQ0+GyFTV6VQDM+CAzrsW8saCGuxmo qn9EHtzZd8i/XNJejPDkigcSpA== X-Google-Smtp-Source: AA0mqf4OPQ41A6YQWwi4U9K/lp0Wdyo5nPJOWKYHo+40cNenTg2e7rXr3g3txA7AaybzmQI7F4YIJw== X-Received: by 2002:a05:6512:15a6:b0:4b4:b5bf:3ce6 with SMTP id bp38-20020a05651215a600b004b4b5bf3ce6mr9902578lfb.38.1670976137948; Tue, 13 Dec 2022 16:02:17 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id p17-20020ac246d1000000b0049e9122bd0esm558261lfo.114.2022.12.13.16.02.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 16:02:17 -0800 (PST) Message-ID: Date: Wed, 14 Dec 2022 01:02:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 5/6] drm/msm/dsi: Flip greater-than check for slice_count and slice_per_intf Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Vinod Koul Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , Bjorn Andersson , Jessica Zhang , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Kuogee Hsieh , Jani Nikula , sunliming , Sam Ravnborg , Haowen Bai , Loic Poulain , Vinod Polimera , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221213232207.113607-1-marijn.suijten@somainline.org> <20221213232207.113607-6-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20221213232207.113607-6-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 14.12.2022 00:22, Marijn Suijten wrote: > According to downstream /and the comment copied from it/ this comparison > should be the other way around. In other words, when the panel driver > requests to use more slices per packet than what could be sent over this > interface, it is bumped down to only use a single slice per packet (and > strangely not the number of slices that could fit on the interface). > > Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration") > --- Missing s-o-b > drivers/gpu/drm/msm/dsi/dsi_host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 0686c35a6fd4..9bdfa0864cdf 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -855,11 +855,11 @@ static void dsi_update_dsc_timing(struct msm_dsi_host *msm_host, bool is_cmd_mod > */ > slice_per_intf = DIV_ROUND_UP(hdisplay, dsc->slice_width); > > - /* If slice_per_pkt is greater than slice_per_intf > + /* If slice_count is greater than slice_per_intf > * then default to 1. This can happen during partial > * update. > */ > - if (slice_per_intf > dsc->slice_count) > + if (dsc->slice_count > slice_per_intf) > dsc->slice_count = 1; > > total_bytes_per_intf = dsc->slice_chunk_size * slice_per_intf; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BE51C4167B for ; Wed, 14 Dec 2022 00:02:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6951310E1CC; Wed, 14 Dec 2022 00:02:23 +0000 (UTC) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9348310E1F3 for ; Wed, 14 Dec 2022 00:02:19 +0000 (UTC) Received: by mail-lf1-x130.google.com with SMTP id p8so7686431lfu.11 for ; Tue, 13 Dec 2022 16:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F4wzLNz6dwbsx5heN6y8ApOHwBgCymyPsBRS4COOYFM=; b=cz6w9iekOtz1phgLx4mKtqjxhJ5PKY8yopabUl8Vl8TR8IfUTFb1WeZ/L9L6vt30wV bbDs6rV5b9mkcsN3I6ndGH+zrjdGdYMSBxtI0XeuO1yOBOIuKodL2cA3wihjs1eUCADn 9XNmnQlcqiKmpcJ3dmLNz8axo2Qiz8zgFSLKCKSGfpnVE7gK9iz9emddeREw1pX1G5zr f0Wu2tsrSLrn9Mx2f9qmlO0KgakSX1ZY35ZIApdiFLC2YRYj2tlzfMaSUj0xqxEQ4wu7 4Cltns0mpYlYlXejav8yiWL/maxSPolVjgPeJWK0LTI7sytbYE8EzjdKIPoWHgks1XSJ I+dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F4wzLNz6dwbsx5heN6y8ApOHwBgCymyPsBRS4COOYFM=; b=S0CObkSw/NacWWMMM11MCUNiCtHpCVObSvEH/tYAmumiZxnJkICRS8FV9kxixhuuqe 1pjmwfnNY6BT98RfOVUIlSTwx8nEJD4sb9lQQYSHmuIllhTBWKW7cG0Otw33dY3DwviX On84WYOgwx7OdTTDD4P+R/wMra5du0f9TuNtjQEmw/W7GjYW+GLR4XCIF1ufF3lqrfRd elTpxc8k5X7ynUbn0fkfoO4eRQOe02KQNQ7ZNor4Kvh+jQZ9H/JS+6tdKC/EamhKo1BN yjiiCEtqrWH3byRTnSE36Q+sTmwcDaHlWfDGdl2r6rdxGI6sOurc6N2zg2501Ot9V47Z Ptqg== X-Gm-Message-State: ANoB5pmmaoQWvmsHMvyGFiKrzhCBi7o36v7qBNLSln/gv4FgWxcK/pN/ GYSJrsSIYwBXJVFk/rACxcrVrg== X-Google-Smtp-Source: AA0mqf4OPQ41A6YQWwi4U9K/lp0Wdyo5nPJOWKYHo+40cNenTg2e7rXr3g3txA7AaybzmQI7F4YIJw== X-Received: by 2002:a05:6512:15a6:b0:4b4:b5bf:3ce6 with SMTP id bp38-20020a05651215a600b004b4b5bf3ce6mr9902578lfb.38.1670976137948; Tue, 13 Dec 2022 16:02:17 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id p17-20020ac246d1000000b0049e9122bd0esm558261lfo.114.2022.12.13.16.02.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 16:02:17 -0800 (PST) Message-ID: Date: Wed, 14 Dec 2022 01:02:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 5/6] drm/msm/dsi: Flip greater-than check for slice_count and slice_per_intf Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Vinod Koul References: <20221213232207.113607-1-marijn.suijten@somainline.org> <20221213232207.113607-6-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20221213232207.113607-6-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Konrad Dybcio , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Vinod Polimera , Sam Ravnborg , Haowen Bai , Kuogee Hsieh , Jessica Zhang , Jani Nikula , linux-arm-msm@vger.kernel.org, Stephen Boyd , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, Sean Paul , Loic Poulain , Jami Kettunen , Bjorn Andersson , Vladimir Lypak , Douglas Anderson , sunliming , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 14.12.2022 00:22, Marijn Suijten wrote: > According to downstream /and the comment copied from it/ this comparison > should be the other way around. In other words, when the panel driver > requests to use more slices per packet than what could be sent over this > interface, it is bumped down to only use a single slice per packet (and > strangely not the number of slices that could fit on the interface). > > Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration") > --- Missing s-o-b > drivers/gpu/drm/msm/dsi/dsi_host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 0686c35a6fd4..9bdfa0864cdf 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -855,11 +855,11 @@ static void dsi_update_dsc_timing(struct msm_dsi_host *msm_host, bool is_cmd_mod > */ > slice_per_intf = DIV_ROUND_UP(hdisplay, dsc->slice_width); > > - /* If slice_per_pkt is greater than slice_per_intf > + /* If slice_count is greater than slice_per_intf > * then default to 1. This can happen during partial > * update. > */ > - if (slice_per_intf > dsc->slice_count) > + if (dsc->slice_count > slice_per_intf) > dsc->slice_count = 1; > > total_bytes_per_intf = dsc->slice_chunk_size * slice_per_intf;