From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "John W. Linville" <linville@tuxdriver.com>, dev@dpdk.org
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH 3/4] i40e_vsi_release: do not use vsi until after NULL check
Date: Thu, 29 Sep 2016 09:15:24 +0100 [thread overview]
Message-ID: <c5fd0eef-ffa3-abb1-7bae-4a87c9409c83@intel.com> (raw)
In-Reply-To: <1475090404-20707-4-git-send-email-linville@tuxdriver.com>
On 9/28/2016 8:20 PM, John W. Linville wrote:
> Coverity: 127556
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
a few minor nits:
- patch subject tag/label should be "net/<driver>: ", so patch subject:
"net/i40e: do not use VSI until after NULL check"
- These are fixes, requires fixes line, for this patch:
Fixes: 440499cf5376 ("net/i40e: support floating VEB")
- For coverity fixes, defined usage is: "Coverity issue: XXXXX"
- Can be good to CC stable tree for these fixes.
Overall patch comment becomes something like:
"
net/i40e: do not use VSI until after NULL check
Coverity issue: 127556
Fixes: 440499cf5376 ("net/i40e: support floating VEB")
Signed-off-by: John W. Linville <linville@tuxdriver.com>
"
next prev parent reply other threads:[~2016-09-29 8:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 19:20 [PATCH 0/4] random fixes for bugs identified by Coverity John W. Linville
2016-09-28 19:20 ` [PATCH 1/4] ena_config_host_info: improve safety of string handling John W. Linville
2016-09-28 19:20 ` [PATCH 2/4] bnxt_alloc_vnic_attributes: ensure entry_length is unsigned John W. Linville
2016-09-28 19:20 ` [PATCH 3/4] i40e_vsi_release: do not use vsi until after NULL check John W. Linville
2016-09-29 8:15 ` Ferruh Yigit [this message]
2016-09-28 19:20 ` [PATCH 4/4] bnxt_mac_addr_remove_op: add ULL suffix to constant 1 in bit shift John W. Linville
2016-09-29 17:39 ` [PATCH v2 0/4] random fixes for bugs identified by Coverity John W. Linville
2016-09-29 17:39 ` [PATCH v2 1/4] net/ena: improve safety of string handling in ena_config_host_info John W. Linville
2016-10-12 16:24 ` [dpdk-stable] " Ferruh Yigit
2016-09-29 17:39 ` [PATCH v2 2/4] net/bnxt: ensure entry_length is unsigned in bnxt_alloc_vnic_attributes John W. Linville
2016-09-29 19:06 ` Ajit Khaparde
2016-09-29 17:39 ` [PATCH v2 3/4] net/i40e: do not use vsi until after NULL check in i40e_vsi_release John W. Linville
2016-09-29 17:39 ` [PATCH v2 4/4] net/bnxt: add ULL suffix to constant 1 for bit shift in bnxt_mac_addr_remove_op John W. Linville
2016-10-10 18:41 ` Ajit Khaparde
2016-10-13 9:31 ` [PATCH v2 0/4] random fixes for bugs identified by Coverity Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5fd0eef-ffa3-abb1-7bae-4a87c9409c83@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.