From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C2DAC433F5 for ; Wed, 11 May 2022 12:39:46 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.326796.549430 (Exim 4.92) (envelope-from ) id 1nolcp-0008Cm-IY; Wed, 11 May 2022 12:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326796.549430; Wed, 11 May 2022 12:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolcp-0008Cf-Fx; Wed, 11 May 2022 12:39:31 +0000 Received: by outflank-mailman (input) for mailman id 326796; Wed, 11 May 2022 12:39:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolco-0008CZ-DD for xen-devel@lists.xenproject.org; Wed, 11 May 2022 12:39:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolcn-0006St-Sw; Wed, 11 May 2022 12:39:29 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nolcn-0002qz-Mx; Wed, 11 May 2022 12:39:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JowkZp54Hzn/o1MfZbiUjePUk6ZiqdW+7E8xfPqKjNE=; b=YRsVWxVibiXVwdUhAxR+Ko+dFG Mypzp4lTPQY7RX2y1IN48GzWnsjBVphpkbE6nsyatsZPUP+hJDwOElrAMj06xjECO15aR5VqjVjqz bNrtypNI9bCT0gNR2EJjL1gM5yM8Z1OUsI0RN7ZKgnXGDYijfvId+9cs/DV9DldSXLaM=; Message-ID: Date: Wed, 11 May 2022 13:39:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: George Dunlap Cc: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper , Jan Beulich , Wei Liu References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <82e54293-926e-b7ee-7091-a85a9db8f6c5@xen.org> <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> From: Julien Grall In-Reply-To: <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi George, On 11/05/2022 13:11, George Dunlap wrote: >>> Google told me __force is used in linux kernel to suppress warning in sparse, >>> https://stackoverflow.com/questions/53120610/what-does-the-attribute-force-do >>> Is sparse also used in xen? >> >> I am not aware of any use of Sparse in Xen, but it would technically be possible. >> >> However, my point here is more that this change seems to be unrelated to what the patch is meant to do (i.e. switching to byteswap). So if it is unnecessary, then it should be dropped from this patch. > > I think making people pull little changes like this out into separate patches is asking too much. It’s a lot of extra effort on the part of the submitter for basically no value. We commonly do little clean-ups like this in patches, and just require a comment at the bottom, like this: I suggested to drop from the patch because I don't think we should remove the __force. In fact, I have contemplated a few times in the past to use sparse in Xen. Sorry I should have been clearer. Cheers, -- Julien Grall