All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/wpa_supplicant: Add options to disable more features.
Date: Sat, 13 Feb 2021 13:21:28 +0100	[thread overview]
Message-ID: <c6237102-2340-0536-8fba-424b3d832401@mind.be> (raw)
In-Reply-To: <20210210185017.6133-2-nicolas.cavallari@green-communications.fr>



On 10/02/2021 19:50, Nicolas Cavallari wrote:
[snip]
> +config BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE
> +	bool "Enable the Unix-socket control interface"
> +	help
> +	  Enable support for the Unix-socket-based API.
> +

 I'm surprised that the control interface makes that much of a difference...
AFAIK it's just a single file, no?

[snip]
> +ifneq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
> +WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_DRIVER_WIRED \

 This should be written as:

WPA_SUPPLICANT_CONFIG_DISABLE += \
	CONFIG_DRIVER_WIRED \

 The file contains both styles, but I think we prefer the one-option-per-line
style for new code.

 Regards,
 Arnout


> +	CONFIG_MACSEC \
> +	CONFIG_DRIVER_MACSEC
> +endif
> +
>  ifneq ($(BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT),y)
>  WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_HS20 \
>  	CONFIG_INTERWORKING
> @@ -117,6 +131,10 @@ WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD CONFIG_EAP_TEAP
>  WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=\).*/\1internal/'
>  endif
>  
> +ifneq ($(BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE),y)
> +WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_CTRL_IFACE
> +endif
> +
>  ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DBUS),y)
>  WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf dbus
>  WPA_SUPPLICANT_MAKE_ENV = \
> 

  reply	other threads:[~2021-02-13 12:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 18:50 [Buildroot] [PATCH 1/3] package/wpa_supplicant: Fix options to actually disable features Nicolas Cavallari
2021-02-10 18:50 ` [Buildroot] [PATCH 2/3] package/wpa_supplicant: Add options to disable more features Nicolas Cavallari
2021-02-13 12:21   ` Arnout Vandecappelle [this message]
2021-02-13 12:42     ` Nicolas Cavallari
2021-02-10 18:50 ` [Buildroot] [PATCH 3/3] package/wpa_supplicant: Simplify D-Bus support Nicolas Cavallari
2021-02-13 12:46 ` [Buildroot] [PATCH 1/3] package/wpa_supplicant: Fix options to actually disable features Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6237102-2340-0536-8fba-424b3d832401@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.