From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA15C433DF for ; Wed, 19 Aug 2020 09:20:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7026B20639 for ; Wed, 19 Aug 2020 09:20:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726972AbgHSJUA (ORCPT ); Wed, 19 Aug 2020 05:20:00 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:33340 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbgHSJT6 (ORCPT ); Wed, 19 Aug 2020 05:19:58 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-160-_229ysE0OG6jw3ucHhB40g-1; Wed, 19 Aug 2020 10:19:53 +0100 X-MC-Unique: _229ysE0OG6jw3ucHhB40g-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 19 Aug 2020 10:19:52 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Wed, 19 Aug 2020 10:19:52 +0100 From: David Laight To: 'Arnd Bergmann' , Mika Westerberg CC: Daniel Gutson , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , linux-mtd , "linux-kernel@vger.kernel.org" , Alex Bazhaniuk , "Richard Hughes" , Greg Kroah-Hartman Subject: RE: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable Thread-Topic: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable Thread-Index: AQHWdgQqCdINb+eDE0uGZC/C71DMN6k/JlWw Date: Wed, 19 Aug 2020 09:19:52 +0000 Message-ID: References: <20200819065721.GA1375436@lahna.fi.intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: aculab.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RnJvbTogQXJuZCBCZXJnbWFubg0KPiBTZW50OiAxOSBBdWd1c3QgMjAyMCAwOTozOA0KLi4uDQo+ IElmIHlvdSBhcmUgcmVhbGx5IHdvcnJpZWQgYWJvdXQgdGhlIHdyaXRlIHByb3RlY3Rpb24gYmVp bmcgYnlwYXNzZWQgYnkNCj4gYSBkaWZmZXJlbnQgZHJpdmVyIG9yIGNvZGUgaW5qZWN0aW9uLCB0 aGUgYmVzdCB3YXkgd291bGQgc2VlbSB0byBiZSB0bw0KPiBvbmx5IGVuYWJsZSB3cml0aW5nIGlu IHRoZSBtdGQgd3JpdGUgY2FsbGJhY2sgYW5kIGRpc2FibGUgaXQgaW1tZWRpYXRlbHkNCj4gYWZ0 ZXIgdGhlIHdyaXRlIGlzIGNvbXBsZXRlLiBJIHN0aWxsIGRvbid0IHNlZSB3aHkgdGhpcyBoYXJk d2FyZSB3b3VsZA0KPiBiZSBtb3JlIHN1c2NlcHRpYmxlIHRvIHRoaXMga2luZCBvZiBhdHRhY2sg dGhhbiBvdGhlciBkcml2ZXJzIHRob3VnaCwNCj4gYXMgaXQgYWxyZWFkeSBoYXMgdGhlIHNhZmVn dWFyZCBhZ2FpbnN0IHdyaXRpbmcgdGhyb3VnaCB0aGUgTVREIGxheWVyDQo+IHdpdGhvdXQgdGhl IG1vZHVsZSBwYXJhbWV0ZXIuDQoNCkl0IGlzIHByZXR0eSB1bmxpa2VseSB0aGF0IGFueW9uZSB3 aWxsIGFjY2lkZW50YWxseSBkbyBhbiBzcGkgd3JpdGUNCihpdCBpcyBhbGwgdG9vIGNvbXBsaWNh dGVkKS4NCkFueXRoaW5nIHRoYXQgaXMgYmVpbmcgbWlzY2hpZXZvdXMgY2FuIHNlbmQgdGhlIHdy aXRlIGVuYWJsZQ0KY29tbWFuZCBpdHNlbGYuDQoNCklmIHlvdSBjYXJlIHlvdSBuZWVkIHRvIHVz ZSB0aGUgZGV2aWNlIHBpbiB0byBkaXNhYmxlIHdyaXRlcy4NCg0KCURhdmlkDQogDQoNCi0NClJl Z2lzdGVyZWQgQWRkcmVzcyBMYWtlc2lkZSwgQnJhbWxleSBSb2FkLCBNb3VudCBGYXJtLCBNaWx0 b24gS2V5bmVzLCBNSzEgMVBULCBVSw0KUmVnaXN0cmF0aW9uIE5vOiAxMzk3Mzg2IChXYWxlcykN Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFEEC433E3 for ; Wed, 19 Aug 2020 09:20:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40E1020639 for ; Wed, 19 Aug 2020 09:20:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GkRAfHQl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40E1020639 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1n8VUyEPgJvzvZAj9SVzGXoCTS9pl45/9oBowTHW4Ps=; b=GkRAfHQl65zHkE2Fu0jNQyB5i R5S2t+x0I2oo44qmYbGQ07MsvwnlFztVZ9qMb4Lc1kNii5XL9QAu85NXpxRklhTsqOMm8twsiW5uQ 2Y5axJOuvqm/no7jgopvB35UvdWU30Kx+P1/vQ8yrHK0XwOlkjJpkYWeqnSUZQvPk06bj8r2eG+O1 RUq3tjfnd9zULhWfW0EfkNIDOyIFAD+qA1MNsB6WjH/w2BQl/h4TVXPO4OvkQsX1slkI5VQa7FZi2 ZA3uqeAJ7i85uwPNZuy+Eg3hou8qR559yPSGpqf6z+sys0LxmWvLNhLW9e1hk66w0nP2cGtJmXH4U lCneqGj2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8KGK-0003s5-Pc; Wed, 19 Aug 2020 09:20:04 +0000 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8KGI-0003qT-22 for linux-mtd@lists.infradead.org; Wed, 19 Aug 2020 09:20:03 +0000 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-160-_229ysE0OG6jw3ucHhB40g-1; Wed, 19 Aug 2020 10:19:53 +0100 X-MC-Unique: _229ysE0OG6jw3ucHhB40g-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 19 Aug 2020 10:19:52 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Wed, 19 Aug 2020 10:19:52 +0100 From: David Laight To: 'Arnd Bergmann' , Mika Westerberg Subject: RE: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable Thread-Topic: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable Thread-Index: AQHWdgQqCdINb+eDE0uGZC/C71DMN6k/JlWw Date: Wed, 19 Aug 2020 09:19:52 +0000 Message-ID: References: <20200819065721.GA1375436@lahna.fi.intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: aculab.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_052002_318015_E4ECEB0E X-CRM114-Status: GOOD ( 14.37 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Hughes , Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , Tudor Ambarus , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , linux-mtd , Daniel Gutson , Miquel Raynal , Alex Bazhaniuk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann > Sent: 19 August 2020 09:38 ... > If you are really worried about the write protection being bypassed by > a different driver or code injection, the best way would seem to be to > only enable writing in the mtd write callback and disable it immediately > after the write is complete. I still don't see why this hardware would > be more susceptible to this kind of attack than other drivers though, > as it already has the safeguard against writing through the MTD layer > without the module parameter. It is pretty unlikely that anyone will accidentally do an spi write (it is all too complicated). Anything that is being mischievous can send the write enable command itself. If you care you need to use the device pin to disable writes. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/