From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752253AbdGFTsB (ORCPT ); Thu, 6 Jul 2017 15:48:01 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:34785 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbdGFTsA (ORCPT ); Thu, 6 Jul 2017 15:48:00 -0400 Subject: Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() To: Alexandre Belloni , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Gregory Clement Cc: linux-arm-kernel@lists.infradead.org, support@lemaker.org, =?UTF-8?B?5byg5aSp55uK?= , Arnd Bergmann , =?UTF-8?B?5qKF5Yip?= , linux-kernel@vger.kernel.org, Thomas Liau , Russell King , support@cubietech.com, lee@cubietech.com, =?UTF-8?B?5byg5Lic6aOO?= , =?UTF-8?B?5YiY54Kc?= , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Neil Armstrong , Nicolas Ferre References: <20170704233219.18790-1-afaerber@suse.de> <3F3740FC-3873-4C01-A625-C8DC7F50A018@gmail.com> <20170706173841.jwaskrrkooget6nk@piout.net> From: Florian Fainelli Message-ID: Date: Thu, 6 Jul 2017 12:47:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170706173841.jwaskrrkooget6nk@piout.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2017 10:38 AM, Alexandre Belloni wrote: > On 06/07/2017 at 19:17:28 +0200, Andreas Färber wrote: >> Am 05.07.2017 um 04:36 schrieb Florian Fainelli: >>> On July 4, 2017 4:32:18 PM PDT, "Andreas Färber" wrote: >>>> Commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45 ("ARM: owl: smp: Drop >>>> bogus holding pen") simplified the S500 SMP code by removing a loop for >>>> pen_release in owl_secondary_boot(). Since then it is only calling >>>> owl_v7_invalidate_l1() before branching to secondary_startup(). >>>> >>>> The owl_v7_invalidate_l1() assembler function is superfluous, too. >>>> Therefore drop owl_secondary_boot() and use secondary_boot() directly. >>>> >>>> Cc: David Liu >>>> Signed-off-by: Andreas Färber >>>> --- >>> >>>> - writel(virt_to_phys(owl_secondary_startup), >>>> + writel(virt_to_phys(secondary_startup), >>>> timer_base_addr + OWL_CPU1_ADDR + (cpu - 1) * 4); >>> >>> This is a kernel symbol so please use __pa_symbol() here, also you might want to build with CONFIG_DEBUG_VIRTUAL and see if you get other warnings about using virt_to_phys() in the owl platform code (I did not check if there are other uses) >> >> Thanks for the report. There are no other such uses in mach-actions, but >> git-grep'ing for virt_to_phys in arch/arm/mach-* I spot at least one >> other such usage in mach-oxnas: >> >> arch/arm/mach-oxnas/platsmp.c: >> writel(virt_to_phys(ox820_secondary_startup), >> >> as well as this in mach-mvebu: >> >> arch/arm/mach-mvebu/platsmp.c: writel(virt_to_phys(boot_addr), base + >> MV98DX3236_CPU_RESUME_ADDR_REG); >> >> and these in mach-at91: >> >> arch/arm/mach-at91/pm.c: pm_bu->canary = virt_to_phys(&canary); >> arch/arm/mach-at91/pm.c: pm_bu->resume = virt_to_phys(cpu_resume); >> > > They can probably use __pa_symbol() (I must admit I didn't know about > it before this email) This is fine, do you mind sending fixes for the at91 parts? Gregory, can you also fix the mv98dx3236 platform SMP code? Thanks! -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Thu, 6 Jul 2017 12:47:55 -0700 Subject: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() In-Reply-To: <20170706173841.jwaskrrkooget6nk@piout.net> References: <20170704233219.18790-1-afaerber@suse.de> <3F3740FC-3873-4C01-A625-C8DC7F50A018@gmail.com> <20170706173841.jwaskrrkooget6nk@piout.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/06/2017 10:38 AM, Alexandre Belloni wrote: > On 06/07/2017 at 19:17:28 +0200, Andreas F?rber wrote: >> Am 05.07.2017 um 04:36 schrieb Florian Fainelli: >>> On July 4, 2017 4:32:18 PM PDT, "Andreas F?rber" wrote: >>>> Commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45 ("ARM: owl: smp: Drop >>>> bogus holding pen") simplified the S500 SMP code by removing a loop for >>>> pen_release in owl_secondary_boot(). Since then it is only calling >>>> owl_v7_invalidate_l1() before branching to secondary_startup(). >>>> >>>> The owl_v7_invalidate_l1() assembler function is superfluous, too. >>>> Therefore drop owl_secondary_boot() and use secondary_boot() directly. >>>> >>>> Cc: David Liu >>>> Signed-off-by: Andreas F?rber >>>> --- >>> >>>> - writel(virt_to_phys(owl_secondary_startup), >>>> + writel(virt_to_phys(secondary_startup), >>>> timer_base_addr + OWL_CPU1_ADDR + (cpu - 1) * 4); >>> >>> This is a kernel symbol so please use __pa_symbol() here, also you might want to build with CONFIG_DEBUG_VIRTUAL and see if you get other warnings about using virt_to_phys() in the owl platform code (I did not check if there are other uses) >> >> Thanks for the report. There are no other such uses in mach-actions, but >> git-grep'ing for virt_to_phys in arch/arm/mach-* I spot at least one >> other such usage in mach-oxnas: >> >> arch/arm/mach-oxnas/platsmp.c: >> writel(virt_to_phys(ox820_secondary_startup), >> >> as well as this in mach-mvebu: >> >> arch/arm/mach-mvebu/platsmp.c: writel(virt_to_phys(boot_addr), base + >> MV98DX3236_CPU_RESUME_ADDR_REG); >> >> and these in mach-at91: >> >> arch/arm/mach-at91/pm.c: pm_bu->canary = virt_to_phys(&canary); >> arch/arm/mach-at91/pm.c: pm_bu->resume = virt_to_phys(cpu_resume); >> > > They can probably use __pa_symbol() (I must admit I didn't know about > it before this email) This is fine, do you mind sending fixes for the at91 parts? Gregory, can you also fix the mv98dx3236 platform SMP code? Thanks! -- Florian