From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB01C433F5 for ; Tue, 7 Sep 2021 15:30:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C424A610C9 for ; Tue, 7 Sep 2021 15:30:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345253AbhIGPbb (ORCPT ); Tue, 7 Sep 2021 11:31:31 -0400 Received: from thoth.sbs.de ([192.35.17.2]:56496 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345158AbhIGPba (ORCPT ); Tue, 7 Sep 2021 11:31:30 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 187FUEkh024943 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Sep 2021 17:30:14 +0200 Received: from [167.87.245.242] ([167.87.245.242]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 187FUDCI012757; Tue, 7 Sep 2021 17:30:13 +0200 Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bao Cheng Su , Chao Zeng References: <8e2e435ef67868cb98382b44c51ddb5c8d045d66.1631024536.git.jan.kiszka@siemens.com> <20210907151301.7fqwmc7hmcyhhybv@carve> <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com> <20210907152746.fbddtkktvx6hb5ti@cattishly> From: Jan Kiszka Message-ID: Date: Tue, 7 Sep 2021 17:30:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907152746.fbddtkktvx6hb5ti@cattishly> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.09.21 17:27, Nishanth Menon wrote: > On 17:20-20210907, Jan Kiszka wrote: >> On 07.09.21 17:13, Nishanth Menon wrote: >>> On 16:22-20210907, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> This ensures that the SD card will remain mmc0 across Basic and Advanced >>>> devices, also avoiding surprises for users coming from the downstream >>>> kernels. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>> index ec9617c13cdb..d1d5278e0b94 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>> @@ -18,6 +18,11 @@ / { >>>> compatible = "siemens,iot2050-advanced", "ti,am654"; >>>> model = "SIMATIC IOT2050 Advanced"; >>>> >>>> + aliases { >>>> + mmc0 = &sdhci1; >>>> + mmc1 = &sdhci0; >>>> + }; >>> >>> >>> Should we do this at SoC level? >>> >> >> Well, I wouldn't mind - but that would also impact your EVMs. For us, >> this is fine as we are coming from that ordering above with our >> downstream kernel/dts. >> > > I think it'd probably be a welcome change. overall we've standardized on > partuuid. > Yeah, it's more about "dd if=emmc.img of=/dev/mmcblk1 - damn, the wrong one again." Let me know what you prefer, and I'll update my patch. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F4EC433EF for ; Tue, 7 Sep 2021 15:32:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5213460F5E for ; Tue, 7 Sep 2021 15:32:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5213460F5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/HNzB9kY4+vzBeI0FacO1YNeWyoZRnq9Jx3eSIYz9IM=; b=QfphoCWPwNmP1MBPf/Ege97lxL b4X1OFxWFYx7lbCxYEfFZCs6AcB1+Zm2T/0VW2tFEheb4Y+05ODkCVyAJVX42XXuAnbaVkU2ZakXE 7EKcL5yxt/suvTg5At7FRwQA3bdweGH8qNDdGXcAzjOZH71vMKoiRLB8VH/mdli/CofHILpQ7dWFg rXGhKQ266Ety7iALJQimC3kE9nFMoLln4PCtAjG94BruE9lKvKN+pQDKnISNfE+iA51hC0gL+dSQV eMUJ65cj2ni0MqtIDS53dm9BqOjXhskKY4XERYSfXID9gWK3c/IsFVNUKiFwOZWmGW9Pkva0CNqQ1 LSADnirw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNd3H-0044RO-Mj; Tue, 07 Sep 2021 15:30:23 +0000 Received: from thoth.sbs.de ([192.35.17.2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNd3C-0044Px-S3 for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 15:30:20 +0000 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 187FUEkh024943 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Sep 2021 17:30:14 +0200 Received: from [167.87.245.242] ([167.87.245.242]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 187FUDCI012757; Tue, 7 Sep 2021 17:30:13 +0200 Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bao Cheng Su , Chao Zeng References: <8e2e435ef67868cb98382b44c51ddb5c8d045d66.1631024536.git.jan.kiszka@siemens.com> <20210907151301.7fqwmc7hmcyhhybv@carve> <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com> <20210907152746.fbddtkktvx6hb5ti@cattishly> From: Jan Kiszka Message-ID: Date: Tue, 7 Sep 2021 17:30:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907152746.fbddtkktvx6hb5ti@cattishly> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_083019_261523_FD1A0531 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07.09.21 17:27, Nishanth Menon wrote: > On 17:20-20210907, Jan Kiszka wrote: >> On 07.09.21 17:13, Nishanth Menon wrote: >>> On 16:22-20210907, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> This ensures that the SD card will remain mmc0 across Basic and Advanced >>>> devices, also avoiding surprises for users coming from the downstream >>>> kernels. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>> index ec9617c13cdb..d1d5278e0b94 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>> @@ -18,6 +18,11 @@ / { >>>> compatible = "siemens,iot2050-advanced", "ti,am654"; >>>> model = "SIMATIC IOT2050 Advanced"; >>>> >>>> + aliases { >>>> + mmc0 = &sdhci1; >>>> + mmc1 = &sdhci0; >>>> + }; >>> >>> >>> Should we do this at SoC level? >>> >> >> Well, I wouldn't mind - but that would also impact your EVMs. For us, >> this is fine as we are coming from that ordering above with our >> downstream kernel/dts. >> > > I think it'd probably be a welcome change. overall we've standardized on > partuuid. > Yeah, it's more about "dd if=emmc.img of=/dev/mmcblk1 - damn, the wrong one again." Let me know what you prefer, and I'll update my patch. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel