All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Markus Böhme" <markus.boehme@mailbox.org>
To: Andrew Kanner <andrew.kanner@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, manohar.vanga@gmail.com,
	egor.ulieiskii@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: drivers: staging: vme: Fixed some code style warnings
Date: Wed, 14 Sep 2016 14:55:27 +0200	[thread overview]
Message-ID: <c64f813e-b92e-74f2-fd86-1e45aac495ce@mailbox.org> (raw)
In-Reply-To: <1473719504-14435-1-git-send-email-andrew.kanner@gmail.com>

On 09/13/2016 12:31 AM, Andrew Kanner wrote:
> Signed-off-by: Andrew Kanner <andrew.kanner@gmail.com>
> ---
>  drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------
>  drivers/staging/vme/devices/vme_user.c      |  2 +-
>  2 files changed, 7 insertions(+), 7 deletions(-)
> (snip)

Hello Andrew,

please be more specific in your subject line, e.g.
"drivers: staging: vme: Convert to octal notation for permission bits".

Also don't forget to add a commit message to your patch with a short
description what you are fixing and why. In your case it would be good
to mention that you are fixing a checkpatch warning, and to include the
warning message in your description. Then resend as V2.

Thanks,
Markus

  reply	other threads:[~2016-09-14 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 22:31 drivers: staging: vme: Fixed some code style warnings Andrew Kanner
2016-09-14 12:55 ` Markus Böhme [this message]
2016-09-14 16:31   ` Andrew Kanner
2016-09-14 21:46     ` Markus Böhme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c64f813e-b92e-74f2-fd86-1e45aac495ce@mailbox.org \
    --to=markus.boehme@mailbox.org \
    --cc=andrew.kanner@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=egor.ulieiskii@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manohar.vanga@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.