From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964802AbcGZS5H (ORCPT ); Tue, 26 Jul 2016 14:57:07 -0400 Received: from mout.web.de ([212.227.15.4]:60354 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932345AbcGZS5E (ORCPT ); Tue, 26 Jul 2016 14:57:04 -0400 Subject: [PATCH 01/12] staging/lustre/ldlm: Delete unnecessary checks before the function call "kset_unregister" To: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org, Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <56784D83.7080108@users.sourceforge.net> <56784F0C.6040007@users.sourceforge.net> <20151221234857.GA27079@kroah.com> <59d94e70-7476-728e-5f63-013557ec2db9@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Bhumika Goyal From: SF Markus Elfring Message-ID: Date: Tue, 26 Jul 2016 20:56:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <59d94e70-7476-728e-5f63-013557ec2db9@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:sd8IkODSzipdz9ClA1qf6JEx+2izGq+bqWPLWbq49TL1LjOnmHe y2t6XJVowcjDp9PaTY78sp1aS5QkM1GMHJmrJW0zTXJ3aEUik6GzzY8ur2zqEdkDAHX44QD 3vFTaAkEkksNTV2VZZ4rnXbc9zyF3KPehsyCTwYAahpqJ0Fi6JQ2S0WQQdJpdF9xlAjLZGW ht+AZnquvZpLKQ1ckDP8g== X-UI-Out-Filterresults: notjunk:1;V01:K0:CCjb9zJDd6w=:99fYe+inziEWmtN/NP5Fqc e02BR/49UykiAOkOJ+pG2FxwVakNYI4cC6u0MW7kwDYuhRPRwD+5jYGNJoDuanWwYuYu0cBA+ 8QHHT+yxskqtUizGmIkvH/gwTk795KynTgZYM76XAgDtqq2cbk76BwX2R1XloNd4b3oC3Mj56 jXwa6FFooeWjn5k0e8eQZW6OfiEqjWGzdkzYX0LPEkwx7ynM4l0wxPEiV9DqBA3SIwFu4EBkd XngdK9boQuFhFZncVIg+OLl7eWOw40KGCLEMmN0jvW5QgrIYqfRfcPa/rWAiCbfkLlgvmfIce 5cr0LQHMEmdKIrFJL8H9CJ97nH2aFe8VGSHfrv2R19FhPDewfx/jMhtJYCl0i6LpfDn7HiyMK MwkIiahuGprQXylaK2u7G+8Z3c1PvGxp8M1z8nTzE8KKW+bXjvmR4MvyUyPjokIUiICf9Kyzu vCfTt7ImZyfgcUOt7Ad/ocW6K0X0UnVCBEDZ1iedvy395bXifRDOsps8NYpBIVxmTRBlRxOPk s6mZekZlt6wCO17IM3TKnGnfeY9v/HvQEaiD2/6k3+zMmid6iVn36ajLNZ9rFoaNNAFrCyKkk OAq6Qj2f1KSdqMwkOvut5gJauLA7vX7qx+6SIL1cFYCxKiEmf7FY5KGM9J+U1QCSyAmwyZwlh TBRsmItxyjxwhfzOLkXG5gaQ8Ka0Is9p7Yz26ppxolLCdtqRbiF8K3H1WftWXRRRtuxHePxuD oWdfqpooJj01/jiuvmjjq/mn4Bf9vuV584IqMPdNTFPE91LbRzAqKEKnNavCHFMaBrcStx/ig gAK5dMm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 26 Jul 2016 11:33:43 +0200 The kset_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c index 821939f..2c1c2fc 100644 --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c @@ -1067,10 +1067,8 @@ static int ldlm_cleanup(void) if (ldlm_state->ldlm_cb_service) ptlrpc_unregister_service(ldlm_state->ldlm_cb_service); - if (ldlm_ns_kset) - kset_unregister(ldlm_ns_kset); - if (ldlm_svc_kset) - kset_unregister(ldlm_svc_kset); + kset_unregister(ldlm_ns_kset); + kset_unregister(ldlm_svc_kset); if (ldlm_kobj) kobject_put(ldlm_kobj); -- 2.9.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 26 Jul 2016 18:56:43 +0000 Subject: [PATCH 01/12] staging/lustre/ldlm: Delete unnecessary checks before the function call "kset_unregist Message-Id: List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <56784D83.7080108@users.sourceforge.net> <56784F0C.6040007@users.sourceforge.net> <20151221234857.GA27079@kroah.com> <59d94e70-7476-728e-5f63-013557ec2db9@users.sourceforge.net> In-Reply-To: <59d94e70-7476-728e-5f63-013557ec2db9@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org, Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Bhumika Goyal From: Markus Elfring Date: Tue, 26 Jul 2016 11:33:43 +0200 The kset_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c index 821939f..2c1c2fc 100644 --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c @@ -1067,10 +1067,8 @@ static int ldlm_cleanup(void) if (ldlm_state->ldlm_cb_service) ptlrpc_unregister_service(ldlm_state->ldlm_cb_service); - if (ldlm_ns_kset) - kset_unregister(ldlm_ns_kset); - if (ldlm_svc_kset) - kset_unregister(ldlm_svc_kset); + kset_unregister(ldlm_ns_kset); + kset_unregister(ldlm_svc_kset); if (ldlm_kobj) kobject_put(ldlm_kobj); -- 2.9.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 26 Jul 2016 20:56:43 +0200 Subject: [lustre-devel] [PATCH 01/12] staging/lustre/ldlm: Delete unnecessary checks before the function call "kset_unregister" In-Reply-To: <59d94e70-7476-728e-5f63-013557ec2db9@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <56784D83.7080108@users.sourceforge.net> <56784F0C.6040007@users.sourceforge.net> <20151221234857.GA27079@kroah.com> <59d94e70-7476-728e-5f63-013557ec2db9@users.sourceforge.net> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org, Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Bhumika Goyal From: Markus Elfring Date: Tue, 26 Jul 2016 11:33:43 +0200 The kset_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c index 821939f..2c1c2fc 100644 --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c @@ -1067,10 +1067,8 @@ static int ldlm_cleanup(void) if (ldlm_state->ldlm_cb_service) ptlrpc_unregister_service(ldlm_state->ldlm_cb_service); - if (ldlm_ns_kset) - kset_unregister(ldlm_ns_kset); - if (ldlm_svc_kset) - kset_unregister(ldlm_svc_kset); + kset_unregister(ldlm_ns_kset); + kset_unregister(ldlm_svc_kset); if (ldlm_kobj) kobject_put(ldlm_kobj); -- 2.9.2