From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/5] drm/prime: make the pages array optional for drm_prime_sg_to_page_addr_arrays Date: Tue, 6 Mar 2018 10:25:03 +0100 Message-ID: References: <20180227115000.4105-1-christian.koenig@amd.com> <20180227115000.4105-2-christian.koenig@amd.com> <20180306092102.GM22212@phenom.ffwll.local> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180306092102.GM22212-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Daniel Vetter Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org QW0gMDYuMDMuMjAxOCB1bSAxMDoyMSBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gT24gVHVlLCBG ZWIgMjcsIDIwMTggYXQgMTI6NDk6NTdQTSArMDEwMCwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToK Pj4gTW9zdCBvZiB0aGUgdGltZSB3ZSBvbmx5IG5lZWQgdGhlIGRtYSBhZGRyZXNzZXMuCj4+Cj4+ IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNv bT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jIHwgMjAgKysrKysrKysr Ky0tLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTAgZGVs ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPj4gaW5kZXggYzM4ZGFjZGE2MTE5Li43ODU2 YTliM2Y4YTggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPj4gQEAgLTkyMiw0MCArOTIyLDQwIEBA IEVYUE9SVF9TWU1CT0woZHJtX3ByaW1lX3BhZ2VzX3RvX3NnKTsKPj4gICAvKioKPj4gICAgKiBk cm1fcHJpbWVfc2dfdG9fcGFnZV9hZGRyX2FycmF5cyAtIGNvbnZlcnQgYW4gc2cgdGFibGUgaW50 byBhIHBhZ2UgYXJyYXkKPj4gICAgKiBAc2d0OiBzY2F0dGVyLWdhdGhlciB0YWJsZSB0byBjb252 ZXJ0Cj4+IC0gKiBAcGFnZXM6IGFycmF5IG9mIHBhZ2UgcG9pbnRlcnMgdG8gc3RvcmUgdGhlIHBh Z2UgYXJyYXkgaW4KPj4gKyAqIEBwYWdlczogb3B0aW9uYWwgYXJyYXkgb2YgcGFnZSBwb2ludGVy cyB0byBzdG9yZSB0aGUgcGFnZSBhcnJheSBpbgo+PiAgICAqIEBhZGRyczogb3B0aW9uYWwgYXJy YXkgdG8gc3RvcmUgdGhlIGRtYSBidXMgYWRkcmVzcyBvZiBlYWNoIHBhZ2UKPj4gLSAqIEBtYXhf cGFnZXM6IHNpemUgb2YgYm90aCB0aGUgcGFzc2VkLWluIGFycmF5cwo+PiArICogQG1heF9lbnRy aWVzOiBzaXplIG9mIGJvdGggdGhlIHBhc3NlZC1pbiBhcnJheXMKPj4gICAgKgo+PiAgICAqIEV4 cG9ydHMgYW4gc2cgdGFibGUgaW50byBhbiBhcnJheSBvZiBwYWdlcyBhbmQgYWRkcmVzc2VzLiBU aGlzIGlzIGN1cnJlbnRseQo+PiAgICAqIHJlcXVpcmVkIGJ5IHRoZSBUVE0gZHJpdmVyIGluIG9y ZGVyIHRvIGRvIGNvcnJlY3QgZmF1bHQgaGFuZGxpbmcuCj4+ICAgICovCj4gQ2FuJ3Qgd2UganVz dCB0ZWFjaCB0dG0gdG8gdXNlIHNndHMgd2hlcmV2ZXIgbmVlZGVkLCBhbmQgZGVwcmVjYXRlCj4g ZXhwb3J0aW5nIGRtYS1idWZzIHRvIHBhZ2UgYXJyYXlzICh3aGljaCByZWFsbHkgYnJlYWtzIHRo ZSBhYnN0cmFjdGlvbgo+IGVudGlyZWx5IGFuZCB3YXMganVzdCBhIHF1aWNrIGhhY2sgdG8gZ2V0 IHRoaW5ncyBnb2luZyB0aGF0IHN0dWNrIGFyb3VuZAo+IGZvciB5ZWFycykuIExhc3QgdGltZSBJ IGxvb2tlZCBpbnRvIHR0bSB0aGUgb25seSB0aGluZyBpdCBkaWQgaXMgY29udmVydAo+IGl0IGJh Y2sgdG8gc2d0cyBhZ2FpbiAoYWZ0ZXIgY2FsbGluZyBkbWFfbWFwIG9uY2UgbW9yZSwgd2hpY2gg dGhlIGV4cG9ydGVyCj4gc2hvdWxkIGhhdmUgZG9uZSBhbHJlYWR5IGZvciB5b3UpLgoKVGhvdWdo dCBhYm91dCB0aGF0IGFzIHdlbGwsIGJ1dCB0aGUgcHJvYmxlbSBoZXJlIGlzbid0IFRUTS4KCldl IG5lZWQgdG8gYmUgYWJsZSB0byBhY2Nlc3MgdGhlIFNHVCBieSBhbiBpbmRleCBpbiBhbWRncHUg dG8gYmUgYWJsZSB0byAKYnVpbGQgdXAgdGhlIFZNIHBhZ2UgdGFibGVzIGFuZCB0aGF0IGlzIG5v dCBwb3NzaWJsZSBiZWNhdXNlIHRoZSBTR1QgaXMgCnBvdGVudGlhbGx5IGNoYWluZWQuCgpXZSBj b3VsZCBhZGQgYSBuZXcgc2dfdGFibGUgYWNjZXNzIGhlbHBlciBmdW5jdGlvbiB0byB3b3JrIGFy b3VuZCB0aGF0IAp0aG91Z2h0LgoKQlRXOiBUVE0gaXNuJ3QgbWFwcGluZyBhbnl0aGluZyBpbiB0 aGF0IGNhc2UsIHdlIGp1c3QgZmlsbCBpbiB0aGUgYXJyYXlzIApmcm9tIHRoZSBTR1QuCgpDaHJp c3RpYW4uCgo+IC1EYW5pZWwKPgo+PiAgIGludCBkcm1fcHJpbWVfc2dfdG9fcGFnZV9hZGRyX2Fy cmF5cyhzdHJ1Y3Qgc2dfdGFibGUgKnNndCwgc3RydWN0IHBhZ2UgKipwYWdlcywKPj4gLQkJCQkg ICAgIGRtYV9hZGRyX3QgKmFkZHJzLCBpbnQgbWF4X3BhZ2VzKQo+PiArCQkJCSAgICAgZG1hX2Fk ZHJfdCAqYWRkcnMsIGludCBtYXhfZW50cmllcykKPj4gICB7Cj4+ICAgCXVuc2lnbmVkIGNvdW50 Owo+PiAgIAlzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnOwo+PiAgIAlzdHJ1Y3QgcGFnZSAqcGFnZTsK Pj4gLQl1MzIgbGVuOwo+PiAtCWludCBwZ19pbmRleDsKPj4gKwl1MzIgbGVuLCBpbmRleDsKPj4g ICAJZG1hX2FkZHJfdCBhZGRyOwo+PiAgIAo+PiAtCXBnX2luZGV4ID0gMDsKPj4gKwlpbmRleCA9 IDA7Cj4+ICAgCWZvcl9lYWNoX3NnKHNndC0+c2dsLCBzZywgc2d0LT5uZW50cywgY291bnQpIHsK Pj4gICAJCWxlbiA9IHNnLT5sZW5ndGg7Cj4+ICAgCQlwYWdlID0gc2dfcGFnZShzZyk7Cj4+ICAg CQlhZGRyID0gc2dfZG1hX2FkZHJlc3Moc2cpOwo+PiAgIAo+PiAgIAkJd2hpbGUgKGxlbiA+IDAp IHsKPj4gLQkJCWlmIChXQVJOX09OKHBnX2luZGV4ID49IG1heF9wYWdlcykpCj4+ICsJCQlpZiAo V0FSTl9PTihpbmRleCA+PSBtYXhfZW50cmllcykpCj4+ICAgCQkJCXJldHVybiAtMTsKPj4gLQkJ CXBhZ2VzW3BnX2luZGV4XSA9IHBhZ2U7Cj4+ICsJCQlpZiAocGFnZXMpCj4+ICsJCQkJcGFnZXNb aW5kZXhdID0gcGFnZTsKPj4gICAJCQlpZiAoYWRkcnMpCj4+IC0JCQkJYWRkcnNbcGdfaW5kZXhd ID0gYWRkcjsKPj4gKwkJCQlhZGRyc1tpbmRleF0gPSBhZGRyOwo+PiAgIAo+PiAgIAkJCXBhZ2Ur KzsKPj4gICAJCQlhZGRyICs9IFBBR0VfU0laRTsKPj4gICAJCQlsZW4gLT0gUEFHRV9TSVpFOwo+ PiAtCQkJcGdfaW5kZXgrKzsKPj4gKwkJCWluZGV4Kys7Cj4+ICAgCQl9Cj4+ICAgCX0KPj4gICAJ cmV0dXJuIDA7Cj4+IC0tIAo+PiAyLjE0LjEKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+PiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngK