From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F0BAC7EE24 for ; Mon, 5 Jun 2023 19:25:46 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.543886.849235 (Exim 4.92) (envelope-from ) id 1q6FpW-00065N-DS; Mon, 05 Jun 2023 19:25:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 543886.849235; Mon, 05 Jun 2023 19:25:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q6FpW-00065G-9L; Mon, 05 Jun 2023 19:25:26 +0000 Received: by outflank-mailman (input) for mailman id 543886; Mon, 05 Jun 2023 19:25:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q6FpV-00065A-Me for xen-devel@lists.xenproject.org; Mon, 05 Jun 2023 19:25:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q6FpV-00041L-DJ; Mon, 05 Jun 2023 19:25:25 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1q6FpV-0001Di-8d; Mon, 05 Jun 2023 19:25:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9NroE4j9cL2ErGWO95oWCCU47E5xsrm19qrYddMsEE8=; b=UPve7CzbaKyw/zrnoOip+IfVuw 9lBiyuiGQPPzKT0A+bG/WnD/RaIGedJt1nz2z7kSZsqvv4dZtv4u4U0UohSAXuCsR/BlecJ9Vrfei RyMA0WVU5IHExNpvNMtm2ufN7G+5xr1W1ooHWQUCbH6aljz+vJC3b4fvbzEr/cMnFxfQ=; Message-ID: Date: Mon, 5 Jun 2023 20:25:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN][PATCH v7 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, sstabellini@kernel.org, jbeulich@suse.com References: <20230602004824.20731-1-vikram.garhwal@amd.com> <20230602004824.20731-11-vikram.garhwal@amd.com> From: Julien Grall In-Reply-To: <20230602004824.20731-11-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: > Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access add. The commit message is a bit light. What sort of concurrent access add are you talking about? Is it of the same node? Different node? Also, is it a existing issue or something that will become one with a follow-up patch in your series? Cheers, -- Julien Grall