From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE793C4338F for ; Mon, 2 Aug 2021 06:35:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28F2161050 for ; Mon, 2 Aug 2021 06:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 28F2161050 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 65A7082BDC; Mon, 2 Aug 2021 08:35:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1627886121; bh=kx4zL4dExW9gQy4r7Oevc2o8B4CLciFjdZgABH1EX5U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AZMLTsz6R+5jjfBGIhatvo3tIt952ZDAQgE+cuc7w0l0N1ivccNUL5UasBqE6aNPY NCGxflauJrFAxYWRYA0My4sFbDHU7kaCSn1c8KecMmQw4DAJw49qM36ifgG5LboMEv YCFZoJXCyNhIXwgMRJ3kABo2YZQY+k3KtSlICGgvorHS77V4CVzEG1rSlmpscnrS8g gkyW+g7Mh3eSAmVIQc3t3l4E6w3LdZ/bqUbPg431eAgsleD7qnAKsAq/9WBWfun1/0 QMi4JtQXhZT1f2uLQA4w9M3B1IKzIvB7EAiqmmezLneyLA29krJuLsfmsn3ZlFOMo0 fMXJIGUBgmV9Q== Received: by phobos.denx.de (Postfix, from userid 109) id 9AFDB82BDC; Mon, 2 Aug 2021 08:35:19 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [IPv6:2001:67c:2050:1::465:107]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B3C2F82003 for ; Mon, 2 Aug 2021 08:35:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4GdStD3VCQzQk9j; Mon, 2 Aug 2021 08:35:16 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id rQB1QeJ1k8u3; Mon, 2 Aug 2021 08:35:13 +0200 (CEST) Subject: Re: [PATCH 4/5] arm: mvebu: axp: Set CONFIG_SYS_TCLK globally To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Chris Packham , Baruch Siach , Dirk Eibach , u-boot@lists.denx.de Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , Dennis Gilmore , Mario Six , Jon Nettleton References: <20210731122256.6546-1-pali@kernel.org> <20210731122256.6546-5-pali@kernel.org> From: Stefan Roese Message-ID: Date: Mon, 2 Aug 2021 08:35:12 +0200 MIME-Version: 1.0 In-Reply-To: <20210731122256.6546-5-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 89EE6184F X-Rspamd-UID: fbea96 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 31.07.21 14:22, Pali Rohár wrote: > This mvebu axp platform always uses fixed 250 MHz TCLK. So specify this > CONFIG_SYS_TCLK option in msys section of global file soc.h file instead of > manual configuration in every board file. > > Now every #if-#else case of soc.h file defines CONFIG_SYS_TCLK, so remove > useless default CONFIG_SYS_TCLK value from the end of soc.h file. > > Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/arm/mach-mvebu/include/mach/soc.h | 3 --- > include/configs/db-mv784mp-gp.h | 1 - > include/configs/ds414.h | 1 - > include/configs/maxbcm.h | 1 - > include/configs/theadorable.h | 1 - > 5 files changed, 7 deletions(-) > > diff --git a/arch/arm/mach-mvebu/include/mach/soc.h b/arch/arm/mach-mvebu/include/mach/soc.h > index e29c0f32c3de..8e8a4058550e 100644 > --- a/arch/arm/mach-mvebu/include/mach/soc.h > +++ b/arch/arm/mach-mvebu/include/mach/soc.h > @@ -208,10 +208,7 @@ > > #define BOOT_FROM_UART 0x2 > #define BOOT_FROM_SPI 0x3 > -#endif > > -/* TCLK Core Clock definition */ > -#ifndef CONFIG_SYS_TCLK > #define CONFIG_SYS_TCLK 250000000 /* 250MHz */ > #endif > > diff --git a/include/configs/db-mv784mp-gp.h b/include/configs/db-mv784mp-gp.h > index ef7eebd081f9..f1b79e8a1fb8 100644 > --- a/include/configs/db-mv784mp-gp.h > +++ b/include/configs/db-mv784mp-gp.h > @@ -16,7 +16,6 @@ > * for DDR ECC byte filling in the SPL before loading the main > * U-Boot into it. > */ > -#define CONFIG_SYS_TCLK 250000000 /* 250MHz */ > > /* I2C */ > #define CONFIG_SYS_I2C > diff --git a/include/configs/ds414.h b/include/configs/ds414.h > index 4bbb244fa227..9fe830965854 100644 > --- a/include/configs/ds414.h > +++ b/include/configs/ds414.h > @@ -18,7 +18,6 @@ > * for DDR ECC byte filling in the SPL before loading the main > * U-Boot into it. > */ > -#define CONFIG_SYS_TCLK 250000000 /* 250MHz */ > > /* I2C */ > #define CONFIG_SYS_I2C > diff --git a/include/configs/maxbcm.h b/include/configs/maxbcm.h > index 0c2185c529f7..a8cffcb82d43 100644 > --- a/include/configs/maxbcm.h > +++ b/include/configs/maxbcm.h > @@ -15,7 +15,6 @@ > * for DDR ECC byte filling in the SPL before loading the main > * U-Boot into it. > */ > -#define CONFIG_SYS_TCLK 250000000 /* 250MHz */ > > /* I2C */ > #define CONFIG_SYS_I2C > diff --git a/include/configs/theadorable.h b/include/configs/theadorable.h > index 31852fb24801..54e60a4094f8 100644 > --- a/include/configs/theadorable.h > +++ b/include/configs/theadorable.h > @@ -15,7 +15,6 @@ > * for DDR ECC byte filling in the SPL before loading the main > * U-Boot into it. > */ > -#define CONFIG_SYS_TCLK 250000000 /* 250MHz */ > > /* > * The debugging version enables USB support via defconfig. > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de