From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 052FDC433EF for ; Fri, 21 Jan 2022 16:03:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D3F08828FD; Fri, 21 Jan 2022 17:03:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="UQjbGiXg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B64682F5E; Fri, 21 Jan 2022 17:03:11 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B42481B53 for ; Fri, 21 Jan 2022 17:03:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 86B763F1DD for ; Fri, 21 Jan 2022 16:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642780985; bh=e9/JbEPMqkOh+9yHMn8RRwlb6B45zRRoxJMzRt0pF9M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UQjbGiXg05wmWXjJAiTgUId4IIaPZoccambByEg++8QLd1j7OyC4WRoDnuPuchlz8 xw0M8QSFO5ogIs2MdunIq3YPMFXE5Pc9O1VMjob43LC+rsGydbyB2dXqjlIpyAwoiF ue4X4GFrPczYxNTYRzwTQrbKICWT2o2N6jZw8LywIeC6V9LEjbMZOklxdIwMto/hRt GNgOvApDRAph4kxDOBiEhZpzfa0GjWkfxCV+eiNXC63Dp64tV+9pgDazHz4YDQW1xm e7sp4A7SoAR5pHbZp99kCE5cWG7cUl8i6zfHn9QS8Y0oVQhTKp4HqbjIYU0Ocltev6 YB+id+fGKCEFg== Received: by mail-wr1-f69.google.com with SMTP id t13-20020adfa2cd000000b001d09443ee4fso67890wra.3 for ; Fri, 21 Jan 2022 08:03:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=e9/JbEPMqkOh+9yHMn8RRwlb6B45zRRoxJMzRt0pF9M=; b=2l9PySou4eojFksLQId5vTYnlbtuo+rWzkF3WRO9ye0JjOkV/Kcxdn+fm3LHw0jJDE oz9I7ayLFXPBRHtBwDk6M7Txg45jOOZw2J9umrNoqsz/AWKn46XZtA/hsnQougKWs5LE qD/r3M92xlYKq7iw5gCrWFZLG505aTQ4cL82rJPyjnEPP/Tp6YNUbYVYL6A0wWmY3bk+ Vrx8AZdIiRMLJmheXNsfza6xlRNrihr8e7P9tU/vSQI8OowqQSQVgbizgENp/IX14qzq NJVgeJXLgpIi2kJ+TE5rksQQusfxe3yBchl2pwdQuF014+g7q2fwU+vWnj1mSE7Kk45T +Z+g== X-Gm-Message-State: AOAM531JW/4C2+G1vV8PrfYfTu349WfR7RzzeuG7FEX+GyoLXTXrwsy5 BU4ToIXzwgJ/0KQaYdnsU+FaVEiTm+w9aCrnPxbhDB5ANpElcoBR9/lBhssMVHvwCyWWsU5d/kb sMf4Z77bQ/aZqva05Oks+Y/q7UqkuUIE= X-Received: by 2002:a05:600c:4b95:: with SMTP id e21mr1305875wmp.106.1642780985217; Fri, 21 Jan 2022 08:03:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxxSyjk3s7pOUCW1wyhB2L0Uod+jJnk2jZBzwXgiuP1yzH0zyT40bpbehHVUs3CVgLwNCHhTA== X-Received: by 2002:a05:600c:4b95:: with SMTP id e21mr1305856wmp.106.1642780985021; Fri, 21 Jan 2022 08:03:05 -0800 (PST) Received: from [192.168.123.55] (ip-088-152-144-107.um26.pools.vodafone-ip.de. [88.152.144.107]) by smtp.gmail.com with ESMTPSA id d6sm5945436wrs.85.2022.01.21.08.03.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jan 2022 08:03:04 -0800 (PST) Message-ID: Date: Fri, 21 Jan 2022 17:03:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs Content-Language: en-US To: Simon Glass Cc: Tom Rini , Rasmus Villemoes , Patrick Delaunay , U-Boot Mailing List References: <20220116151441.219566-1-heinrich.schuchardt@canonical.com> <20220116151441.219566-7-heinrich.schuchardt@canonical.com> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/21/22 16:20, Simon Glass wrote: > Hi Heinrich, > > On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt > wrote: >> >> Use "%pS" to print text representations of GUIDs. >> >> Signed-off-by: Heinrich Schuchardt >> --- >> cmd/efidebug.c | 160 ++--------------------------------------- >> include/efi_api.h | 8 +++ >> include/efi_dt_fixup.h | 4 -- >> include/efi_rng.h | 4 -- >> lib/uuid.c | 116 ++++++++++++++++++++++++++++++ >> 5 files changed, 128 insertions(+), 164 deletions(-) >> > > Does this blow up the image size? These strings only in the debug side before. It was to avoid image size increase that I added +#ifdef CONFIG_CMD_EFIDEBUG > > Having said that, I would much rather see a string than a guid, which > I consider to be little more than an obfuscation. That was my motivation. When debugging a boot failure I set DEBUG in lib/efi_loader/efi_boottime.c and reading GUIDs in the debug output was not helpful. Best regards Heinrich > > Regards, > Simon