From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD20C43334 for ; Wed, 6 Jul 2022 12:48:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233465AbiGFMsq (ORCPT ); Wed, 6 Jul 2022 08:48:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbiGFMsp (ORCPT ); Wed, 6 Jul 2022 08:48:45 -0400 Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [5.144.164.166]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D0F1A458 for ; Wed, 6 Jul 2022 05:48:44 -0700 (PDT) Received: from [192.168.1.101] (abxi46.neoplus.adsl.tpnet.pl [83.9.2.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 31B7A3F4EA; Wed, 6 Jul 2022 14:48:43 +0200 (CEST) Message-ID: Date: Wed, 6 Jul 2022 14:48:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 02/13] ARM: dts: qcom: add gsbi6 missing definition for ipq8064 Content-Language: en-US To: Christian Marangi , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan McDowell References: <20220705133917.8405-1-ansuelsmth@gmail.com> <20220705133917.8405-3-ansuelsmth@gmail.com> From: Konrad Dybcio In-Reply-To: <20220705133917.8405-3-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5.07.2022 15:39, Christian Marangi wrote: > Add gsbi6 missing definition for ipq8064. > > Signed-off-by: Christian Marangi > Tested-by: Jonathan McDowell > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 40 +++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index f06a17bd915a..1b4b72723ead 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -665,6 +665,46 @@ spi@1a280000 { > }; > }; > > + gsbi6: gsbi@16500000 { > + status = "disabled" Please make the compatible first, reg 2nd and move status to the bottom. Konrad > + compatible = "qcom,gsbi-v1.0.0"; > + cell-index = <6>; > + reg = <0x16500000 0x100>; > + clocks = <&gcc GSBI6_H_CLK>; > + clock-names = "iface"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + syscon-tcsr = <&tcsr>; > + > + gsbi6_i2c: i2c@16580000 { > + compatible = "qcom,i2c-qup-v1.1.1"; > + reg = <0x16580000 0x1000>; > + interrupts = ; > + > + clocks = <&gcc GSBI6_QUP_CLK>, <&gcc GSBI6_H_CLK>; > + clock-names = "core", "iface"; > + status = "disabled"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + gsbi6_spi: spi@16580000 { > + compatible = "qcom,spi-qup-v1.1.1"; > + reg = <0x16580000 0x1000>; > + interrupts = ; > + > + clocks = <&gcc GSBI6_QUP_CLK>, <&gcc GSBI6_H_CLK>; > + clock-names = "core", "iface"; > + status = "disabled"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + > gsbi7: gsbi@16600000 { > status = "disabled"; > compatible = "qcom,gsbi-v1.0.0";