All of lore.kernel.org
 help / color / mirror / Atom feed
From: наб <nabijaczleweli@nabijaczleweli.xyz>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: linux-man@vger.kernel.org
Subject: [PATCH 3/3] tee.2: always fail after perror(), use for(;;) instead of do{}while(1)
Date: Mon, 3 Jan 2022 16:34:07 +0100	[thread overview]
Message-ID: <c68f0d3beba927e3417807201c335d7449fc18b2.1641224016.git.nabijaczleweli@nabijaczleweli.xyz> (raw)
In-Reply-To: <a59610f1d397bf532e4ce46481f439ac089fb05e.1641224016.git.nabijaczleweli@nabijaczleweli.xyz>

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

---
 man2/tee.2 | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/man2/tee.2 b/man2/tee.2
index 17b93882d..4b410ecad 100644
--- a/man2/tee.2
+++ b/man2/tee.2
@@ -171,10 +171,10 @@ main(int argc, char *argv[])
     int fd = open(argv[1], O_WRONLY | O_CREAT | O_TRUNC, 0644);
     if (fd == \-1) {
         perror("open");
-        exit(EXIT_FAILURE);
+        return EXIT_FAILURE;
     }
 
-    do {
+    for (;;) {
         /*
          * tee stdin to stdout.
          */
@@ -184,7 +184,7 @@ main(int argc, char *argv[])
             if (errno == EAGAIN)
                 continue;
             perror("tee");
-            exit(EXIT_FAILURE);
+            return EXIT_FAILURE;
         } else
             if (len == 0)
                 break;
@@ -197,14 +197,13 @@ main(int argc, char *argv[])
                                   len, SPLICE_F_MOVE);
             if (slen < 0) {
                 perror("splice");
-                break;
+                return EXIT_FAILURE;
             }
             len \-= slen;
         }
-    } while (1);
+    }
 
     close(fd);
-    exit(EXIT_SUCCESS);
 }
 .EE
 .SH SEE ALSO
-- 
2.30.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-01-03 15:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 15:33 [PATCH 1/3] tee.2: ffix наб
2022-01-03 15:34 ` [PATCH 2/3] tee.2: use proper types in example, declare variables at point-of-use наб
2022-01-03 16:25   ` Alejandro Colomar (man-pages)
2022-01-03 15:34 ` наб [this message]
2022-01-03 16:40   ` [PATCH 3/3] tee.2: always fail after perror(), use for(;;) instead of do{}while(1) Alejandro Colomar (man-pages)
2022-01-03 17:03     ` [PATCH v2 2/4] tee.2: use proper types in example наб
2022-01-03 17:27       ` Alejandro Colomar (man-pages)
2022-01-03 17:35         ` наб
2022-01-03 17:51           ` Alejandro Colomar (man-pages)
2022-01-03 17:03     ` [PATCH v2 3/4] tee.2: use for(;;) instead of do{}while(1) наб
2022-01-03 17:03     ` [PATCH v2 4/4] tee.2: always fail after perror() in example наб
2022-01-03 16:49 ` [PATCH 1/3] tee.2: ffix Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c68f0d3beba927e3417807201c335d7449fc18b2.1641224016.git.nabijaczleweli@nabijaczleweli.xyz \
    --to=nabijaczleweli@nabijaczleweli.xyz \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.