From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9056AC433FE for ; Tue, 21 Sep 2021 10:29:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B4BA6109E for ; Tue, 21 Sep 2021 10:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232005AbhIUKau (ORCPT ); Tue, 21 Sep 2021 06:30:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48971 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231887AbhIUKao (ORCPT ); Tue, 21 Sep 2021 06:30:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632220155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ttx288q8wLdtdWWF2QymL+a9cWj2Gh8ncjXNg61K68k=; b=IjYXTa6qCeu/yXwoEs0Y/hpjn8z6yqrFvhWgfnuciX+tFfBZHsOBEOd4lIVJes+bGxROph IxPKgFBRTW/SqX+pwQ6Kl23ytAB40GDkBZdibjV1vreafEbgXnbhhZOXckkEKvkT/RhW5G l8quCGw5t1JcGqi+nCizz6OMMO7o3O0= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-N1re69ZkMMOD8FStv2bs7g-1; Tue, 21 Sep 2021 06:29:05 -0400 X-MC-Unique: N1re69ZkMMOD8FStv2bs7g-1 Received: by mail-ed1-f70.google.com with SMTP id h24-20020a50cdd8000000b003d8005fe2f8so14482783edj.6 for ; Tue, 21 Sep 2021 03:29:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ttx288q8wLdtdWWF2QymL+a9cWj2Gh8ncjXNg61K68k=; b=EY9ushxL+V5XaI44HH8zZUd+el6yvBH7ZP/mpeqRXKEszAUT8lnSY4nC7yMB3hkPK8 0TC6GK/MzLPVARBByTen8GEbKsd5oQ/g7q7LBV5EXWik7w5PHdWxeIZbiFRAJtDDBQlV MRFaE1GCdQYFjG/58u+EKJqIrpNT9GVHIbFm3u///k4YWH6USnBj5KEYDDbqP6iDKZ8K 1KzrV2EGFE5qKbaL8GJ9++I3CjhPUPObBVjlJCvlcWTfMGV1BHEqUUmcqZBBhxjCVoaF 0RvJK3d7Lh29vhiK9vIDNcmokP2m1OLm0qib5BNHiGhH9YG765ojAx472Yw/38s2higK PDxA== X-Gm-Message-State: AOAM532AAsqV+JbcFw7E/jfMFy/rfcAnExQbYIBiNl0B3TGSUvbx7G+O nMgvUHb0fXgI47oJjHXLiXY+RW8ijg+etbz0I6qyLpppeU3F2aPxEchbJ+1MvmZKIt6bcVhWf79 DBeyZ7h3a/XBCXyyo2HYNARIx X-Received: by 2002:a05:6402:5163:: with SMTP id d3mr35269256ede.220.1632220143988; Tue, 21 Sep 2021 03:29:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgLRBigh5K8LJJ+14RCQJFiDpnbVVX0GBmEXBh2FC2cpkj99qZcgWH+kGe4mNA5vY3sW0rrw== X-Received: by 2002:a05:6402:5163:: with SMTP id d3mr35269235ede.220.1632220143834; Tue, 21 Sep 2021 03:29:03 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id i6sm7182873ejd.57.2021.09.21.03.29.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 03:29:03 -0700 (PDT) Subject: Re: [PATCH 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE_ALL ioctl To: Dave Hansen , Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, jarkko@kernel.org, dave.hansen@linux.intel.com, yang.zhong@intel.com References: <20210920125401.2389105-1-pbonzini@redhat.com> <20210920125401.2389105-3-pbonzini@redhat.com> <20210921101702.8672a0f1e356289e21864a76@intel.com> <4db02f44-fec0-b78e-b9ae-0aa41ac7819f@intel.com> From: Paolo Bonzini Message-ID: Date: Tue, 21 Sep 2021 12:29:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <4db02f44-fec0-b78e-b9ae-0aa41ac7819f@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/21 01:09, Dave Hansen wrote: >> Maybe also worth to mention userspace should guarantee there's no vcpu running >> inside guest enclave when resetting guest's virtual EPC. > Why, specifically? > > Is it because EREMOVE will also fail if there is a CPU running in the > enclave? Yes, and SGX_ENCLAVE_ACT would cause a WARN. Good catch, Kai, I'll fix it. Paolo