All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"George Dunlap" <George.Dunlap@eu.citrix.com>,
	IanJackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xenproject.org,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 1/2] xen: add config option to include failing condition in BUG_ON() message
Date: Fri, 17 Jan 2020 09:53:22 +0100	[thread overview]
Message-ID: <c69fd26d-15f8-6dc7-b86b-b2add6b133af@suse.com> (raw)
In-Reply-To: <3be7b516-26f0-080a-f683-f9e0fe99e0ea@suse.com>

On 17.01.20 09:39, Jan Beulich wrote:
> On 16.01.2020 19:54, Andrew Cooper wrote:
>> On 14/01/2020 16:12, Jan Beulich wrote:
>>> On 14.01.2020 17:00, Jürgen Groß wrote:
>>>> On 14.01.20 16:47, Jan Beulich wrote:
>>>>> On 09.01.2020 14:48, Juergen Gross wrote:
>>>>>> --- a/xen/Kconfig.debug
>>>>>> +++ b/xen/Kconfig.debug
>>>>>> @@ -81,6 +81,12 @@ config PERF_ARRAYS
>>>>>>    	---help---
>>>>>>    	  Enables software performance counter array histograms.
>>>>>>    
>>>>>> +config DEBUG_BUGVERBOSE
>>>>>> +	bool "Verbose BUG_ON messages"
>>>>>> +	default DEBUG
>>>>>> +	---help---
>>>>>> +	  In case a BUG_ON triggers additionally print the triggering
>>>>>> +	  condition on the console.
>>>>>>    
>>>>>>    config VERBOSE_DEBUG
>>>>> While I can see reasons to put this here, doing so means the option
>>>>> will be unavailable in non-EXPERT release builds. Is it intended to
>>>>> be that way?
>>>> I can move it either to xen/Kconfig or in Kconfig.debug out of the
>>>> "if expert" section if you want.
>>> I think this would be better, but give others a chance to voice
>>> opinions.
>>
>> TBH, I don't think anyone will be interested in not having the strings.
>> The change is what? a couple of hundred bytes?  That is a fraction of
>> the size of some functions we have.
> 
> Well, it's a couple thousand (about 7k according to my simplistic
> estimation, but this is taking Arm and x86 together). It's not the
> end of the world, but in particular embedded users may want to get
> rid of this. There's a reason after all (I assume) that Linux has
> the option.

The needed code churn is rather limited, so I think we should keep the
config option.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2020-01-17  8:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 13:48 [Xen-devel] [PATCH v2 0/2] xen: fix CONFIG_DEBUG_LOCKS Juergen Gross
2020-01-09 13:48 ` [Xen-devel] [PATCH v2 1/2] xen: add config option to include failing condition in BUG_ON() message Juergen Gross
2020-01-14 15:47   ` Jan Beulich
2020-01-14 16:00     ` Jürgen Groß
2020-01-14 16:12       ` Jan Beulich
2020-01-16 18:54         ` Andrew Cooper
2020-01-17  8:39           ` Jan Beulich
2020-01-17  8:53             ` Jürgen Groß [this message]
2020-01-09 13:48 ` [Xen-devel] [PATCH v2 2/2] xen: make CONFIG_DEBUG_LOCKS usable without CONFIG_DEBUG Juergen Gross
2020-01-09 14:13   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c69fd26d-15f8-6dc7-b86b-b2add6b133af@suse.com \
    --to=jgross@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=konrad.wilk@oracle.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.