All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Romain Naour <romain.naour@smile.fr>,
	linux-pm@vger.kernel.org, linux-omap@vger.kernel.org
Cc: j-keerthy@ti.com, edubezval@gmail.com
Subject: Re: [PATCH] drivers/thermal/ti-soc-thermal: Add hwmon support
Date: Fri, 25 Feb 2022 12:46:31 +0100	[thread overview]
Message-ID: <c6b8e5fd-4315-859f-b4a2-a3a055143ddf@linaro.org> (raw)
In-Reply-To: <20220218104725.2718904-1-romain.naour@smile.fr>


Hi Romain,

I'll apply the patch.

In the future, use the scripts/get_maintainer.pl -f <file> to get the 
recipients of your patch if you have a doubt about who to send it to.

Thanks

   -- Daniel

On 18/02/2022 11:47, Romain Naour wrote:
> Expose ti-soc-thermal thermal sensors as HWMON devices.
> 
>    # sensors
>    cpu_thermal-virtual-0
>    Adapter: Virtual device
>    temp1:        +54.2 C  (crit = +105.0 C)
> 
>    dspeve_thermal-virtual-0
>    Adapter: Virtual device
>    temp1:        +51.4 C  (crit = +105.0 C)
> 
>    gpu_thermal-virtual-0
>    Adapter: Virtual device
>    temp1:        +54.2 C  (crit = +105.0 C)
> 
>    iva_thermal-virtual-0
>    Adapter: Virtual device
>    temp1:        +54.6 C  (crit = +105.0 C)
> 
>    core_thermal-virtual-0
>    Adapter: Virtual device
>    temp1:        +52.6 C  (crit = +105.0 C)
> 
> Similar to imx_sc_thermal d2bc4dd91da6095a769fdc9bc519d3be7ad5f97a.
> 
> No need to take care of thermal_remove_hwmon_sysfs() since
> devm_thermal_add_hwmon_sysfs() (a wrapper around devres) is
> used. See c7fc403e40b0ea18976a59e968c23439a80809e8.
> 
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
>   drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index f84375865c97..0959632b2170 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -21,6 +21,7 @@
>   
>   #include "ti-thermal.h"
>   #include "ti-bandgap.h"
> +#include "../thermal_hwmon.h"
>   
>   /* common data structures */
>   struct ti_thermal_data {
> @@ -189,6 +190,9 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
>   	ti_bandgap_set_sensor_data(bgp, id, data);
>   	ti_bandgap_write_update_interval(bgp, data->sensor_id, interval);
>   
> +	if (devm_thermal_add_hwmon_sysfs(data->ti_thermal))
> +		dev_warn(bgp->dev, "failed to add hwmon sysfs attributes\n");
> +
>   	return 0;
>   }
>   


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2022-02-25 11:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 10:47 [PATCH] drivers/thermal/ti-soc-thermal: Add hwmon support Romain Naour
2022-02-25 11:46 ` Daniel Lezcano [this message]
2022-02-28  9:18   ` Romain Naour
2022-03-08 20:33 ` [thermal: thermal/next] " thermal-bot for Romain Naour
  -- strict thread matches above, loose matches on Subject: below --
2022-02-16 17:22 [PATCH] " Romain Naour
2022-02-18  8:28 ` Tony Lindgren
2022-02-18 10:50   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6b8e5fd-4315-859f-b4a2-a3a055143ddf@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=romain.naour@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.