All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
Date: Sat, 2 Jun 2018 23:38:33 +0200	[thread overview]
Message-ID: <c6d74cd5-da4d-98ed-bf0b-1d5f4dbc647b@sashko.rv.ua> (raw)
In-Reply-To: <CANNYZj_KLQGyoQ1D+Bbh7sCqarKcnJu1fJBregJ+SPkQFnFDrg@mail.gmail.com>

No feelings were touched. I should have indeed explained why the SRC_URI 
was changed.

I'll update the patch. Cheers.

On 02/06/18 23:35, Alexander Kanavin wrote:
> I'm sorry for being terse. Reviewing patches before morning coffee is
> not always a great idea.
>
> When changing SRC_URI, you still need to explain in the commit message
> what's wrong with the old URI and how the new URI was chosen.
>
> Specifically here, alioth is not temporarily down, it has been
> deliberately taken offline:
>
> https://wiki.debian.org/Alioth
>
> and the same wiki page lists salsa.debian.org as the successor. Any
> debian-driven projects are likely to have been moved there, and so
> that's the first place I had checked.
>
> Alex
>
> 2018-06-02 16:35 GMT+03:00 Oleksandr Kravchuk
> <open.source@oleksandr-kravchuk.com>:
>> On 02/06/18 07:19, Alexander Kanavin wrote:
>>> 2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
>>> <open.source@oleksandr-kravchuk.com>:
>>>>    SRC_URI =
>>>> "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz"
>>>> +SRC_URI =
>>>> "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz"
>>> The correct new URI is
>>> https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
>>> ftp from google search results please.
>>>
>>> Alex
>> It is not always easy to find "the new" official URI. I took the one that
>> was around for a long time, not "a random ftp from google search results".
>>
>> I will fix and resend the patch.


  reply	other threads:[~2018-06-02 21:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 22:14 [meta-oe][PATCH 1/2] chrpath: fix SRC_URI Oleksandr Kravchuk
2018-06-01 22:14 ` [meta-oe][PATCH 2/2] iso-codes: " Oleksandr Kravchuk
2018-06-02  5:19   ` Alexander Kanavin
2018-06-02 13:35     ` Oleksandr Kravchuk
2018-06-02 21:35       ` Alexander Kanavin
2018-06-02 21:38         ` Oleksandr Kravchuk [this message]
2018-06-02  5:24 ` [meta-oe][PATCH 1/2] chrpath: " Alexander Kanavin
2018-06-02 13:45   ` Oleksandr Kravchuk
2018-06-02 21:40     ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6d74cd5-da4d-98ed-bf0b-1d5f4dbc647b@sashko.rv.ua \
    --to=open.source@oleksandr-kravchuk.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.