From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/8] infra/pkg-generic: don't set INSTALL_{TARGET, STAGING, IMAGES} for host
Date: Sat, 11 Apr 2020 10:12:27 +0200 [thread overview]
Message-ID: <c6febf929ca8d42bbd7d053643dc342272fe4f74.1586592741.git.yann.morin.1998@free.fr> (raw)
In-Reply-To: <cover.1586592741.git.yann.morin.1998@free.fr>
By their very nature, host packages have no target, staging, or
images install steps; they have a single install step, that is
always performed.
As sucj, setting the corresponding _INSTALL_{TARGET,STAGING,IMAGES}
variables does not make sense for host packages.
However, people (and scripts) may get confused when they process the
output of printvars, e.g.:
$ make printvars VARS=HOST_LIBTOOL_INSTALL_TARGET
HOST_LIBTOOL_INSTALL_TARGET=YES
Only set those variables for target packages. There is no corresponding
variable for host packages, as they are always installed (and only
once).
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Vadim Kochan <vadim4j@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: eeppeliteloop at gmail.com
---
package/pkg-generic.mk | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 7679c41556..8cd5a7ff62 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -706,10 +706,6 @@ $(2)_FINAL_RECURSIVE_RDEPENDENCIES = $$(sort \
) \
$$($(2)_FINAL_RECURSIVE_RDEPENDENCIES__X))
-$(2)_INSTALL_STAGING ?= NO
-$(2)_INSTALL_IMAGES ?= NO
-$(2)_INSTALL_TARGET ?= YES
-
# define sub-target stamps
$(2)_TARGET_INSTALL_TARGET = $$($(2)_DIR)/.stamp_target_installed
$(2)_TARGET_INSTALL_STAGING = $$($(2)_DIR)/.stamp_staging_installed
@@ -770,6 +766,9 @@ $(1): $(1)-install
ifeq ($$($(2)_TYPE),host)
$(1)-install: $(1)-install-host
else
+$(2)_INSTALL_STAGING ?= NO
+$(2)_INSTALL_IMAGES ?= NO
+$(2)_INSTALL_TARGET ?= YES
$(1)-install: $(1)-install-staging $(1)-install-target $(1)-install-images
endif
--
2.20.1
next prev parent reply other threads:[~2020-04-11 8:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 8:12 [Buildroot] [PATCH 0/8] core/show-info: export extra information about the package build (branch yem/show-info-extras) Yann E. MORIN
2020-04-11 8:12 ` [Buildroot] [PATCH 1/8] core/show-info: do not show install types for host packages Yann E. MORIN
2020-04-25 12:57 ` Thomas Petazzoni
2020-04-11 8:12 ` Yann E. MORIN [this message]
2020-04-25 12:57 ` [Buildroot] [PATCH 2/8] infra/pkg-generic: don't set INSTALL_{TARGET, STAGING, IMAGES} for host Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 3/8] core/show-info: report install types for virtual packages too Yann E. MORIN
2020-04-11 8:41 ` Thomas Petazzoni
2020-04-11 9:49 ` Yann E. MORIN
2020-04-25 13:07 ` Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 4/8] core/show-info: report the package build directory Yann E. MORIN
2020-04-25 13:08 ` Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 5/8] core/show-info: report whether a package is overriden Yann E. MORIN
2020-04-11 8:36 ` Thomas Petazzoni
2020-04-11 9:44 ` Yann E. MORIN
2020-04-11 12:42 ` Thomas Petazzoni
2020-04-11 13:22 ` Yann E. MORIN
2020-04-11 14:14 ` Thomas Petazzoni
2020-04-11 17:41 ` Yann E. MORIN
2020-04-11 8:12 ` [Buildroot] [PATCH 6/8] core/show-info: report package stamp files Yann E. MORIN
2020-04-11 8:38 ` Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 7/8] core/show-info: report the ordered list of build steps Yann E. MORIN
2020-04-11 8:39 ` Thomas Petazzoni
2020-04-11 13:41 ` Philippe Proulx
2020-04-11 14:19 ` Thomas Petazzoni
2020-04-11 15:06 ` Philippe Proulx
2020-04-11 15:27 ` Thomas Petazzoni
2020-04-11 18:20 ` Yann E. MORIN
2020-04-11 18:12 ` Yann E. MORIN
2020-04-11 18:02 ` Yann E. MORIN
2020-04-11 8:12 ` [Buildroot] [PATCH 8/8] core/show-info: report image name of filesystems Yann E. MORIN
2020-04-25 13:12 ` Thomas Petazzoni
2020-04-25 13:32 ` Yann E. MORIN
2021-07-27 20:08 ` Arnout Vandecappelle
2020-04-25 13:13 ` [Buildroot] [PATCH 0/8] core/show-info: export extra information about the package build (branch yem/show-info-extras) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6febf929ca8d42bbd7d053643dc342272fe4f74.1586592741.git.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.