From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101D0C43461 for ; Tue, 8 Sep 2020 19:26:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D34C22087D for ; Tue, 8 Sep 2020 19:26:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LdL/DpkO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731903AbgIHT0n (ORCPT ); Tue, 8 Sep 2020 15:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731037AbgIHQAE (ORCPT ); Tue, 8 Sep 2020 12:00:04 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E290C0068FA for ; Tue, 8 Sep 2020 08:02:35 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id w8so15690363ilj.8 for ; Tue, 08 Sep 2020 08:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LfTXIdItMSqKxZtrDwVu/wtSc1NVGVSR9MloeRpjmqY=; b=LdL/DpkOuQjENDMmfpMEdTvVOtX0YCkrKBpF+s4VYTukAhq+hKaDkVaJbKJfBfdLog FAZtHLuEZkEXS74mBfYXaUbDWg1lzQCPsBbEcQpRUbzo7MNoK06bu2UUm0gBV/opdkXU UhZ44FfyfTiR3j4y7q/o2CdimiV2j0R4ZrN8KH+TyOEuJXHyGptj6pHm7jwnADWnb9s6 umGCVYrN0rL2aPFhfWU3sjlbeP2bzL1a2NORyPIPC6GHdmBYQ73N7Wx3JGaKzZanmtZk RtSOgSY+M5JMPe+AAEIJkj8JsERvQdX/8tsRO8gdEFZtBXolnJtsAdTU5thtCShOSiu9 nSwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LfTXIdItMSqKxZtrDwVu/wtSc1NVGVSR9MloeRpjmqY=; b=ePnW3zL2Dohy6CRIaF7d2+2uCLr80nnSH3DZCb8qbsZX+uhj87YIcNB9al5VrfIUTg KZuAZlZRTcaChmHp89JDOV8/YJh/Mq1niHQynB5DgYBLYJSTt56xfwnFQ6LTzwWgVfPI 9FWCuJJ6eHLyXRQUBN/CaPt3zfezDG9Qex6yVKMDIQdwGehOOZwvAv7Q1YMOKCsiBV2x E9rZbTDS2AgvNaDVPckaOfdLujq4/+zYSC7q9yTdHc9ZOXJtlKcU8mXgdgtuSl1y42D8 xbmB06o7LP9mrc4jIr4Qe3Ciwr9gPLRivJTAnljWb7b7qRl7NY/A3Q7QV6moKFu6poDO R9kw== X-Gm-Message-State: AOAM530y+5jq4QaJC7r7bQ/C4q9jVTzbyzlmXk4BV6mlbCPEIz1nv+4A w0mmF+2uBWyFdX1ykPb8XbA= X-Google-Smtp-Source: ABdhPJwomKuL/KxMmhZZreFcWHK69KXcE/EpLbin9QnSYfL97kz9IfQl4YgqtTpQVbIHCi1642bdDg== X-Received: by 2002:a92:7b10:: with SMTP id w16mr21656222ilc.92.1599577354920; Tue, 08 Sep 2020 08:02:34 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([2601:282:803:7700:ec70:7b06:eed6:6e35]) by smtp.googlemail.com with ESMTPSA id k14sm8685655ioa.7.2020.09.08.08.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 08:02:34 -0700 (PDT) Subject: Re: [RFC PATCH net-next 09/22] rtnetlink: Add RTNH_F_TRAP flag To: Ido Schimmel , netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, roopa@nvidia.com, mlxsw@nvidia.com, Ido Schimmel References: <20200908091037.2709823-1-idosch@idosch.org> <20200908091037.2709823-10-idosch@idosch.org> From: David Ahern Message-ID: Date: Tue, 8 Sep 2020 09:02:33 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200908091037.2709823-10-idosch@idosch.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/8/20 3:10 AM, Ido Schimmel wrote: > From: Ido Schimmel > > The flag indicates to user space that the nexthop is not programmed to > forward packets in hardware, but rather to trap them. please elaborate in the commit message on what 'trap' is doing. I most likely will forget a few years from now. > > The flag will be used in subsequent patches by netdevsim to test nexthop > objects programming to device drivers and in the future by mlxsw as > well. > > Signed-off-by: Ido Schimmel > --- > include/uapi/linux/rtnetlink.h | 6 ++++-- > net/ipv4/fib_semantics.c | 2 ++ > 2 files changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: David Ahern