On 3/17/17 6:38 PM, Daniel Dickinson wrote:
> On Sat, 18 Mar 2017 02:21:30 +0100
> Gary Thomas <gary@mlbassoc.com> wrote:
> 
>>
>> Have you read this?
>>    http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
> 
> I hadn't read in detail yet (I've seen similar before and from
> skimming, it's about mechanics of the process), but I was looking more
> in terms of coding and/or style guidelines for the meat of the patch,
> and/or hints/tips on getting things accepted from the point of view of
> things other than mechanics of patch submission.

If you read through that link Gary pointed, there are links to two other
documents one of style and other one patch message guidelines

there is styling scripts for metadata files, you could use that
https://github.com/openembedded/meta-openembedded/blob/master/contrib/oe-stylize.py

As of meat of patch, if its fixing something and you are articulate to
explain it in your commit message and in general review cycle, you have
a better chance of getting it accepted, but you have to start submitting

>  
>>>
>>> Also, in the layers list I'll be asking about some build issues
>>> that I don't see with a manual bitbake, that look like missing
>>> preqs on a build server, unless the layer should be requesting
>>> installation of host files somewhere.  
>>
>> Some tools required by ${HOSTTOOLS} are missing:
>>    cpio chrpath gawk diffstat makeinfo
> 
> As mentioned these are openembedded.org autobuilds of submitted layers,
> so I was kind of hoping there were something I could change in the
> layer to make it work.  I guess the build host or chroot is missing
> packges.
> 
> Regards,
> 
> Daniel
>