[Buildroot] [PATCH 1/2] package/libv4l: drop -largp

[Buildroot] [PATCH 1/2] package/libv4l: drop -largp

[Fabrice Fontaine]

Commit 07ac045655d08255fbc2d17b16a42d0f0017632e added -largp to LIBS but
it was not needed since
https://git.linuxtv.org/v4l-utils.git/commit/configure.ac?id=b187b94d8e9158973ad17ea1f9c4cb01df117ba3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libv4l/libv4l.mk | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
index 8300f5c970..a781ffcd5d 100644
--- a/package/libv4l/libv4l.mk
+++ b/package/libv4l/libv4l.mk
@@ -28,7 +28,6 @@ endif
 
 ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 LIBV4L_DEPENDENCIES += argp-standalone
-LIBV4L_LIBS += -largp
 endif
 
 LIBV4L_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv)
@@ -85,6 +84,4 @@ ifeq ($(BR2_PACKAGE_SDL2_IMAGE),y)
 LIBV4L_DEPENDENCIES += sdl2_image
 endif
 
-LIBV4L_CONF_ENV += LIBS="$(LIBV4L_LIBS)"
-
 $(eval $(autotools-package))
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/libv4l: fix build with argp-standalone and NLS

[Fabrice Fontaine]

Fix the following build failure with argp-standalone and NLS raised
since commit 5430c8fedd0392e79e0c011825b056fea129980a:

configure:19923: /home/giuliobenetti/autobuild/run/instance-2/output-1/host/bin/i686-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -g0  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  conftest.c -largp  -largp >&5
/home/giuliobenetti/autobuild/run/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: /home/giuliobenetti/autobuild/run/instance-2/output-1/host/i686-buildroot-linux-uclibc/sysroot/usr/lib/libargp.a(argp-parse.o): in function `argp_version_parser':
/home/giuliobenetti/autobuild/run/instance-2/output-1/build/argp-standalone-1.4.1/argp-parse.c:181: undefined reference to `libintl_dgettext'

[...]

checking for library containing argp_parse... no
configure: error: unable to find the argp_parse() function

Fixes:
 - http://autobuild.buildroot.org/results/b7b2253ac902b441cc6ff12500b56bd15c413d71

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libv4l/libv4l.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
index a781ffcd5d..fd69b7ac7a 100644
--- a/package/libv4l/libv4l.mk
+++ b/package/libv4l/libv4l.mk
@@ -27,7 +27,8 @@ LIBV4L_DEPENDENCIES += alsa-lib
 endif
 
 ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
-LIBV4L_DEPENDENCIES += argp-standalone
+LIBV4L_DEPENDENCIES += argp-standalone $(TARGET_NLS_DEPENDENCIES)
+LIBV4L_CONF_ENV += LIBS=$(TARGET_NLS_LIBS)
 endif
 
 LIBV4L_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv)
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/libv4l: drop -largp

[Arnout Vandecappelle]

On 27/04/2022 22:42, Fabrice Fontaine wrote:
> Commit 07ac045655d08255fbc2d17b16a42d0f0017632e added -largp to LIBS but
> it was not needed since
> https://git.linuxtv.org/v4l-utils.git/commit/configure.ac?id=b187b94d8e9158973ad17ea1f9c4cb01df117ba3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied both to master, thanks.

  Regards,
  Arnout

> ---
>   package/libv4l/libv4l.mk | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
> index 8300f5c970..a781ffcd5d 100644
> --- a/package/libv4l/libv4l.mk
> +++ b/package/libv4l/libv4l.mk
> @@ -28,7 +28,6 @@ endif
>   
>   ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
>   LIBV4L_DEPENDENCIES += argp-standalone
> -LIBV4L_LIBS += -largp
>   endif
>   
>   LIBV4L_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv)
> @@ -85,6 +84,4 @@ ifeq ($(BR2_PACKAGE_SDL2_IMAGE),y)
>   LIBV4L_DEPENDENCIES += sdl2_image
>   endif
>   
> -LIBV4L_CONF_ENV += LIBS="$(LIBV4L_LIBS)"
> -
>   $(eval $(autotools-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/libv4l: drop -largp

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Commit 07ac045655d08255fbc2d17b16a42d0f0017632e added -largp to LIBS but
 > it was not needed since
 > https://git.linuxtv.org/v4l-utils.git/commit/configure.ac?id=b187b94d8e9158973ad17ea1f9c4cb01df117ba3

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot