All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Chanho Park <chanho61.park@samsung.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-phy@lists.infradead.org
Subject: Re: [PATCH 2/2] phy: samsung-ufs: support exynosauto ufs phy driver
Date: Mon, 5 Jul 2021 14:35:53 +0200	[thread overview]
Message-ID: <c7370b7d-ab2b-1423-0e7b-9f0c4d227e4e@canonical.com> (raw)
In-Reply-To: <bb462ea1-7a94-b697-a716-218594439487@canonical.com>

On 05/07/2021 14:29, Krzysztof Kozlowski wrote:
> On 05/07/2021 12:23, Chanho Park wrote:
>> This patch adds to support phy-exynosauto-ufs driver for ExynosAuto v9
>> series SoCs. The patch adds "samsung,exynosauto-ufs-phy" compatible.
>> Unlike previous exynos ufs phy, the chip uses 0x50 offset as
>> PHY_TRSV_REG_CFG_OFFSET.
>>
>> Change-Id: I4ea333d4565af537c26a8876d1b27144eea3c3c6
>> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>> ---
>>  .../bindings/phy/samsung,ufs-phy.yaml         |  1 +
>>  drivers/phy/samsung/phy-exynosauto-ufs.h      | 70 +++++++++++++++++++
>>  drivers/phy/samsung/phy-samsung-ufs.c         |  3 +
>>  drivers/phy/samsung/phy-samsung-ufs.h         |  1 +
>>  4 files changed, 75 insertions(+)
>>  create mode 100644 drivers/phy/samsung/phy-exynosauto-ufs.h
>>
>> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
>> index 636cc501b54f..8e13f8cec6a7 100644
>> --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
>> @@ -16,6 +16,7 @@ properties:
>>    compatible:
>>      enum:
>>        - samsung,exynos7-ufs-phy
>> +      - samsung,exynosauto-ufs-phy
> 
> I would prefer real product ID (taken from registers or vendor kernel),
> not a marketing name "Auto" because it's too generic, unspecified, too
> much as wildcard.
> 
> If vendor kernel does not define name or product ID is also not
> specific, then it should include a version - so "autov9".
> 

BTW, the previous Exynos Auto SoC was "Exynos Auto 8890", so it already
confuses naming with older designs. It would be actually good to compare
it with other recent Exynos PHYs (Exynos Auto 8890, generic Exynos9xxx
and Exynos980/990) because maybe it's not "Auto" at all.

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2021-07-05 12:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210705102339epcas2p2963b4eb64ad038315a7b8da304b37218@epcas2p2.samsung.com>
2021-07-05 10:23 ` [PATCH 0/2] Support exynosauto ufs phy driver Chanho Park
     [not found]   ` <CGME20210705102410epcas2p38a6f148b23f8716725bbc8b879471603@epcas2p3.samsung.com>
2021-07-05 10:23     ` [PATCH 1/2] phy: samsung-ufs: custom PHY_TRSV_CH_OFFSET support Chanho Park
2021-07-05 12:17       ` Krzysztof Kozlowski
2021-07-05 23:52         ` Chanho Park
     [not found]   ` <CGME20210705102414epcas2p4bfdfa979f08221c6834d64a2faa20b6a@epcas2p4.samsung.com>
2021-07-05 10:23     ` [PATCH 2/2] phy: samsung-ufs: support exynosauto ufs phy driver Chanho Park
2021-07-05 12:29       ` Krzysztof Kozlowski
2021-07-05 12:35         ` Krzysztof Kozlowski [this message]
2021-07-05 23:57         ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7370b7d-ab2b-1423-0e7b-9f0c4d227e4e@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=alim.akhtar@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=jh80.chung@samsung.com \
    --cc=kishon@ti.com \
    --cc=linux-phy@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.