From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BC2C433DF for ; Mon, 18 May 2020 08:56:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EC98207D8 for ; Mon, 18 May 2020 08:56:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eCyA70Gw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EC98207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jabZV-0007Sv-Fo for qemu-devel@archiver.kernel.org; Mon, 18 May 2020 04:56:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jabYp-0006Xt-4d for qemu-devel@nongnu.org; Mon, 18 May 2020 04:55:47 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:54938 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jabYn-0003Ac-2a for qemu-devel@nongnu.org; Mon, 18 May 2020 04:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589792144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AFvyflhV6bpCowSjCbqLoHw0FEGhnsCKNyWzSBxTZkA=; b=eCyA70Gw2JalJ19ICR7KFZpxMnaPxgQpphb/2t1Twp96d+flxHBPfDFNLN8DSfs8b5WjaQ gitAM9v+yeLhGHfsb4AIWf1PWvrP/42BsqtmtlXAH2P10hxNyx6502JOF1054md7PcpFny PHSP3EsZteW7RIccosdhWlxSrT8vYVY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-fzJL2_NLPRqMOs0YzG_GMQ-1; Mon, 18 May 2020 04:55:42 -0400 X-MC-Unique: fzJL2_NLPRqMOs0YzG_GMQ-1 Received: by mail-wr1-f69.google.com with SMTP id p8so5343454wrj.5 for ; Mon, 18 May 2020 01:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AFvyflhV6bpCowSjCbqLoHw0FEGhnsCKNyWzSBxTZkA=; b=D4mXZ0+B8/WHr8uRlK8qEUiYyishgoEpdpOYLS0Jj1mEX8b22t8SK7FH4NX72NAzyS gATu+f9fzsT5FgGnOu1jRi0o5ZUTCr590n8y3sG78GzenupO4tmtiXW8pc+UaNj8T6C0 G/ZWRLcPyixvgx50lf0x0e4tw18gbjNcK5JsgKfl458hHpt+jtOUA4YCDTMqUoIOWxPG pswp70GA/ZUesWND1QDSwXZiw1wPFmVN43f03Nmk8TNqrfA5C4yc0ioKRgGLGTlGvlzn GBAvm5QdNCM9tX7nSMSFrAzj1/dt5uJhdpR6lItWDGgcZp5luKbh6XflKQP4RS6mRocA EXBQ== X-Gm-Message-State: AOAM533Hyu+VpDnTCpjk56v52JDUEqNBOfQAotddauRKy+IztkBvjAL/ uaB0NYDe0HvJ9caxx+7vnnvrVFkjRhizVH+CF5gPZkIyBboqFimCDUwclz+pmsMn2NSmjPqV4Zb huH17UUS013fQR1Q= X-Received: by 2002:a5d:6085:: with SMTP id w5mr18492858wrt.322.1589792141531; Mon, 18 May 2020 01:55:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnQDLdvjtwNbWxIbk157pv08nb7bDi4efvM7Gj6c14OuhcbQ+3bzZCBCkTfX/VySZ6KXv1NA== X-Received: by 2002:a5d:6085:: with SMTP id w5mr18492836wrt.322.1589792141369; Mon, 18 May 2020 01:55:41 -0700 (PDT) Received: from [192.168.1.38] (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id j2sm15406958wrp.47.2020.05.18.01.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 01:55:40 -0700 (PDT) Subject: Re: [PATCH 15/24] macio: Fix macio-bus to be a subtype of System bus To: Markus Armbruster , qemu-devel@nongnu.org References: <20200518050408.4579-1-armbru@redhat.com> <20200518050408.4579-16-armbru@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 18 May 2020 10:55:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200518050408.4579-16-armbru@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 22:51:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, ehabkost@redhat.com, Mark Cave-Ayland , qemu-ppc@nongnu.org, pbonzini@redhat.com, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/18/20 7:03 AM, Markus Armbruster wrote: > The devices we plug into the macio-bus are all sysbus devices > (DeviceClass member bus_type is TYPE_SYSTEM_BUS), but macio-bus does > not derive from TYPE_SYSTEM_BUS. Fix that. > > "info qtree" now shows the devices' mmio ranges, as it should > > Cc: Mark Cave-Ayland > Cc: David Gibson > Cc: qemu-ppc@nongnu.org > Signed-off-by: Markus Armbruster > --- > hw/misc/macio/macio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c > index ebc96cc8f6..53a9fd5696 100644 > --- a/hw/misc/macio/macio.c > +++ b/hw/misc/macio/macio.c > @@ -492,7 +492,7 @@ static void macio_class_init(ObjectClass *klass, void *data) > > static const TypeInfo macio_bus_info = { > .name = TYPE_MACIO_BUS, > - .parent = TYPE_BUS, > + .parent = TYPE_SYSTEM_BUS, > .instance_size = sizeof(MacIOBusState), > }; > > Reviewed-by: Philippe Mathieu-Daudé