All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs-progs: only allow certain commands to ignore transid errors
Date: Mon, 20 Sep 2021 19:01:29 +0800	[thread overview]
Message-ID: <c7400d63-b6a7-dca8-e921-5f34ce2b8a06@gmx.com> (raw)
In-Reply-To: <20210920104343.GD9286@twin.jikos.cz>



On 2021/9/20 18:43, David Sterba wrote:
> On Wed, Sep 08, 2021 at 10:05:41AM +0800, Qu Wenruo wrote:
>> There is a bug in reddit (well, really the last place I expect to see
>> bug reports)
>
> Why? People discuss things where they're used to, reddit is one of them
> and from what I've seen there are good questions or usage recommendations.
> Some of that goes to documentation or helps to tune usability.

Well, I'm more used to see memes/trolls there, maybe it's per-subreddit.

Anyway next time I would drop the prejudice.

Thanks,
Qu
>
>> that btrfstune -u fails due to transid error, but it also
>> leaves CHANGING_FSID flag to the super block, prevent btrfs-check to
>> properly check the fs.
>>
>> The problem is, all commands in btrfs-progs can ignore transid error,
>> but there are only very limited usage of such ability.
>>
>> Btrfstune definitely should not utilize this feature.
>>
>> This patchset will introduce a new open ctree flag to explicitly
>> indicate we want to ignore transid errors.
>>
>> Currently only there are only 3 tools using this feature:
>>
>> - btrfs-check
>>    It may fix transid error (at least for the specific test case)
>>
>> - btrfs-restore
>>    It wants to ignore all errors.
>>
>> - btrfs-image
>>    To make fsck/002 happy.
>>
>> Also add a test case for btrfstune, to make sure btrfstune can rejects
>> the fs when an obvious transid mismatch is detected during open_ctree().
>>
>> Qu Wenruo (2):
>>    btrfs-progs: introduce OPEN_CTREE_ALLOW_TRANSID_MISMATCH flag
>>    btrfs-progs: misc-tests: add new test case to make sure btrfstune
>>      rejects corrupted fs
>
> Added to devel, thanks.
>

      reply	other threads:[~2021-09-20 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  2:05 [PATCH 0/2] btrfs-progs: only allow certain commands to ignore transid errors Qu Wenruo
2021-09-08  2:05 ` [PATCH 1/2] btrfs-progs: introduce OPEN_CTREE_ALLOW_TRANSID_MISMATCH flag Qu Wenruo
2021-09-08  2:05 ` [PATCH 2/2] btrfs-progs: misc-tests: add new test case to make sure btrfstune rejects corrupted fs Qu Wenruo
2021-09-20 10:43 ` [PATCH 0/2] btrfs-progs: only allow certain commands to ignore transid errors David Sterba
2021-09-20 11:01   ` Qu Wenruo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7400d63-b6a7-dca8-e921-5f34ce2b8a06@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.