From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450A1C433FE for ; Sun, 12 Sep 2021 16:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24374610F9 for ; Sun, 12 Sep 2021 16:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233400AbhILQPf (ORCPT ); Sun, 12 Sep 2021 12:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbhILQPe (ORCPT ); Sun, 12 Sep 2021 12:15:34 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3FD9C061574; Sun, 12 Sep 2021 09:14:19 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id 22so7932994qkg.2; Sun, 12 Sep 2021 09:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=P60SQ/CsW1eZndcpQR8AR/xrEVIdL+Rao4L2rbgdhaA=; b=HUwk6qnr0kgyqmTOdj14K7PvRl+vIgLwhfa/Soxserjlx37Q0bl82oHT4huLR3WgeI ulPWtV72/igDuyPZofm4nb4dckNhxmprUg38UWVo82a3Ykx8O2lBRxLO3iNi63n2Tu4f HOf9CaMXpjic2WE20hT1aDR7vdocgvMZDfCkWbq6EmVifM3Z54ZbqLU9GGkNE+Bv41S5 jHaTArKj1jA2hXTnoF+JnyIZOpCvlyn+m9mau3lq0PprQygy/o20YjltGrBjt31GQEJ+ EE7gWGuBUAOOfH/adHuIEKG0qB2zLImFBPmodyG7nJdrHzzSsd3OTUomkJBeeKHlIdR/ 9Q1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P60SQ/CsW1eZndcpQR8AR/xrEVIdL+Rao4L2rbgdhaA=; b=QgIlnQlgReqoi98Z4L8VWMn33HSJVKyiC51EAEm0JlQQf5wvhmWZ9VR7RXvqf+7QZX xrUMqexk9Zs/mJgrclpq2PkvTadQ53KHwDel1DZ5Jtb+NcrddwIKHsYGNOQ2v2E+f56R 0BIR7CXQ23hlJrSdlapZHnE7u8FYZDNGi1bAxEdKL/tyPMC8v8jKrc0CTDGUrCmgejlw m01TE7AxytNU0mU+Xxm09y0dt8yyXFNmRLrQBxwtAPr+7OIhEJPR6yUNEbn0ntuZv/WW VWwhKX2w9G7OjvyfvFcH8BkMXD9rurbFmI/rFNlO6QIcOuB68RNwZ3y+iFZe7qsr3Su5 JAQw== X-Gm-Message-State: AOAM5314Eosh35vjjD7QIM+24tcnkov0DuJY9I+fTQBUa+xLDIse4Q5X hGORhCWP1nBOpCTVNyxr8mZE/G/Ass0= X-Google-Smtp-Source: ABdhPJwCHzJ7tC9DgCi07ahFY8D4qJ10evt3UqKBcCnZz212piHDTdmcK+JNd5y6GzOPE3C02xNDQw== X-Received: by 2002:ae9:f40b:: with SMTP id y11mr6289972qkl.107.1631463259134; Sun, 12 Sep 2021 09:14:19 -0700 (PDT) Received: from ?IPV6:2600:1700:dfe0:49f0:b198:60c0:9fe:66c9? ([2600:1700:dfe0:49f0:b198:60c0:9fe:66c9]) by smtp.gmail.com with ESMTPSA id y12sm2693999qtj.3.2021.09.12.09.14.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 09:14:18 -0700 (PDT) Message-ID: Date: Sun, 12 Sep 2021 09:14:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers Content-Language: en-US To: Vladimir Oltean , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Linus Walleij , George McCollister , Heiner Kallweit , Russell King , Oleksij Rempel , Michael Grzeschik , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lino Sanfilippo References: <20210912120932.993440-1-vladimir.oltean@nxp.com> <20210912120932.993440-2-vladimir.oltean@nxp.com> From: Florian Fainelli In-Reply-To: <20210912120932.993440-2-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/2021 5:09 AM, Vladimir Oltean wrote: > MDIO-attached devices might have interrupts and other things that might > need quiesced when we kexec into a new kernel. Things are even more > creepy when those interrupt lines are shared, and in that case it is > absolutely mandatory to disable all interrupt sources. > > Moreover, MDIO devices might be DSA switches, and DSA needs its own > shutdown method to unlink from the DSA master, which is a new > requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link > interfaces with the DSA master to get rid of lockdep warnings"). > > So introduce a ->shutdown method in the MDIO device driver structure. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FF3C433EF for ; Sun, 12 Sep 2021 16:14:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3A78610CE for ; Sun, 12 Sep 2021 16:14:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A3A78610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ltw6st3GmmM8OC8UNNBmTpP7s0WUQPa5kOTwx4hoqE=; b=TAAW0k4ejjStPU z8xjTmlWceRAv5Vrui3LKHOvmIl3SDT7TGIimD4fN5N6lVc0KSaA2oiY4enRWBECvSWUN+IH7KTmx Ms44otOa9ruYPEYT4gBOrI/aUxE5t8pjuws7RD+r/OfvlDjFD9l+Zo98dTVyJI32P72SKe14f4cWd HNlznCvGxCCHqmgnMSuAnmFdxkZwr+nf0enDAxlqp6QMTMI/QagghkL4OHFY71BV300f8rEWkZl0t LQuYH7hhRuitc43MqL8Lxb4/yOhrZ8T3RQrf7OBVImcfSJl7jLfOftNf2m5lvfk3pkXhQwXEOQbo/ 76zxc0xBhbm/qxuWI/qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPS7m-00GgW3-KJ; Sun, 12 Sep 2021 16:14:34 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPS7Z-00GgU4-0A; Sun, 12 Sep 2021 16:14:22 +0000 Received: by mail-qk1-x735.google.com with SMTP id p4so7912533qki.3; Sun, 12 Sep 2021 09:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=P60SQ/CsW1eZndcpQR8AR/xrEVIdL+Rao4L2rbgdhaA=; b=HUwk6qnr0kgyqmTOdj14K7PvRl+vIgLwhfa/Soxserjlx37Q0bl82oHT4huLR3WgeI ulPWtV72/igDuyPZofm4nb4dckNhxmprUg38UWVo82a3Ykx8O2lBRxLO3iNi63n2Tu4f HOf9CaMXpjic2WE20hT1aDR7vdocgvMZDfCkWbq6EmVifM3Z54ZbqLU9GGkNE+Bv41S5 jHaTArKj1jA2hXTnoF+JnyIZOpCvlyn+m9mau3lq0PprQygy/o20YjltGrBjt31GQEJ+ EE7gWGuBUAOOfH/adHuIEKG0qB2zLImFBPmodyG7nJdrHzzSsd3OTUomkJBeeKHlIdR/ 9Q1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P60SQ/CsW1eZndcpQR8AR/xrEVIdL+Rao4L2rbgdhaA=; b=wzvPd65Z4lr1P8SFL7cjC6YCmzQbwq/hOjLswvbsHguKParAiGtb88Y8U7I0IDQFXc +DLgf4pj819j0ubZNflel26YJdjNTbCjsmmQRRgP7RIPaOXyO9G9fiR722Rj6xY3oMP8 doGDg1YiQK5vPqL4TXSUnPS+dLU4sdqMxIiikPJkKPsf/4t6vqvv22ian+5R/fJgVuHB AWJksWqFxD/aVQi85MAEnkSctvEgD64PYp1FVb3yEaGrSqJ64GwWYR5I/eL7u1VQrpCc h0z1NlfgqshDf0Ud6OPDinAxsJq7YKEr/nVz1CatFwACholnV81d0tsB4kcVaYrY8LhI Xp2Q== X-Gm-Message-State: AOAM531J2064ykBuYAoZUMuMWdZMAcRIsoZpUhFA2kPp0BKjjuuNVbgA 4BY1BF4Zo+ipfHj44qnorrk= X-Google-Smtp-Source: ABdhPJwCHzJ7tC9DgCi07ahFY8D4qJ10evt3UqKBcCnZz212piHDTdmcK+JNd5y6GzOPE3C02xNDQw== X-Received: by 2002:ae9:f40b:: with SMTP id y11mr6289972qkl.107.1631463259134; Sun, 12 Sep 2021 09:14:19 -0700 (PDT) Received: from ?IPV6:2600:1700:dfe0:49f0:b198:60c0:9fe:66c9? ([2600:1700:dfe0:49f0:b198:60c0:9fe:66c9]) by smtp.gmail.com with ESMTPSA id y12sm2693999qtj.3.2021.09.12.09.14.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 09:14:18 -0700 (PDT) Message-ID: Date: Sun, 12 Sep 2021 09:14:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers Content-Language: en-US To: Vladimir Oltean , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Linus Walleij , George McCollister , Heiner Kallweit , Russell King , Oleksij Rempel , Michael Grzeschik , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lino Sanfilippo References: <20210912120932.993440-1-vladimir.oltean@nxp.com> <20210912120932.993440-2-vladimir.oltean@nxp.com> From: Florian Fainelli In-Reply-To: <20210912120932.993440-2-vladimir.oltean@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210912_091421_100209_A549C74F X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 9/12/2021 5:09 AM, Vladimir Oltean wrote: > MDIO-attached devices might have interrupts and other things that might > need quiesced when we kexec into a new kernel. Things are even more > creepy when those interrupt lines are shared, and in that case it is > absolutely mandatory to disable all interrupt sources. > > Moreover, MDIO devices might be DSA switches, and DSA needs its own > shutdown method to unlink from the DSA master, which is a new > requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link > interfaces with the DSA master to get rid of lockdep warnings"). > > So introduce a ->shutdown method in the MDIO device driver structure. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBADC433EF for ; Sun, 12 Sep 2021 16:16:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B526101E for ; Sun, 12 Sep 2021 16:16:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32B526101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pnb4TiqDUemeMBqEN6YNlWR5/X8XB6qaSSHRdZep3ec=; b=Ei7ZjeWGACR/it W5SErRqCaVAb27fpuWYo6JAhcQHyvnMKF3ZZrRwSGcWDvI9CqDPOIJTv7BuD2bHUUJNRUkte1P1cS edbe6Q5ofyY8JCqBDsq46yDOcO+DDWsVC4AWwafFGhSHL6I1Hm5sYtCuNkpY00/yC6Z1257L00Xwy s7mno1IW2ZwHZY3bJ+7fHcE6JsqcoKcMaqMGBTXgjHBBKJdZ/4o9Jni1my7pEweE2BWG1WWUyyXF+ 52JqkRRa3jEtOCTDYGwkUeYgxu4aXi3ev5qyFc4+/oBHg+1oeu8ZyiN9zQGK31EIGmTl9dAd9yehS LHfVJzx9/1wMVZ5RWCzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPS7d-00GgUv-8d; Sun, 12 Sep 2021 16:14:25 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPS7Z-00GgU4-0A; Sun, 12 Sep 2021 16:14:22 +0000 Received: by mail-qk1-x735.google.com with SMTP id p4so7912533qki.3; Sun, 12 Sep 2021 09:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=P60SQ/CsW1eZndcpQR8AR/xrEVIdL+Rao4L2rbgdhaA=; b=HUwk6qnr0kgyqmTOdj14K7PvRl+vIgLwhfa/Soxserjlx37Q0bl82oHT4huLR3WgeI ulPWtV72/igDuyPZofm4nb4dckNhxmprUg38UWVo82a3Ykx8O2lBRxLO3iNi63n2Tu4f HOf9CaMXpjic2WE20hT1aDR7vdocgvMZDfCkWbq6EmVifM3Z54ZbqLU9GGkNE+Bv41S5 jHaTArKj1jA2hXTnoF+JnyIZOpCvlyn+m9mau3lq0PprQygy/o20YjltGrBjt31GQEJ+ EE7gWGuBUAOOfH/adHuIEKG0qB2zLImFBPmodyG7nJdrHzzSsd3OTUomkJBeeKHlIdR/ 9Q1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P60SQ/CsW1eZndcpQR8AR/xrEVIdL+Rao4L2rbgdhaA=; b=wzvPd65Z4lr1P8SFL7cjC6YCmzQbwq/hOjLswvbsHguKParAiGtb88Y8U7I0IDQFXc +DLgf4pj819j0ubZNflel26YJdjNTbCjsmmQRRgP7RIPaOXyO9G9fiR722Rj6xY3oMP8 doGDg1YiQK5vPqL4TXSUnPS+dLU4sdqMxIiikPJkKPsf/4t6vqvv22ian+5R/fJgVuHB AWJksWqFxD/aVQi85MAEnkSctvEgD64PYp1FVb3yEaGrSqJ64GwWYR5I/eL7u1VQrpCc h0z1NlfgqshDf0Ud6OPDinAxsJq7YKEr/nVz1CatFwACholnV81d0tsB4kcVaYrY8LhI Xp2Q== X-Gm-Message-State: AOAM531J2064ykBuYAoZUMuMWdZMAcRIsoZpUhFA2kPp0BKjjuuNVbgA 4BY1BF4Zo+ipfHj44qnorrk= X-Google-Smtp-Source: ABdhPJwCHzJ7tC9DgCi07ahFY8D4qJ10evt3UqKBcCnZz212piHDTdmcK+JNd5y6GzOPE3C02xNDQw== X-Received: by 2002:ae9:f40b:: with SMTP id y11mr6289972qkl.107.1631463259134; Sun, 12 Sep 2021 09:14:19 -0700 (PDT) Received: from ?IPV6:2600:1700:dfe0:49f0:b198:60c0:9fe:66c9? ([2600:1700:dfe0:49f0:b198:60c0:9fe:66c9]) by smtp.gmail.com with ESMTPSA id y12sm2693999qtj.3.2021.09.12.09.14.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 09:14:18 -0700 (PDT) Message-ID: Date: Sun, 12 Sep 2021 09:14:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers Content-Language: en-US To: Vladimir Oltean , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Linus Walleij , George McCollister , Heiner Kallweit , Russell King , Oleksij Rempel , Michael Grzeschik , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lino Sanfilippo References: <20210912120932.993440-1-vladimir.oltean@nxp.com> <20210912120932.993440-2-vladimir.oltean@nxp.com> From: Florian Fainelli In-Reply-To: <20210912120932.993440-2-vladimir.oltean@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210912_091421_100209_A549C74F X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/12/2021 5:09 AM, Vladimir Oltean wrote: > MDIO-attached devices might have interrupts and other things that might > need quiesced when we kexec into a new kernel. Things are even more > creepy when those interrupt lines are shared, and in that case it is > absolutely mandatory to disable all interrupt sources. > > Moreover, MDIO devices might be DSA switches, and DSA needs its own > shutdown method to unlink from the DSA master, which is a new > requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link > interfaces with the DSA master to get rid of lockdep warnings"). > > So introduce a ->shutdown method in the MDIO device driver structure. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel