From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E7DC6FA82 for ; Thu, 22 Sep 2022 07:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbiIVHYh (ORCPT ); Thu, 22 Sep 2022 03:24:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbiIVHYe (ORCPT ); Thu, 22 Sep 2022 03:24:34 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE34AC41 for ; Thu, 22 Sep 2022 00:24:29 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id z25so13237613lfr.2 for ; Thu, 22 Sep 2022 00:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=MSlRGljboTuGCdg3YEgOuKZBwTHCYcmzhnbgNphcxRdZyyfnwC664T8n53L+7Kb5A1 cBjGVu/xWbq4oUq8SLl+K3rsUKIyb/pAPtYAe6Ak01fZY6SfyZEnTaLs/z3BMKPjkSgv vjmGQIgs1lLjxNx/uTL+ut/giC8XhZcsQwMrTBvzpBex0lB1/0LvbylWJluy/Ic3INLQ SjlutBZR81gnaEMn5Jc0oha2px1AkGagITF9BddZQkinMio1PuFwtZLaGSUmLItkLHzB 1LEDnf+uCMw/DTWJNW0akGZdDtngxnSDEMs68J10o1m+HzEjBBsp1pp6Xc4Uce8MuQ5O YqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=i5wmfGflNhC3ziNAjBpIlsnIBrgt9y/nzT3i4fDcWPRHvm28Z9MoU7lxFFUzasDCzi nFywntq1mvcQXDr3ZxOlrKrPJD5bMHpapu4bqTzAMIPwwh6387GcyP22SLgAKuyePxEW K34wimJLZeMfucLIqq1Z/1E4qy6FZKwEXmS0Vp+IZo2mDx+Gure4oSHoHObWD7JgMt9M 6gYU9QNQAjFAa9veM2bwWXgCyRApcPKZD/qwQoB3EWxdjPOlgZPi+/VUOi7w/lYqgdX+ cm8nNSrkB+VUuT1XZYZD0jkALhRJcP7SVQKl7Jjg2YUhw3h9+7d32DigUfXHJGxMkXGU N9Ow== X-Gm-Message-State: ACrzQf1meCcN/iaGvQnloQRuixpFBgg0nkfNMLr+M1zpsbWoixA0rfUB kqDAGLFVWu3UW2eQXNezD9HCKA== X-Google-Smtp-Source: AMsMyM5zA8VBFZmHafhekY2Y0dpCwQNF2kNCm9Hgz6tvQd/1QC+mRy8x/sO+uaHu1Mn31n8rO9wtGA== X-Received: by 2002:a05:6512:370c:b0:49f:c4fb:8706 with SMTP id z12-20020a056512370c00b0049fc4fb8706mr723544lfr.635.1663831468306; Thu, 22 Sep 2022 00:24:28 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j5-20020a2e6e05000000b0026c59d3f557sm769428ljc.33.2022.09.22.00.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:24:27 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 09:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support Content-Language: en-US To: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-11-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220919-v1-11-4844816c9808@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet > +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > + ddc = devm_kzalloc(dev, sizeof(struct mtk_hdmi_ddc), GFP_KERNEL); > + if (!ddc) > + return -ENOMEM; > + > + ddc->regs = syscon_regmap_lookup_by_compatible("mediatek,mt8195-hdmi"); That's not how you get regmaps. If you the driver grows, are you going to grow the list to e.g. 10 syscon_regmap_lookup_by_compatible() calls? This has to be by phandle. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5551CC6FA8B for ; Thu, 22 Sep 2022 07:25:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA00410EA59; Thu, 22 Sep 2022 07:25:09 +0000 (UTC) Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEAB410E0CE for ; Thu, 22 Sep 2022 07:24:29 +0000 (UTC) Received: by mail-lf1-x133.google.com with SMTP id k10so13211105lfm.4 for ; Thu, 22 Sep 2022 00:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=MSlRGljboTuGCdg3YEgOuKZBwTHCYcmzhnbgNphcxRdZyyfnwC664T8n53L+7Kb5A1 cBjGVu/xWbq4oUq8SLl+K3rsUKIyb/pAPtYAe6Ak01fZY6SfyZEnTaLs/z3BMKPjkSgv vjmGQIgs1lLjxNx/uTL+ut/giC8XhZcsQwMrTBvzpBex0lB1/0LvbylWJluy/Ic3INLQ SjlutBZR81gnaEMn5Jc0oha2px1AkGagITF9BddZQkinMio1PuFwtZLaGSUmLItkLHzB 1LEDnf+uCMw/DTWJNW0akGZdDtngxnSDEMs68J10o1m+HzEjBBsp1pp6Xc4Uce8MuQ5O YqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=IdS5gbgVAEpS6PEdalDsvBPtFSJIO/RqYjzfiooLtjlO4bpQVfpM2UrP8WFW2IXdj4 mAYzhG4wDCh1okR6GZk+yhSiNf2KGD6TdWNDwJ+9e2zf6zz6L/+WR9gTWmTm7Hmzrc/W lY7/S2kYXq5QdzG+5htn/8S4aBAn3732FlTmQYqR6fC8wm9wA42qybd3YkVoTSqSOOn5 3oihWUVFv4e10nfLgr7lcGynUDt4OCzqWO4Q0zZJPt48vdbLwkkq68mz0vArmQut0eBC Pmrijf0WS/HqQiArDKYB9l2vOCpYwuIbrLS77/6nPXdlUOT/oDbJJAEzOo6G7X455+XB 3P0A== X-Gm-Message-State: ACrzQf2quzJU8nUUTpH+graZEofXuJ7G2qWV6VgX0sSXcQBkje63iKYY bYg79F1wwfgO9pXE/qU/43VtOw== X-Google-Smtp-Source: AMsMyM5zA8VBFZmHafhekY2Y0dpCwQNF2kNCm9Hgz6tvQd/1QC+mRy8x/sO+uaHu1Mn31n8rO9wtGA== X-Received: by 2002:a05:6512:370c:b0:49f:c4fb:8706 with SMTP id z12-20020a056512370c00b0049fc4fb8706mr723544lfr.635.1663831468306; Thu, 22 Sep 2022 00:24:28 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j5-20020a2e6e05000000b0026c59d3f557sm769428ljc.33.2022.09.22.00.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:24:27 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 09:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support Content-Language: en-US To: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-11-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220919-v1-11-4844816c9808@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet > +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > + ddc = devm_kzalloc(dev, sizeof(struct mtk_hdmi_ddc), GFP_KERNEL); > + if (!ddc) > + return -ENOMEM; > + > + ddc->regs = syscon_regmap_lookup_by_compatible("mediatek,mt8195-hdmi"); That's not how you get regmaps. If you the driver grows, are you going to grow the list to e.g. 10 syscon_regmap_lookup_by_compatible() calls? This has to be by phandle. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DCF3C6FA82 for ; Thu, 22 Sep 2022 07:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gGnXScDV8PB8TmLlu/Eu18FztTls32WxQhFehHLQQGg=; b=OyLS8rVO/deGFJ eC+DoUP4Oc7LTAC0kv8MqoOZaOv3Q4g0/+0122PU/j0UC5PfMst8iR1q8Zl92OkyQKJclI13MOPlk /Gex5vEBVvK2rullNYHBMaqzttOjIJdDwNbCVAfTHfO4gxw6FP55xsbF8l0velgWhpZleGl0aUAUQ mcnla69ufEmlhWceY/vmXuTsIsVDK7CuruaFIKQK09NlekBGsOIZI3pQjnFtGm7lPgU5FJwUCotHi BO7ntC39+AqkCS+CLltaU0/6PmPhpqHLZ5gr304jmdjsII4XSbL6+nSATgfQsrBY9bge0McKFT8uL JVU62/8aG1mrI2tPWYtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obGZU-00Doc7-KU; Thu, 22 Sep 2022 07:24:32 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obGZR-00DoZq-Ty for linux-phy@lists.infradead.org; Thu, 22 Sep 2022 07:24:31 +0000 Received: by mail-lf1-x12d.google.com with SMTP id o2so13174042lfc.10 for ; Thu, 22 Sep 2022 00:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=MSlRGljboTuGCdg3YEgOuKZBwTHCYcmzhnbgNphcxRdZyyfnwC664T8n53L+7Kb5A1 cBjGVu/xWbq4oUq8SLl+K3rsUKIyb/pAPtYAe6Ak01fZY6SfyZEnTaLs/z3BMKPjkSgv vjmGQIgs1lLjxNx/uTL+ut/giC8XhZcsQwMrTBvzpBex0lB1/0LvbylWJluy/Ic3INLQ SjlutBZR81gnaEMn5Jc0oha2px1AkGagITF9BddZQkinMio1PuFwtZLaGSUmLItkLHzB 1LEDnf+uCMw/DTWJNW0akGZdDtngxnSDEMs68J10o1m+HzEjBBsp1pp6Xc4Uce8MuQ5O YqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=p8U+jVMGM5q/rlCIcFVaveTUmEXQRqPCcN1wo6GfaK56rUmlelSuaCGu31MmiqlRnj kzTIMr9PjoDPSSPy1yeL6IIs6UkEuRKrtDeIGckZct1Uq+5ihywSVxrW7JzIWL1iTHJY monT//R9I4uqn8tygo181A+8/1hSYdRZTIE8ZSAY/Bm0q9ZkhA8+krwMY9qqnF+gIE9y AFSCOjFSVf9R1ZnU+lSSv7B483JuyhjP+jt5o/IAyx02gk+Ql6Hj5l+IDNKsodwELVpa vgcXmS3GiasGPphOkrsM8Zd+ASzjIwosDrel69+8NgfPzUqrCoiVaXfZG2p/mxCJWlxk KzNQ== X-Gm-Message-State: ACrzQf2XdVZUxiv4ufgyYyI8XS3dpbWalRHFroIrY9fwGfjU6uJr71RL NNVOv2ASq+XnD9yVUfJqQKdPrw== X-Google-Smtp-Source: AMsMyM5zA8VBFZmHafhekY2Y0dpCwQNF2kNCm9Hgz6tvQd/1QC+mRy8x/sO+uaHu1Mn31n8rO9wtGA== X-Received: by 2002:a05:6512:370c:b0:49f:c4fb:8706 with SMTP id z12-20020a056512370c00b0049fc4fb8706mr723544lfr.635.1663831468306; Thu, 22 Sep 2022 00:24:28 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j5-20020a2e6e05000000b0026c59d3f557sm769428ljc.33.2022.09.22.00.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:24:27 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 09:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support Content-Language: en-US To: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-11-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220919-v1-11-4844816c9808@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_002430_009566_CBE4BDA6 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet > +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > + ddc = devm_kzalloc(dev, sizeof(struct mtk_hdmi_ddc), GFP_KERNEL); > + if (!ddc) > + return -ENOMEM; > + > + ddc->regs = syscon_regmap_lookup_by_compatible("mediatek,mt8195-hdmi"); That's not how you get regmaps. If you the driver grows, are you going to grow the list to e.g. 10 syscon_regmap_lookup_by_compatible() calls? This has to be by phandle. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2618C6FA82 for ; Thu, 22 Sep 2022 07:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fbsGx5K2esGF9g0hUnDbrG29/gA3UVBNCW76W0VM7kc=; b=3hrBbaJd6k+MjZ vJDv53QC5TY0foMBFlQ0ohZ4bgFkaXjDIMNmmYuowrC+TFG4XDY2FtrvqSdqVPf27fVjbbFFD/YU5 ykyxzZIjgIR1mv9fXS6BXXFsDR5vQg0OEw5d/5nohKbjJR/4en/tdbhULzssaC4eRurWh58H8oB8R ca4aMv7Y4aBe1DFTnlEYni0lzxPzdehEpZDjYOB4s3kl0HAhVsKeTST2Y7epnbZR5xnHOEFpbbyWz bd/rgkTqA/kjvwU1RiGbyv6k4tUC//Njru/j0g6oc5S/dq48aAqee5lzdMJAZQQsZQ0Kbjny0SQp5 yr1v9yfx8I28bEpRtnLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obGZV-00DocG-G9; Thu, 22 Sep 2022 07:24:33 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obGZR-00DoZr-Tw for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 07:24:31 +0000 Received: by mail-lf1-x133.google.com with SMTP id f9so13210714lfr.3 for ; Thu, 22 Sep 2022 00:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=MSlRGljboTuGCdg3YEgOuKZBwTHCYcmzhnbgNphcxRdZyyfnwC664T8n53L+7Kb5A1 cBjGVu/xWbq4oUq8SLl+K3rsUKIyb/pAPtYAe6Ak01fZY6SfyZEnTaLs/z3BMKPjkSgv vjmGQIgs1lLjxNx/uTL+ut/giC8XhZcsQwMrTBvzpBex0lB1/0LvbylWJluy/Ic3INLQ SjlutBZR81gnaEMn5Jc0oha2px1AkGagITF9BddZQkinMio1PuFwtZLaGSUmLItkLHzB 1LEDnf+uCMw/DTWJNW0akGZdDtngxnSDEMs68J10o1m+HzEjBBsp1pp6Xc4Uce8MuQ5O YqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=rXc0JsJL5R5k61U+h4daO0ny5cYRjhWgWURdCeIxKfL6QTnyZrgMpKreWAiQ1Y5Abw QgCRJPtiZ7x6OvsqXstSBkrcPLYG9tPrOo1J7BlTA9FmLDmCrwsbklYI655H8DUahubh ECC9+LeoD9TjnEE6CRNQ47PQeVt/mWrhO58IU2D4AxAiJGMkpCzF/OOE9HZu9ihL2YwW ersMWd3aZgaJvp1xL6MKkHMED0ThIqow/mfUH5rKE8SHWHrJHemK8/ysUHXKojFRS2mw 7TpgfLxf6ZHQX6CWFnsz72pcDBH+M4asyggDkknvZ2HgHT6oV8+zrsK8kS+OALZGv+Kp VSrQ== X-Gm-Message-State: ACrzQf2I0le08O5P5CqLcuf5+kw8PTwIpGX/ocZKXNdpMIc/r4oS5rDG GMzBUl4QFPqWXujjjmVp5pALNQ== X-Google-Smtp-Source: AMsMyM5zA8VBFZmHafhekY2Y0dpCwQNF2kNCm9Hgz6tvQd/1QC+mRy8x/sO+uaHu1Mn31n8rO9wtGA== X-Received: by 2002:a05:6512:370c:b0:49f:c4fb:8706 with SMTP id z12-20020a056512370c00b0049fc4fb8706mr723544lfr.635.1663831468306; Thu, 22 Sep 2022 00:24:28 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j5-20020a2e6e05000000b0026c59d3f557sm769428ljc.33.2022.09.22.00.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:24:27 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 09:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support Content-Language: en-US To: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-11-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220919-v1-11-4844816c9808@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_002430_012300_48F98ABE X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet > +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > + ddc = devm_kzalloc(dev, sizeof(struct mtk_hdmi_ddc), GFP_KERNEL); > + if (!ddc) > + return -ENOMEM; > + > + ddc->regs = syscon_regmap_lookup_by_compatible("mediatek,mt8195-hdmi"); That's not how you get regmaps. If you the driver grows, are you going to grow the list to e.g. 10 syscon_regmap_lookup_by_compatible() calls? This has to be by phandle. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel