From mboxrd@z Thu Jan 1 00:00:00 1970 From: sagi@grimberg.me (Sagi Grimberg) Date: Wed, 15 Feb 2017 18:28:32 +0200 Subject: [PATCH] nvmet: Avoid writing fabric_ops, queue pointers on every request. In-Reply-To: <20170215161523.GA27837@lst.de> References: <1486507066-23168-1-git-send-email-parav@mellanox.com> <5bcb5982-36a6-67f5-8416-45e321235fa9@grimberg.me> <700fde5d-3b84-2279-4176-c871364d4b97@grimberg.me> <20170215161523.GA27837@lst.de> Message-ID: >> Yep, forgot that the sq/cq are referenced from the rsp which is >> per-queue. >> >> Christoph, James, can I get an ack from you guys? > > I really hate the nvmet_req_fabric_ops_init and > nvmet_req_link_to_nvme_queues helpers, just use direct assignments > instead of trivial helpers with crazy long names. Heh, I don't mind it all that much, but we can hold it off until something better (if at all) comes along..