From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ziji Hu Subject: Re: [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller Date: Thu, 22 Dec 2016 20:47:07 +0800 Message-ID: References: <20161222111802.GX14217@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:40553 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966312AbcLVMr4 (ORCPT ); Thu, 22 Dec 2016 07:47:56 -0500 In-Reply-To: <20161222111802.GX14217@n2100.armlinux.org.uk> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Russell King - ARM Linux , Gregory CLEMENT Cc: Ulf Hansson , Adrian Hunter , linux-mmc@vger.kernel.org, Thomas Petazzoni , Andrew Lunn , Yehuda Yitschak , Marcin Wojtas , Jason Cooper , Hanna Hawa , Kostya Porotchkin , Nadav Haklai , Jimmy Xu , Doug Jones , Ryan Gao , Jisheng Zhang , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Hi Russell, On 2016/12/22 19:18, Russell King - ARM Linux wrote: > On Tue, Dec 13, 2016 at 06:48:35PM +0100, Gregory CLEMENT wrote: >> +Optional Properties: >> +- mmc-card: >> + mmc-card child node must be provided when current SDHC is for eMMC. >> + Xenon SDHC often can support both SD and eMMC. This child node indicates that >> + current SDHC is for eMMC card. Thus Xenon eMMC specific configuration and >> + operations can be enabled prior to eMMC init sequence. >> + Please refer to Documentation/devicetree/bindings/mmc/mmc-card.txt. >> + This child node should not be set if current Xenon SDHC is for SD/SDIO. > > This looks like a typo - shouldn't it be "mmccard" and not "mmc-card"? > Your examples below use "mmccard" as does the documentation you point > towards. > Thanks a lot for the review. I might mix up it with compatible "mmc-card". I will change it to sub-node name in next version soon. Thank you. Best regards, Hu Ziji From mboxrd@z Thu Jan 1 00:00:00 1970 From: huziji@marvell.com (Ziji Hu) Date: Thu, 22 Dec 2016 20:47:07 +0800 Subject: [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller In-Reply-To: <20161222111802.GX14217@n2100.armlinux.org.uk> References: <20161222111802.GX14217@n2100.armlinux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell, On 2016/12/22 19:18, Russell King - ARM Linux wrote: > On Tue, Dec 13, 2016 at 06:48:35PM +0100, Gregory CLEMENT wrote: >> +Optional Properties: >> +- mmc-card: >> + mmc-card child node must be provided when current SDHC is for eMMC. >> + Xenon SDHC often can support both SD and eMMC. This child node indicates that >> + current SDHC is for eMMC card. Thus Xenon eMMC specific configuration and >> + operations can be enabled prior to eMMC init sequence. >> + Please refer to Documentation/devicetree/bindings/mmc/mmc-card.txt. >> + This child node should not be set if current Xenon SDHC is for SD/SDIO. > > This looks like a typo - shouldn't it be "mmccard" and not "mmc-card"? > Your examples below use "mmccard" as does the documentation you point > towards. > Thanks a lot for the review. I might mix up it with compatible "mmc-card". I will change it to sub-node name in next version soon. Thank you. Best regards, Hu Ziji