From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>, qemu-devel@nongnu.org
Subject: Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named()
Date: Thu, 18 Feb 2021 10:14:12 +0100 [thread overview]
Message-ID: <c7872ca9-4eb9-805c-2fdc-ceda65b89e5a@redhat.com> (raw)
In-Reply-To: <2503182.7bSAqF82In@silver>
On 18/02/21 10:10, Christian Schoenebeck wrote:
> On Montag, 15. Februar 2021 15:06:41 CET Christian Schoenebeck wrote:
>> On Montag, 15. Februar 2021 14:16:16 CET Paolo Bonzini wrote:
>>> From: qemu_oss--- via <qemu-devel@nongnu.org>
>>>
>>> So far the qos subsystem of the qtest framework had the limitation
>>> that only one instance of the same official QEMU (QMP) driver name
>>> could be created for qtests. That's because a) the created qos
>>> node names must always be unique, b) the node name must match the
>>> official QEMU driver name being instantiated and c) all nodes are
>>> in a global space shared by all tests.
>>>
>>> This patch removes this limitation by introducing a new function
>>> qos_node_create_driver_named() which allows test case authors to
>>> specify a node name being different from the actual associated
>>> QEMU driver name. It fills the new 'qemu_name' field of
>>> QOSGraphNode for that purpose.
>>>
>>> Adjust build_driver_cmd_line() and qos_graph_node_set_availability()
>>> to correctly deal with either accessing node name vs. node's
>>> qemu_name correctly.
>>>
>>> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
>>> Message-Id:
>>> <3be962ff38f3396f8040deaa5ffdab525c4e0b16.1611704181.git.qemu_oss@crudebyt
>>> e
>>> .com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Just a side note: The odd "From:" line was because of a temporary issue with
>> the mailman version running GNU lists, which caused mailman to rewrite
>> certain sender addresses. The problem with mailman had been fixed in the
>> meantime.
>>
>> I personally don't care about it, but just that you know that this did not
>> happen by purpose or something.
>
> Paolo, do you want me to resend these patches as v2 for fixing the author
> rewrite issue?
The patches already in and with the right author.
Paolo
next prev parent reply other threads:[~2021-02-18 9:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 13:16 [PULL 00/19] i386, qgraph patches for 2020-02-15 Paolo Bonzini
2021-02-15 13:16 ` [PULL 01/19] pc: add parser for OVMF reset block Paolo Bonzini
2021-02-15 13:16 ` [PULL 02/19] sev: update sev-inject-launch-secret to make gpa optional Paolo Bonzini
2021-05-20 21:36 ` Philippe Mathieu-Daudé
2021-05-20 22:19 ` James Bottomley
2021-05-21 11:34 ` Philippe Mathieu-Daudé
2021-02-15 13:16 ` [PULL 03/19] sev/i386: Add initial support for SEV-ES Paolo Bonzini
2021-02-15 13:16 ` [PULL 04/19] sev/i386: Require in-kernel irqchip support for SEV-ES guests Paolo Bonzini
2021-02-15 13:16 ` [PULL 05/19] sev/i386: Allow AP booting under SEV-ES Paolo Bonzini
2021-02-15 13:16 ` [PULL 06/19] sev/i386: Don't allow a system reset under an SEV-ES guest Paolo Bonzini
2021-02-15 13:16 ` [PULL 07/19] kvm/i386: Use a per-VM check for SMM capability Paolo Bonzini
2021-02-15 13:16 ` [PULL 08/19] sev/i386: Enable an SEV-ES guest based on SEV policy Paolo Bonzini
2021-02-15 13:16 ` [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named() Paolo Bonzini
2021-02-15 14:06 ` Christian Schoenebeck
2021-02-18 9:10 ` Christian Schoenebeck
2021-02-18 9:14 ` Paolo Bonzini [this message]
2021-02-18 9:23 ` Christian Schoenebeck
2021-02-15 13:16 ` [PULL 10/19] libqos/qgraph_internal: add qos_printf() and qos_printf_literal() Paolo Bonzini
2021-02-15 13:16 ` [PULL 11/19] tests/qtest/qos-test: dump qos graph if verbose Paolo Bonzini
2021-02-15 13:16 ` [PULL 12/19] tests/qtest/qos-test: dump environment variables " Paolo Bonzini
2021-02-15 13:16 ` [PULL 13/19] tests/qtest/qos-test: dump QEMU command " Paolo Bonzini
2021-02-15 13:16 ` [PULL 14/19] util/cutils: Skip "." when looking for next directory component Paolo Bonzini
2021-02-15 13:16 ` [PULL 15/19] hvf: Guard xgetbv call Paolo Bonzini
2021-02-15 13:16 ` [PULL 16/19] target/i386/hvf: add vmware-cpuid-freq cpu feature Paolo Bonzini
2021-02-15 13:16 ` [PULL 17/19] hvf: x86: Remove unused definitions Paolo Bonzini
2021-02-15 13:16 ` [PULL 18/19] target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT Paolo Bonzini
2021-02-15 13:16 ` [PULL 19/19] hvf: Fetch cr4 before evaluating CPUID(1) Paolo Bonzini
2021-02-15 13:29 ` [PULL 00/19] i386, qgraph patches for 2020-02-15 Thomas Huth
2021-02-15 13:30 ` Philippe Mathieu-Daudé
2021-02-15 13:43 ` no-reply
2021-02-15 21:13 ` Eric Blake
2021-02-16 14:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7872ca9-4eb9-805c-2fdc-ceda65b89e5a@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.