From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71CFCC433EF for ; Wed, 15 Jun 2022 16:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345699AbiFOQKH (ORCPT ); Wed, 15 Jun 2022 12:10:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232224AbiFOQKG (ORCPT ); Wed, 15 Jun 2022 12:10:06 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4DB82A94D for ; Wed, 15 Jun 2022 09:10:05 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id f65so11783943pgc.7 for ; Wed, 15 Jun 2022 09:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=AGXMHAfFawM437d2xbjGn7zTyG/qjpog4xd0dnEFlIg=; b=ELrb+58SZ4RRVFmeo0lDvjv47zdVsU/ClHMLv/kcFL6JKL1jmU5MyxdZo1v4F/v9eg p7AwNo6AI3Jfw2SwocMTwDKwmv/uZdMWd3L7M5U33KE+oV3m6miN2VRo47xJu8Wksotg iaRVBcFo0fAQnc4uCw991KIutWaLFTf8NI7Gb2mw0YjxTBzX7Yoq+BCcq6KzXV0P9Rl7 08PYQCKQPBh7XJ3uzczwxcOMXoV5VPWqu+eGdN5j4hFFbEYu0rD0FaPqdxuyE+46uZEH qktVnHR2FRtu+R6lBp45UeaS61eyTPve40fOf9rRnj6UGCL9zbH9MSny2cm8esGENkkc AZEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AGXMHAfFawM437d2xbjGn7zTyG/qjpog4xd0dnEFlIg=; b=6mrikdleDcFR1GxwKUaFpxx85RjuXAIpN3eL9dFJ/sVeXqvAzr+lpwRMS12sIJL7Wq BQCioLW0Ickbh7UJXJPxQDatZfAHTnDjXHQ10vPmcKlquQILR9DiVWBINmKUQEZH1iUN LE4oqObkTKVXXYsEQkYobM9lSOCvwpaJ8dOL89yArV3GcZKhEkTGqqXnLsH0BIicSOHa g+gw7DAFGL+ESHrlftitPwhscTiuwDhmOXDiWwqHxWjYAmW1rwUHxUB4y+8OLZ6xCStq tsvoyc2NwCI/11zM7aCTmlCUOv4snsPLPMjsgs4sLwnLnZFL3MUvgq54/+FNEMnp4kmo ZsdQ== X-Gm-Message-State: AJIora/DsIfdoy6WVuCj2A8OPV0HTjx8MtDZZvMb+zDrMqDy0krk2CVs Anb6qbqxHLvlez4q8Wuu3sw= X-Google-Smtp-Source: AGRyM1thv/7xzTABPs1GV756Nc/sGCMV361AeTQGj6liZHtwY/h4Qq0gg/prvco/LEv2/FoQc+iqzw== X-Received: by 2002:a63:c5:0:b0:3fe:26a0:7abe with SMTP id 188-20020a6300c5000000b003fe26a07abemr505846pga.152.1655309405114; Wed, 15 Jun 2022 09:10:05 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id k6-20020a17090a910600b001e31c7aad6fsm1966924pjo.20.2022.06.15.09.10.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jun 2022 09:10:04 -0700 (PDT) Message-ID: Date: Wed, 15 Jun 2022 09:10:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 11/22] firmware: arm_scmi: Add SCMIv3.1 extended names protocols support Content-Language: en-US To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com References: <20220330150551.2573938-1-cristian.marussi@arm.com> <20220330150551.2573938-12-cristian.marussi@arm.com> <6f865d7f-fde8-d923-3c7e-d12bfbc370a6@gmail.com> From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/22 02:40, Cristian Marussi wrote: > On Wed, Jun 15, 2022 at 09:18:03AM +0100, Cristian Marussi wrote: >> On Wed, Jun 15, 2022 at 05:45:11AM +0200, Florian Fainelli wrote: >>> >>> >>> On 3/30/2022 5:05 PM, Cristian Marussi wrote: >>>> Using the common protocol helper implementation add support for all new >>>> SCMIv3.1 extended names commands related to all protocols with the >>>> exception of SENSOR_AXIS_GET_NAME. >>>> >>>> Signed-off-by: Cristian Marussi >>> >>> This causes the following splat on a platform where regulators fail to >>> initialize: >>> >> >> Hi Florian, >> >> thanks for the report. >> >> It seems a memory error while allocating so it was not meant to be >> solved by the fixes, anyway, I've never seen this splat in my testing >> and at first sight I cannot see anything wrong in the devm_k* calls >> inside scmi_voltage_protocol_init...is there any particular config in >> your setup ? >> >> Moreover, the WARNING line 5402 seems to match v5.19-rc1 and it has >> slightly changed with -rc-1, so I'll try rebasing on that at first and >> see if I can reproduce the issue locally. >> > > I just re-tested the series rebased on v519-rc1 plus fixes and I cannot > reproduce in my setup with a few (~9) good and bad voltage domains. > > How many voltage domains are advertised by the platform in your setup ? There are 11 voltage regulators on this platform, and of course, now that I am trying to reproduce the splat I reported I just cannot anymore... I will let you know if there is anything that needs to be done. Thanks for being responsive as usual! -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6241BC433EF for ; Wed, 15 Jun 2022 16:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AogShGFLB6sxn/HOlw3glrYP6OPwnQvHDxcZ2G8zwNs=; b=4giRr3xSzx7EVx H3MX8J9oC0dBKILP5e6Vad5EZU8bt6WuW4MUEYaIU+M7JIwbGBKl8PF4nJ1CMC9Yef/s1pB5qwkT6 aZcBt4XqIanMJ3qwGA2xlBeEjF5YBbSs+3rriIzUmfsmOId7fMLf3Sfb/qD8OOkldtFvXCDuQY5jJ kUlRwJPM2QumzLhd3ira2r3rBnMJABdN6EgsHKULpUHjSmnV+xapHu1jLZ2qyM3K5oz7pFi6LTMt2 fMEIrEvd27LBoJ9MpldhW3VsnY8/NVGA9dq/4ihvvFmkTAJWVmkHyq91/uCqmKJ/Jd/hFOZ8v5C/d gvTTleaA/GsDjA4+K7hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Vas-00FIjZ-3g; Wed, 15 Jun 2022 16:10:10 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Vao-00FIij-Ee for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 16:10:07 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 31so10141083pgv.11 for ; Wed, 15 Jun 2022 09:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=AGXMHAfFawM437d2xbjGn7zTyG/qjpog4xd0dnEFlIg=; b=ELrb+58SZ4RRVFmeo0lDvjv47zdVsU/ClHMLv/kcFL6JKL1jmU5MyxdZo1v4F/v9eg p7AwNo6AI3Jfw2SwocMTwDKwmv/uZdMWd3L7M5U33KE+oV3m6miN2VRo47xJu8Wksotg iaRVBcFo0fAQnc4uCw991KIutWaLFTf8NI7Gb2mw0YjxTBzX7Yoq+BCcq6KzXV0P9Rl7 08PYQCKQPBh7XJ3uzczwxcOMXoV5VPWqu+eGdN5j4hFFbEYu0rD0FaPqdxuyE+46uZEH qktVnHR2FRtu+R6lBp45UeaS61eyTPve40fOf9rRnj6UGCL9zbH9MSny2cm8esGENkkc AZEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AGXMHAfFawM437d2xbjGn7zTyG/qjpog4xd0dnEFlIg=; b=pOIWmqN/myXjQaFHNw8A6ajKGJrjyeMJ+Klu2wNDVfob4uDNY4Mz6JD7y6rHTlpMjy e7Guf8eStej8RgCHkCkDMXgyIgnY86TVo22Iho7Lp/vJvEGfg41yKKaghp0w5USr6VMD /zlUH010AGW0uVuO0woQ2kf3P8zpCcYeiO9lhVxK91TiyTrq1zozFiMiddJX6bbRjCEg TfGbTpG4be09wdLkaSyjXfChEgT5eQaQFifhpSG/XtKmD4UnQWcQp5izN433oFoaF6x5 VQEXBlmIkBm3Qtj08uK5ZZP3+gDH+hr1y31qaaP7x6uWFNCbjD4iaclgGjtNlwSxgxhq ymqg== X-Gm-Message-State: AJIora/Oz9i3S+qbuJTwuAvVInIf3gcWnCHoolbuXOmQeTkJoFax4flN GBaORrFC9ro5hvi/1r+/aB8= X-Google-Smtp-Source: AGRyM1thv/7xzTABPs1GV756Nc/sGCMV361AeTQGj6liZHtwY/h4Qq0gg/prvco/LEv2/FoQc+iqzw== X-Received: by 2002:a63:c5:0:b0:3fe:26a0:7abe with SMTP id 188-20020a6300c5000000b003fe26a07abemr505846pga.152.1655309405114; Wed, 15 Jun 2022 09:10:05 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id k6-20020a17090a910600b001e31c7aad6fsm1966924pjo.20.2022.06.15.09.10.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jun 2022 09:10:04 -0700 (PDT) Message-ID: Date: Wed, 15 Jun 2022 09:10:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 11/22] firmware: arm_scmi: Add SCMIv3.1 extended names protocols support Content-Language: en-US To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com References: <20220330150551.2573938-1-cristian.marussi@arm.com> <20220330150551.2573938-12-cristian.marussi@arm.com> <6f865d7f-fde8-d923-3c7e-d12bfbc370a6@gmail.com> From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_091006_543195_5FC76FF8 X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/15/22 02:40, Cristian Marussi wrote: > On Wed, Jun 15, 2022 at 09:18:03AM +0100, Cristian Marussi wrote: >> On Wed, Jun 15, 2022 at 05:45:11AM +0200, Florian Fainelli wrote: >>> >>> >>> On 3/30/2022 5:05 PM, Cristian Marussi wrote: >>>> Using the common protocol helper implementation add support for all new >>>> SCMIv3.1 extended names commands related to all protocols with the >>>> exception of SENSOR_AXIS_GET_NAME. >>>> >>>> Signed-off-by: Cristian Marussi >>> >>> This causes the following splat on a platform where regulators fail to >>> initialize: >>> >> >> Hi Florian, >> >> thanks for the report. >> >> It seems a memory error while allocating so it was not meant to be >> solved by the fixes, anyway, I've never seen this splat in my testing >> and at first sight I cannot see anything wrong in the devm_k* calls >> inside scmi_voltage_protocol_init...is there any particular config in >> your setup ? >> >> Moreover, the WARNING line 5402 seems to match v5.19-rc1 and it has >> slightly changed with -rc-1, so I'll try rebasing on that at first and >> see if I can reproduce the issue locally. >> > > I just re-tested the series rebased on v519-rc1 plus fixes and I cannot > reproduce in my setup with a few (~9) good and bad voltage domains. > > How many voltage domains are advertised by the platform in your setup ? There are 11 voltage regulators on this platform, and of course, now that I am trying to reproduce the splat I reported I just cannot anymore... I will let you know if there is anything that needs to be done. Thanks for being responsive as usual! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel