From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CA2C433FE for ; Mon, 31 Jan 2022 15:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379379AbiAaPVr (ORCPT ); Mon, 31 Jan 2022 10:21:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241253AbiAaPVr (ORCPT ); Mon, 31 Jan 2022 10:21:47 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C326EC061714; Mon, 31 Jan 2022 07:21:46 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id e81so27254954oia.6; Mon, 31 Jan 2022 07:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:content-language:to :cc:references:from:subject:in-reply-to:content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=NXQ2vh5WqJcNrwvi+uhxOeXRwL3TuQvr8zI74nXKNlbA4THVcrFQe20l84a2F3rCSl fb+2O3VmewcReatZ19klOskQ2upf6qljRrD6n2B9Y4PhroYWW+XOfsdsfB3MZuirxQ9t X+vPYa1ikH13JYbnSKqVdMeH1jmxa4D6k59/FHZubOFHJbDfNxiaB8VfMIjtaMgLtJV+ 3A2GEeuqlrodVHjFD7y9lvjUf+N31nBGTmFabP1WX1nvXw95IBSd2qgNRGX0BxRvAmns 3J8DZp0qcC/r7rrsLbS0TgQNcR7BR3VDw0NU5D6j9PO9dXHpEDeoVqLmRligf9NcdWA6 MSIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=KywFr/OqYMsf3qiaElSRqlSWv6PhIuJkZBMaeZcZmCrMnwj09ZfcYxqGtcZ+jVolwZ KlB7ay/40xZ+j8S3irzoABlLB3gcmKr4gNvKvocXi2Wod3WPESxpYfZHJ8de7p88QCxr DrqidW7OpNKBtFJhjdth2pyPrGFKzwWo0mqOeP5hanlcFKmHpoWEjJ/ZSpDt4hLEEhfP R6a/d9heCj46D9wqtCpIj8AGC8RpskMOJp91B2Unpt5xFqa6B0xTpIxhdronb+AOoDEu 5ht0V9CuMBAg+mOWDvkV9Wy0viP80Al/upgtdU5avyipYryyvjlt+i7C2JQirSaoCNgZ t9kg== X-Gm-Message-State: AOAM530Cl83PjeZaRDrEZUBsw/MaSrRs2zOSzgRdmn2ZDhWPsHTdcd49 SRu7+VoFIDWdA/ppoXmtVwM= X-Google-Smtp-Source: ABdhPJwZ2DsfGoZh9WlCulrelJMyxXaQWZM7t1bPVVjVsAMl6JMrpJ5ac6K1xcqWaqkMGtPCEBWrHw== X-Received: by 2002:a05:6808:211f:: with SMTP id r31mr12780920oiw.194.1643642506160; Mon, 31 Jan 2022 07:21:46 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d65sm9789045otb.17.2022.01.31.07.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 07:21:44 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Mon, 31 Jan 2022 07:21:40 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Thomas Gleixner Cc: LKML , Nishanth Menon , Mark Rutland , Stuart Yoder , Benjamin Herrenschmidt , Will Deacon , Ashok Raj , Michael Ellerman , Jassi Brar , Sinan Kaya , iommu@lists.linux-foundation.org, Peter Ujfalusi , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Jason Gunthorpe , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Kevin Tian , Arnd Bergmann , Robin Murphy , Alex Williamson , Cedric Le Goater , Santosh Shilimkar , Bjorn Helgaas , Megha Dey , Juergen Gross , Tero Kristo , Greg Kroah-Hartman , Vinod Koul , Marc Zygnier , dmaengine@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <87mtjc2lhe.ffs@tglx> From: Guenter Roeck Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity() In-Reply-To: <87mtjc2lhe.ffs@tglx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 1/31/22 03:27, Thomas Gleixner wrote: > On Sun, Jan 30 2022 at 09:12, Guenter Roeck wrote: >> On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: >> This patch results in the following runtime warning when booting x86 >> (32 bit) nosmp images from NVME in qemu. >> >> [ 14.825482] nvme nvme0: 1/0/0 default/read/poll queues >> ILLOPC: ca7c6d10: 0f 0b >> [ 14.826188] ------------[ cut here ]------------ >> [ 14.826307] WARNING: CPU: 0 PID: 7 at drivers/pci/msi/msi.c:1114 pci_irq_get_affinity+0x80/0x90 > > This complains about msi_desc->affinity being NULL. > >> git bisect bad f48235900182d64537c6e8f8dc0932b57a1a0638 >> # first bad commit: [f48235900182d64537c6e8f8dc0932b57a1a0638] PCI/MSI: Simplify pci_irq_get_affinity() > > Hrm. Can you please provide dmesg and /proc/interrupts from a > kernel before that commit? > Sure. Please see http://server.roeck-us.net/qemu/x86/. The logs are generated with with v5.16.4. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3261BC433EF for ; Mon, 31 Jan 2022 15:22:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A0C56408F4; Mon, 31 Jan 2022 15:22:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rj30okA_aEOi; Mon, 31 Jan 2022 15:22:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2AA964038E; Mon, 31 Jan 2022 15:22:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0A1EDC001A; Mon, 31 Jan 2022 15:22:01 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 31816C000B for ; Mon, 31 Jan 2022 15:21:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0F1F0408EB for ; Mon, 31 Jan 2022 15:21:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BAXOPLsTJHSu for ; Mon, 31 Jan 2022 15:21:58 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by smtp2.osuosl.org (Postfix) with ESMTPS id ED8B44038E for ; Mon, 31 Jan 2022 15:21:57 +0000 (UTC) Received: by mail-oi1-x22b.google.com with SMTP id x193so27371257oix.0 for ; Mon, 31 Jan 2022 07:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:content-language:to :cc:references:from:subject:in-reply-to:content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=NXQ2vh5WqJcNrwvi+uhxOeXRwL3TuQvr8zI74nXKNlbA4THVcrFQe20l84a2F3rCSl fb+2O3VmewcReatZ19klOskQ2upf6qljRrD6n2B9Y4PhroYWW+XOfsdsfB3MZuirxQ9t X+vPYa1ikH13JYbnSKqVdMeH1jmxa4D6k59/FHZubOFHJbDfNxiaB8VfMIjtaMgLtJV+ 3A2GEeuqlrodVHjFD7y9lvjUf+N31nBGTmFabP1WX1nvXw95IBSd2qgNRGX0BxRvAmns 3J8DZp0qcC/r7rrsLbS0TgQNcR7BR3VDw0NU5D6j9PO9dXHpEDeoVqLmRligf9NcdWA6 MSIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=yjGLUG0r8Z6wa3NHK3fwDcuy1Yco/tcUzpAWnSMEG08RSboSeJig6kjRUOgsbcI6HY CUoxLaUnXdId+PZ9at/NM3AGu2OKjqEsdi50bkS5HYaIHw5KxGjb9kjiKgh+b0/KZgx2 FfSwMAoBymrxCJszuxK54g+HYhddqkG/KxaBrXSMlki6euKuU1D5rQvjDXZkJxafriB0 hGyA4DFFdk4guuP9vctVhH6KRoDIU77OEBQifgIkUOYiWc22wU9iG7WoLJWCiD+YrlyO 3KGczywaXumleWsuKkM+nG0fO8jZDzCZMVbuOGhrEH+9naMhyrTmquEJk31PkiEfJKzs 7vhw== X-Gm-Message-State: AOAM5304BnpbGVdDdjOm/c/8zg7bj5Z4q4Nu00JhT/3eoz/Kh1+l7HTX vz8LUsYtEJZgZsU5GAMoIcEAx31/w+3Q5Q== X-Google-Smtp-Source: ABdhPJwZ2DsfGoZh9WlCulrelJMyxXaQWZM7t1bPVVjVsAMl6JMrpJ5ac6K1xcqWaqkMGtPCEBWrHw== X-Received: by 2002:a05:6808:211f:: with SMTP id r31mr12780920oiw.194.1643642506160; Mon, 31 Jan 2022 07:21:46 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d65sm9789045otb.17.2022.01.31.07.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 07:21:44 -0800 (PST) Message-ID: Date: Mon, 31 Jan 2022 07:21:40 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Thomas Gleixner References: <87mtjc2lhe.ffs@tglx> From: Guenter Roeck Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity() In-Reply-To: <87mtjc2lhe.ffs@tglx> Cc: Nishanth Menon , Mark Rutland , Stuart Yoder , linux-pci@vger.kernel.org, Will Deacon , Peter Ujfalusi , Ashok Raj , Michael Ellerman , Jassi Brar , Sinan Kaya , Vinod Koul , Bjorn Helgaas , Megha Dey , Jason Gunthorpe , Benjamin Herrenschmidt , xen-devel@lists.xenproject.org, Kevin Tian , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, Alex Williamson , Cedric Le Goater , Santosh Shilimkar , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Juergen Gross , Tero Kristo , Greg Kroah-Hartman , LKML , iommu@lists.linux-foundation.org, Marc Zygnier , dmaengine@vger.kernel.org, Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 1/31/22 03:27, Thomas Gleixner wrote: > On Sun, Jan 30 2022 at 09:12, Guenter Roeck wrote: >> On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: >> This patch results in the following runtime warning when booting x86 >> (32 bit) nosmp images from NVME in qemu. >> >> [ 14.825482] nvme nvme0: 1/0/0 default/read/poll queues >> ILLOPC: ca7c6d10: 0f 0b >> [ 14.826188] ------------[ cut here ]------------ >> [ 14.826307] WARNING: CPU: 0 PID: 7 at drivers/pci/msi/msi.c:1114 pci_irq_get_affinity+0x80/0x90 > > This complains about msi_desc->affinity being NULL. > >> git bisect bad f48235900182d64537c6e8f8dc0932b57a1a0638 >> # first bad commit: [f48235900182d64537c6e8f8dc0932b57a1a0638] PCI/MSI: Simplify pci_irq_get_affinity() > > Hrm. Can you please provide dmesg and /proc/interrupts from a > kernel before that commit? > Sure. Please see http://server.roeck-us.net/qemu/x86/. The logs are generated with with v5.16.4. Guenter _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73F8FC433F5 for ; Mon, 31 Jan 2022 15:22:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JnWyf3wnbz3bc9 for ; Tue, 1 Feb 2022 02:22:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=NXQ2vh5W; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::22d; helo=mail-oi1-x22d.google.com; envelope-from=groeck7@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=NXQ2vh5W; dkim-atps=neutral Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JnWxs02bHz2ywb for ; Tue, 1 Feb 2022 02:21:50 +1100 (AEDT) Received: by mail-oi1-x22d.google.com with SMTP id q8so12754749oiw.7 for ; Mon, 31 Jan 2022 07:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:content-language:to :cc:references:from:subject:in-reply-to:content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=NXQ2vh5WqJcNrwvi+uhxOeXRwL3TuQvr8zI74nXKNlbA4THVcrFQe20l84a2F3rCSl fb+2O3VmewcReatZ19klOskQ2upf6qljRrD6n2B9Y4PhroYWW+XOfsdsfB3MZuirxQ9t X+vPYa1ikH13JYbnSKqVdMeH1jmxa4D6k59/FHZubOFHJbDfNxiaB8VfMIjtaMgLtJV+ 3A2GEeuqlrodVHjFD7y9lvjUf+N31nBGTmFabP1WX1nvXw95IBSd2qgNRGX0BxRvAmns 3J8DZp0qcC/r7rrsLbS0TgQNcR7BR3VDw0NU5D6j9PO9dXHpEDeoVqLmRligf9NcdWA6 MSIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=R8ZB/ZVAEw6MhDSy4PR33ZbGPbUxZrVArRxFMtNDWwpO90NA97+PFG4obSme+txzvv Oul/HeVNuG3/FcOq6dfwB70N+SqveXGl6Q84afk31VsKJxicd7RK2/EqvFHwuCJnCyDL 3+I0EBZ/MaBBKLs5r6ShXCr8Q1hiMdjIyUuNF/zXVzb+pk7tx0JLrEVRZxUxPQGbLG7X MhQaK+7KJP4fHoefUiJTiJ6syht5ngnM8zrqISySgLtAWOUoKuTZn1hrALrJF2vlvbY5 hcFZUKpKFbpQeMnXqfWrViL3DBfREL3P/FsOApYx9kApVuIN8ajjs3Rfmf/7ZCmmZhea mcqA== X-Gm-Message-State: AOAM533YcQ9hj7mt6tsQFZnixwmOuLa90konmwT5/ekclM8kQLhSc3Ao wuBuMZk+0Boc0YX7hp4nAOw= X-Google-Smtp-Source: ABdhPJwZ2DsfGoZh9WlCulrelJMyxXaQWZM7t1bPVVjVsAMl6JMrpJ5ac6K1xcqWaqkMGtPCEBWrHw== X-Received: by 2002:a05:6808:211f:: with SMTP id r31mr12780920oiw.194.1643642506160; Mon, 31 Jan 2022 07:21:46 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d65sm9789045otb.17.2022.01.31.07.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 07:21:44 -0800 (PST) Message-ID: Date: Mon, 31 Jan 2022 07:21:40 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Thomas Gleixner References: <87mtjc2lhe.ffs@tglx> From: Guenter Roeck Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity() In-Reply-To: <87mtjc2lhe.ffs@tglx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Mark Rutland , Stuart Yoder , linux-pci@vger.kernel.org, Will Deacon , Peter Ujfalusi , Ashok Raj , Jassi Brar , Sinan Kaya , Vinod Koul , Bjorn Helgaas , Megha Dey , Jason Gunthorpe , xen-devel@lists.xenproject.org, Kevin Tian , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, Alex Williamson , Cedric Le Goater , Santosh Shilimkar , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Juergen Gross , Tero Kristo , Greg Kroah-Hartman , LKML , iommu@lists.linux-foundation.org, Marc Zygnier , dmaengine@vger.kernel.org, Robin Murphy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 1/31/22 03:27, Thomas Gleixner wrote: > On Sun, Jan 30 2022 at 09:12, Guenter Roeck wrote: >> On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: >> This patch results in the following runtime warning when booting x86 >> (32 bit) nosmp images from NVME in qemu. >> >> [ 14.825482] nvme nvme0: 1/0/0 default/read/poll queues >> ILLOPC: ca7c6d10: 0f 0b >> [ 14.826188] ------------[ cut here ]------------ >> [ 14.826307] WARNING: CPU: 0 PID: 7 at drivers/pci/msi/msi.c:1114 pci_irq_get_affinity+0x80/0x90 > > This complains about msi_desc->affinity being NULL. > >> git bisect bad f48235900182d64537c6e8f8dc0932b57a1a0638 >> # first bad commit: [f48235900182d64537c6e8f8dc0932b57a1a0638] PCI/MSI: Simplify pci_irq_get_affinity() > > Hrm. Can you please provide dmesg and /proc/interrupts from a > kernel before that commit? > Sure. Please see http://server.roeck-us.net/qemu/x86/. The logs are generated with with v5.16.4. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 154AEC433EF for ; Mon, 31 Jan 2022 15:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WhGLWxk25Za/x1d0aDcy/aXyuttWMqJeMTpYmtpvla4=; b=TeqC7Yd4spaM/y 7ryHEjrSocOmYeErb3M/spvIZn3Ep0OrUlSSpek+xR26hL7nmZJNUU0mxUbbjji03Vr4Sy55RKgCV vxEHp1Mh8k7MFRSQNXK/yx246GOfylalXelfQQo07q746AA/kIY+AN/C2EeHUj+6wJLAy1DxyQoTT PPIglOrRFv1B9+CopG7L9ZEN0L9QXhvMOpEbgRrS7aiMlKx7JLiYrfkq1+ddevqvQnSP4ZOgrdQcf fkJnRwDngG/BD4ARFFHOW/O3K3X6xDjgB8jIcRQFWsINi8j4LwZ1czNP3sCPKSWZ/dS713TNwwyjo gvXIXczdBehqGAZknDuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEYVc-009gQ2-Qh; Mon, 31 Jan 2022 15:22:25 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEYVY-009gOH-Sz for linux-arm-kernel@lists.infradead.org; Mon, 31 Jan 2022 15:22:22 +0000 Received: by mail-oi1-x22b.google.com with SMTP id r27so5071036oiw.4 for ; Mon, 31 Jan 2022 07:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:content-language:to :cc:references:from:subject:in-reply-to:content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=NXQ2vh5WqJcNrwvi+uhxOeXRwL3TuQvr8zI74nXKNlbA4THVcrFQe20l84a2F3rCSl fb+2O3VmewcReatZ19klOskQ2upf6qljRrD6n2B9Y4PhroYWW+XOfsdsfB3MZuirxQ9t X+vPYa1ikH13JYbnSKqVdMeH1jmxa4D6k59/FHZubOFHJbDfNxiaB8VfMIjtaMgLtJV+ 3A2GEeuqlrodVHjFD7y9lvjUf+N31nBGTmFabP1WX1nvXw95IBSd2qgNRGX0BxRvAmns 3J8DZp0qcC/r7rrsLbS0TgQNcR7BR3VDw0NU5D6j9PO9dXHpEDeoVqLmRligf9NcdWA6 MSIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=oVZWckNIPsWHeKbXJ2sFvACBl5okPcSAEIsKC6XhxDU=; b=kcCDoxM59HTDLUzEkI4mNK38Q29X1nmU2TxIWyF/dh6hvHzgl3QuqAVfHMzzC4+gSS 9R7lwma0IVNX2qBRr9zmvnKw0ztaOS5vXbDHtn31iZLh/bm0LUedlXo6xQDdWZBZJruN wiyxSb3zLeKsof+1txNHK+gYcMzWJl+HB5Qerz4nnwjevo0fPUbqqVycuLDZV4gFF52b WNBzasZECmmUEydO4dWgVhuBgsewwkkE6ZfNLtLr3tTIJ3l/QH8evT5bVwX6vFu49Ziz omeb2yerHiIo0CVLmZ/4EtCe4s191AhmbrUQs1s8OZS7ERntpwTHtcrZk66Z5kgYiDMN Ke4Q== X-Gm-Message-State: AOAM530uBb1Fp3kzAbCzubBY9WwnvSi8lerHKRRO88KIt//7yaeQBJzK bzMcXv0SEjO+WU7msfBDd3IOye/YHlzFuA== X-Google-Smtp-Source: ABdhPJwZ2DsfGoZh9WlCulrelJMyxXaQWZM7t1bPVVjVsAMl6JMrpJ5ac6K1xcqWaqkMGtPCEBWrHw== X-Received: by 2002:a05:6808:211f:: with SMTP id r31mr12780920oiw.194.1643642506160; Mon, 31 Jan 2022 07:21:46 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d65sm9789045otb.17.2022.01.31.07.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 07:21:44 -0800 (PST) Message-ID: Date: Mon, 31 Jan 2022 07:21:40 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Thomas Gleixner Cc: LKML , Nishanth Menon , Mark Rutland , Stuart Yoder , Benjamin Herrenschmidt , Will Deacon , Ashok Raj , Michael Ellerman , Jassi Brar , Sinan Kaya , iommu@lists.linux-foundation.org, Peter Ujfalusi , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Jason Gunthorpe , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Kevin Tian , Arnd Bergmann , Robin Murphy , Alex Williamson , Cedric Le Goater , Santosh Shilimkar , Bjorn Helgaas , Megha Dey , Juergen Gross , Tero Kristo , Greg Kroah-Hartman , Vinod Koul , Marc Zygnier , dmaengine@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <87mtjc2lhe.ffs@tglx> From: Guenter Roeck Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity() In-Reply-To: <87mtjc2lhe.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220131_072221_008522_B227848C X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/31/22 03:27, Thomas Gleixner wrote: > On Sun, Jan 30 2022 at 09:12, Guenter Roeck wrote: >> On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: >> This patch results in the following runtime warning when booting x86 >> (32 bit) nosmp images from NVME in qemu. >> >> [ 14.825482] nvme nvme0: 1/0/0 default/read/poll queues >> ILLOPC: ca7c6d10: 0f 0b >> [ 14.826188] ------------[ cut here ]------------ >> [ 14.826307] WARNING: CPU: 0 PID: 7 at drivers/pci/msi/msi.c:1114 pci_irq_get_affinity+0x80/0x90 > > This complains about msi_desc->affinity being NULL. > >> git bisect bad f48235900182d64537c6e8f8dc0932b57a1a0638 >> # first bad commit: [f48235900182d64537c6e8f8dc0932b57a1a0638] PCI/MSI: Simplify pci_irq_get_affinity() > > Hrm. Can you please provide dmesg and /proc/interrupts from a > kernel before that commit? > Sure. Please see http://server.roeck-us.net/qemu/x86/. The logs are generated with with v5.16.4. Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel